-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(alloydb): use network_config instead of deprecated network in examples #9113
docs(alloydb): use network_config instead of deprecated network in examples #9113
Conversation
Hello! I am a robot. It looks like you are a: Community Contributor @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in getting to this! If you can resolve the conflicts with main
I'll run these tests and then LGTM/merge assuming they pass.
d746538
to
b19bdfb
Compare
@rileykarson |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 33 insertions(+), 11 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAlloydbCluster_mandatoryFields|TestAccAlloydbCluster_update|TestAccAlloydbCluster_maximumFields|TestAccAlloydbBackup_alloydbBackupFullExample|TestAccAlloydbCluster_alloydbClusterFullExample|TestAccAlloydbCluster_alloydbClusterBasicExample|TestAccAlloydbBackup_alloydbBackupBasicExample|TestAccAlloydbInstance_alloydbInstanceBasicExample|TestAccAlloydbCluster_deleteTimeBasedRetentionPolicy|TestAccAlloydbCluster_deleteAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_addAutomatedBackupPolicyAndInitialUser|TestAccDataSourceGoogleServiceAccountJwt |
Rerun these tests in REPLAYING mode to catch issues
|
@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 3 weeks. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, lost this email. If you can merge or rebase onto main I can make a pass!
…amples Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>
b19bdfb
to
419c174
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAlloydbCluster_addAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_alloydbClusterBasicExample|TestAccAlloydbCluster_alloydbClusterFullExample|TestAccAlloydbCluster_deleteAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_deleteTimeBasedRetentionPolicy|TestAccAlloydbCluster_mandatoryFields|TestAccAlloydbCluster_maximumFields|TestAccAlloydbCluster_update |
|
@rileykarson |
LGTM, thanks! |
…amples (GoogleCloudPlatform#9113) Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>
…amples (GoogleCloudPlatform#9113) Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>
The
network
field ingoogle_alloydb_cluster
resource has been deprecated by #8963, but examples in the documentation have not been updated accordingly. This PR makes changes to usenetwork_config
in the examples.Part of hashicorp/terraform-provider-google#16119
Release Note Template for Downstream PRs (will be copied)