Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(alloydb): use network_config instead of deprecated network in examples #9113

Conversation

toVersus
Copy link
Contributor

@toVersus toVersus commented Sep 28, 2023

The network field in google_alloydb_cluster resource has been deprecated by #8963, but examples in the documentation have not been updated accordingly. This PR makes changes to use network_config in the examples.

Part of hashicorp/terraform-provider-google#16119

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 28, 2023
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in getting to this! If you can resolve the conflicts with main I'll run these tests and then LGTM/merge assuming they pass.

@toVersus toVersus force-pushed the docs-alloydb-cluster-network-config branch from d746538 to b19bdfb Compare October 5, 2023 01:18
@toVersus
Copy link
Contributor Author

toVersus commented Oct 5, 2023

@rileykarson
Thanks for taking the time to look at this! I have resolved the conflicts.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 5, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 33 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 6 files changed, 33 insertions(+), 11 deletions(-))
TF OiCS: Diff ( 5 files changed, 15 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3119
Passed tests 2789
Skipped tests: 318
Affected tests: 12

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAlloydbCluster_mandatoryFields|TestAccAlloydbCluster_update|TestAccAlloydbCluster_maximumFields|TestAccAlloydbBackup_alloydbBackupFullExample|TestAccAlloydbCluster_alloydbClusterFullExample|TestAccAlloydbCluster_alloydbClusterBasicExample|TestAccAlloydbBackup_alloydbBackupBasicExample|TestAccAlloydbInstance_alloydbInstanceBasicExample|TestAccAlloydbCluster_deleteTimeBasedRetentionPolicy|TestAccAlloydbCluster_deleteAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_addAutomatedBackupPolicyAndInitialUser|TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbCluster_mandatoryFields[Debug log]
TestAccAlloydbCluster_update[Debug log]
TestAccAlloydbCluster_maximumFields[Debug log]
TestAccAlloydbCluster_alloydbClusterFullExample[Debug log]
TestAccAlloydbCluster_alloydbClusterBasicExample[Debug log]
TestAccAlloydbInstance_alloydbInstanceBasicExample[Debug log]
TestAccAlloydbCluster_deleteTimeBasedRetentionPolicy[Debug log]
TestAccAlloydbCluster_deleteAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_addAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbBackup_alloydbBackupFullExample[Error message] [Debug log]
TestAccAlloydbBackup_alloydbBackupBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

Copy link

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, lost this email. If you can merge or rebase onto main I can make a pass!

…amples

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>
@toVersus toVersus force-pushed the docs-alloydb-cluster-network-config branch from b19bdfb to 419c174 Compare May 22, 2024 20:54
@github-actions github-actions bot requested a review from rileykarson May 22, 2024 20:54
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/alloydb and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels May 22, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 28 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 4 files changed, 28 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 8 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 65
Passed tests: 53
Skipped tests: 4
Affected tests: 8

Click here to see the affected service packages
  • alloydb

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAlloydbCluster_addAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_alloydbClusterBasicExample|TestAccAlloydbCluster_alloydbClusterFullExample|TestAccAlloydbCluster_deleteAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_deleteTimeBasedRetentionPolicy|TestAccAlloydbCluster_mandatoryFields|TestAccAlloydbCluster_maximumFields|TestAccAlloydbCluster_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbCluster_addAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_alloydbClusterBasicExample[Debug log]
TestAccAlloydbCluster_alloydbClusterFullExample[Debug log]
TestAccAlloydbCluster_deleteAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_deleteTimeBasedRetentionPolicy[Debug log]
TestAccAlloydbCluster_mandatoryFields[Debug log]
TestAccAlloydbCluster_maximumFields[Debug log]
TestAccAlloydbCluster_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@toVersus
Copy link
Contributor Author

If you can merge or rebase onto main I can make a pass!

@rileykarson
Thanks for notifying me. Done!

@rileykarson
Copy link
Member

LGTM, thanks!

Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
…amples (GoogleCloudPlatform#9113)

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
…amples (GoogleCloudPlatform#9113)

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants