added `google_service_networking_connection` deletion to 5.0 guide #9009

zli82016 · 2023-09-19T21:36:40Z

The change is in PR #8904

Release Note Template for Downstream PRs (will be copied)

docs: added `google_service_networking_connection` deletion to 5.0 guide

modular-magician · 2023-09-19T21:46:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 4 insertions(+))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+))

c2thorn · 2023-09-20T17:46:36Z

mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown

@@ -490,6 +490,10 @@ If you were relying on accessing an individual flag by index (for example, `goog

 `google_service_networking_connection` now uses the Create endpoint instead of the Patch endpoint during the creation step. Previously, Patch was used as a workaround for an issue that has since been resolved.

+### `deleteConnection` method is used to delete the resource
+
+`google_service_networking_connection` now uses `deleteConnection` method instead of `removePeering` method during the deletion step. Previously, `removePeering` method was used because `deleteConnection` method was unavailable. Sometimes a private connection cannot be deleted immediately after the resource using that connectioin is deleted, and you have to delete the private connection manually after a waiting period.


Suggested change

`google_service_networking_connection` now uses `deleteConnection` method instead of `removePeering` method during the deletion step. Previously, `removePeering` method was used because `deleteConnection` method was unavailable. Sometimes a private connection cannot be deleted immediately after the resource using that connectioin is deleted, and you have to delete the private connection manually after a waiting period.

`google_service_networking_connection` now uses `deleteConnection` API method instead of `removePeering` method during the deletion step. Previously, `removePeering` method was used because `deleteConnection` method was unavailable. In some cases a private connection cannot be deleted immediately after the resource using that connection is deleted, and users may have to delete the private connection manually after a waiting period.

Sometimes a private connection cannot be deleted immediately after the resource using that connection is deleted, and you have to delete the private connection manually after a waiting period.

Are we expecting deletion to return an error often? If so, that seems very annoying for users. Should there be a retry?

Retry is a good idea, but there is a corner case for sql database instances. It returns an error that the connection is still be used by the service. After the action to delete a sql instance is made, it needs to wait for four days to delete the resource in deed, and then the connection can be deleted. It seems that the waiting period is too long to have a retry.

I see. Looking at the code, I see in this case we silently fail instead. That is not as bad.
Definitely 4 days is too long for a retry

c2thorn · 2023-09-20T18:52:29Z

mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown

@@ -490,6 +490,10 @@ If you were relying on accessing an individual flag by index (for example, `goog

 `google_service_networking_connection` now uses the Create endpoint instead of the Patch endpoint during the creation step. Previously, Patch was used as a workaround for an issue that has since been resolved.

+### `deleteConnection` method is used to delete the resource


Looking at the code, I see we actually do abandon if the delete fails, so this suggestion is not valid.

Suggested change

### `deleteConnection` method is used to delete the resource

### `deleteConnection` API method is attempted to delete the resource

maybe?

Looking at the code, I see we actually do abandon if the delete fails, so this suggestion is not valid.

I am not sure if you checked the latest version of PR 8904. It does not abandon the resource after deletion failed and just logged the error.

I think about it again. It looks like I should return the error instead of catch it and log it? But I am not sure if it will affect the users or not to return the error.

I misread and thought it was abandon, thanks for the correction. In the PR now, what happens after terraform destroy in that scenario? Just logs and keeps the state the same?

The previous functionality was to remove peering and then abandon the resource without deleting right?

That is a good point.

Right, the previous implementation calls removePeering method. It removed peering, then abandoned the resource without deleting. The connection is not deleted actually, which caused the issue that the tenant projects/resources reach to the limit. https://buganizer.corp.google.com/issues/248298764

In the PR 8904, I change it to call the method deleteConnection, catch and log the error. After terraform destroy, the connection disappears in the state. That is not expected.

I tested another option to not catch and return error if deleteConnection fails. terraform destroy fails with the error and the connection stays in the state. It looks like I should go with this option.

modular-magician · 2023-09-20T23:34:15Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 4 insertions(+))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+))

…oogleCloudPlatform#9009) * Add 5.0 guide to delete google_service_networking_connection * Address comment

Add 5.0 guide to delete google_service_networking_connection

08a1400

zli82016 mentioned this pull request Sep 19, 2023

Fix failed tests related to google_service_networking_connection #8904

Merged

zli82016 requested a review from c2thorn September 19, 2023 23:57

c2thorn requested changes Sep 20, 2023

View reviewed changes

Address comment

28e0b43

zli82016 changed the title ~~Add 5.0 guide to delete google_service_networking_connection~~ added google_service_networking_connection deletion to 5.0 guide Sep 20, 2023

zli82016 requested a review from c2thorn September 20, 2023 23:58

c2thorn approved these changes Sep 21, 2023

View reviewed changes

zli82016 merged commit e5f527e into main Sep 21, 2023

zli82016 deleted the google_service_networking_connection-delete-guide branch September 21, 2023 18:20

This was referenced Sep 21, 2023

added google_service_networking_connection deletion to 5.0 guide hashicorp/terraform-provider-google-beta#6333

Merged

added google_service_networking_connection deletion to 5.0 guide hashicorp/terraform-provider-google#15935

Merged

nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Sep 22, 2023

added google_service_networking_connection deletion to 5.0 guide (G…

f465d10

…oogleCloudPlatform#9009) * Add 5.0 guide to delete google_service_networking_connection * Address comment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added `google_service_networking_connection` deletion to 5.0 guide #9009

added `google_service_networking_connection` deletion to 5.0 guide #9009

zli82016 commented Sep 19, 2023 •

edited

Loading

modular-magician commented Sep 19, 2023

c2thorn Sep 20, 2023

c2thorn Sep 20, 2023

zli82016 Sep 20, 2023

c2thorn Sep 20, 2023 •

edited

Loading

This comment was marked as outdated.

c2thorn Sep 20, 2023

c2thorn Sep 20, 2023

zli82016 Sep 20, 2023 •

edited

Loading

c2thorn Sep 20, 2023

zli82016 Sep 20, 2023 •

edited

Loading

modular-magician commented Sep 20, 2023

		@@ -490,6 +490,10 @@ If you were relying on accessing an individual flag by index (for example, `goog

		`google_service_networking_connection` now uses the Create endpoint instead of the Patch endpoint during the creation step. Previously, Patch was used as a workaround for an issue that has since been resolved.

		### `deleteConnection` method is used to delete the resource

	### `deleteConnection` method is used to delete the resource
	### `deleteConnection` API method is attempted to delete the resource

added google_service_networking_connection deletion to 5.0 guide #9009

added google_service_networking_connection deletion to 5.0 guide #9009

Conversation

zli82016 commented Sep 19, 2023 • edited Loading

modular-magician commented Sep 19, 2023

Diff report

c2thorn Sep 20, 2023

Choose a reason for hiding this comment

c2thorn Sep 20, 2023

Choose a reason for hiding this comment

zli82016 Sep 20, 2023

Choose a reason for hiding this comment

c2thorn Sep 20, 2023 • edited Loading

Choose a reason for hiding this comment

This comment was marked as outdated.

c2thorn Sep 20, 2023

Choose a reason for hiding this comment

c2thorn Sep 20, 2023

Choose a reason for hiding this comment

zli82016 Sep 20, 2023 • edited Loading

Choose a reason for hiding this comment

c2thorn Sep 20, 2023

Choose a reason for hiding this comment

zli82016 Sep 20, 2023 • edited Loading

Choose a reason for hiding this comment

modular-magician commented Sep 20, 2023

Diff report

added `google_service_networking_connection` deletion to 5.0 guide #9009

added `google_service_networking_connection` deletion to 5.0 guide #9009

zli82016 commented Sep 19, 2023 •

edited

Loading

c2thorn Sep 20, 2023 •

edited

Loading

zli82016 Sep 20, 2023 •

edited

Loading

zli82016 Sep 20, 2023 •

edited

Loading