Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added google_service_networking_connection deletion to 5.0 guide #9009

Merged
merged 2 commits into from
Sep 21, 2023
Merged

added google_service_networking_connection deletion to 5.0 guide #9009

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08a1400
Add 5.0 guide to delete google_service_networking_connection
zli82016 Sep 19, 2023
28e0b43
Address comment
zli82016 Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,10 @@ If you were relying on accessing an individual flag by index (for example, `goog

`google_service_networking_connection` now uses the Create endpoint instead of the Patch endpoint during the creation step. Previously, Patch was used as a workaround for an issue that has since been resolved.

### "terraform destroy" now fully deletes the resource instead of abandoning

`google_service_networking_connection` now uses API `deleteConnection` method instead of `removePeering` method during the deletion step. Previously, `removePeering` method was used because `deleteConnection` method was unavailable. In some cases a private connection cannot be deleted immediately after the resource using that connection is deleted, and users may have to delete the private connection after a waiting period.

## Resource: `google_secret_manager_secret`

### `replication.automatic` is now removed
Expand Down