Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unignore empty values location logic 5.0.0 #9015

Conversation

SarahFrench
Copy link
Collaborator

@SarahFrench SarahFrench commented Sep 20, 2023

I've made this PR with the intention of closing it, as I realised that this work cannot be completed until later in the plugin-framework migration project.


Release Note Template for Downstream PRs (will be copied)

provider: empty strings provided as `location`/`region`/`zone` arguments to resources will not be ignored in favor of alternative values set on the provider

…ue for a resource/data-source that's migrated to the plugin framework

Only PF migrated datasources/resources are affected by this code change
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 35 insertions(+), 58 deletions(-))
Terraform Beta: Diff ( 2 files changed, 35 insertions(+), 58 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3035
Passed tests 2730
Skipped tests: 304
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccVertexAIIndexEndpoint_updated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccVertexAIIndexEndpoint_updated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@SarahFrench
Copy link
Collaborator Author

Closing this PR because it would result in breaking changes for users when any datasources/resources are migrated to the plugin framework. Configs that contained empty strings in resource blocks etc would stop being valid configs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants