[Please ignore: fix build] Unignore empty values in the provider configuration block in 5.0.0
#6346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ashicorp#9014) * Stop validating `""` as valid `credentials` value in the PF provider config * Remove code that makes PF ignore empty values * Update PF config code tests to match change in PF config code behaviour * Update remaining PF config code tests * Update test for the PF version of credentials validator * Make not on SDK version of credentials validator that it cannot distinguish between `""` in config vs zero values Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
force-pushed
the
downstream-pr-83df04114dd8f94bff865079d04b37dd0979f2fa
branch
from
33fc047 to
9c2b180
Compare
modular-magician
merged commit bb51d02
into
hashicorp:FEATURE-BRANCH-major-release-5.0.0
shuyama1
changed the title
provider configuration block in 5.0.0provider configuration block in 5.0.0
modular-magician
deleted the
downstream-pr-83df04114dd8f94bff865079d04b37dd0979f2fa
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops the provider ignoring empty strings in provider blocks; if the value is in a user's config then it should be used by the code or removed by the user.
After muxing the provider we accidentally changed its behaviour to stop ignoring empty strings. That behaviour is what we'd expect the correct behaviour to be, so we are reverting to the old behaviour in a 4.x.x release (see GoogleCloudPlatform/magic-modules#8798) and then intentionally making the switch to the new behaviour as part of 5.0.0
ALSO I've decided against making similar changes in GoogleCloudPlatform/magic-modules#9015 because it would result in breaking changes for users when any datasources/resources are migrated to the plugin framework.
To do:
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9014