Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make vpc-native clusters the default (for new clusters) #9067

Merged
merged 5 commits into from
Sep 28, 2023
Merged

make vpc-native clusters the default (for new clusters) #9067

merged 5 commits into from
Sep 28, 2023

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Sep 24, 2023 •
edited
Loading

fixes hashicorp/terraform-provider-google#5842

makes networking_mode default to VPC_NATIVE only during creation

Release Note Template for Downstream PRs (will be copied)

container: newly created `google_container_cluster` resources now default to VPC-native instead of routes-based.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 23 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 3 files changed, 23 insertions(+), 8 deletions(-))

@modular-magician

This comment was marked as outdated.

Sign in to view
@modular-magician

This comment was marked as outdated.

Sign in to view
@c2thorn
Copy link
Member Author

c2thorn commented Sep 25, 2023

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 23 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 3 files changed, 23 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3082
Passed tests 2627
Skipped tests: 314
Affected tests: 141

Action taken

Found 141 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerCluster_withNodeConfigReservationAffinity|TestAccContainerCluster_withMaintenanceExclusionOptions|TestAccContainerCluster_withLoggingConfig|TestAccContainerCluster_withIdentityServiceConfig|TestAccContainerCluster_deleteMaintenanceExclusionOptions|TestAccContainerCluster_updateMaintenanceExclusionOptions|TestAccContainerCluster_autoprovisioningDefaultsManagement|TestAccContainerCluster_deleteExclusionWindow|TestAccContainerNodePool_withHostMaintenancePolicy|TestAccContainerCluster_withMaintenanceExclusionWindow|TestAccContainerClusterDatasource_zonal|TestAccContainerNodePool_withConfidentialNodes|TestAccContainerCluster_withCostManagementConfig|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_withExternalIpsConfig|TestAccContainerCluster_withMonitoringConfig|TestAccContainerCluster_withMeshCertificatesConfig|TestAccContainerCluster_withSoleTenantGroup|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerCluster_nodeAutoprovisioningNetworkTags|TestAccContainerCluster_nodeAutoprovisioningDefaultsShieldedInstance|TestAccContainerCluster_withDNSConfig|TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey|TestAccContainerCluster_withProtectConfig|TestAccContainerCluster_autoprovisioningDefaultsUpgradeSettings|TestAccContainerCluster_withSecurityPostureConfig|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_withNodePoolDefaults|TestAccContainerCluster_withLoggingVariantUpdates|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_withLoggingVariantInNodePool|TestAccContainerCluster_withLoggingVariantInNodeConfig|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_withGatewayApiConfig|TestAccContainerCluster_withNodeConfig|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withEnableKubernetesBetaAPIsOnExistingCluster|TestAccContainerCluster_withIntraNodeVisibility|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_withPrivateClusterConfigGlobalAccessEnabledOnly|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withVersion|TestAccContainerCluster_updateVersion|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_regional|TestAccContainerCluster_withBinaryAuthorizationEnabledBool|TestAccContainerNodePool_basicWithClusterId|TestAccContainerNodePool_basic|TestAccContainerCluster_withNodePoolCIA|TestAccContainerCluster_withAutoscalingProfile|TestAccContainerCluster_withEnableKubernetesBetaAPIs|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_networkingModeRoutes|TestAccContainerCluster_withTelemetryEnabled|TestAccContainerCluster_customPlacementPolicy|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccContainerCluster_withMasterAuthConfig_NoCert|TestAccContainerCluster_withGcpPublicCidrsAccessEnabledToggle|TestAccContainerCluster_withEnablePrivateEndpointToggle|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_basic|TestAccContainerNodePool_threadsPerCore|TestAccContainerNodePool_totalSize|TestAccContainerCluster_withNotificationConfig|TestAccContainerNodePool_compactPlacement|TestAccContainerCluster_withAddons|TestAccContainerNodePool_gcfsConfig|TestAccContainerNodePool_gvnic|TestAccContainerNodePool_fastSocket|TestAccContainerNodePool_customPlacementPolicy|TestAccContainerCluster_misc|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb|TestAccContainerNodePool_ephemeralStorageConfig|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerCluster_withFilteredNotificationConfig|TestAccContainerNodePool_localNvmeSsdBlockConfig|TestAccContainerNodePool_ephemeralStorageLocalSsdConfig|TestAccContainerNodePool_resize|TestAccContainerNodePool_shieldedInstanceConfig|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_concurrent|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_withSoleTenantConfig|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_withManagement|TestAccContainerNodePool_version|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerCluster_withNodePoolBasic|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_withNodeConfig|TestAccContainerCluster_withBootDiskKmsKey|TestAccContainerNodePool_withReservationAffinitySpecific|TestAccContainerNodePool_withKubeletConfig|TestAccContainerCluster_backend|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withLoggingVariantUpdates|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withReservationAffinity|TestAccContainerCluster_withNodeConfigReservationAffinitySpecific|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerCluster_withSandboxConfig|TestAccGKEBackupBackupPlanIamMemberGenerated|TestAccGKEBackupRestorePlan_gkebackupRestoreplanProtectedApplicationExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanSecondTransformationExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample|TestAccGKEBackupBackupPlanIamBindingGenerated|TestAccGKEBackupRestorePlan_gkebackupRestoreplanAllClusterResourcesExample|TestAccGKEBackupRestorePlanIamMemberGenerated|TestAccGKEBackupRestorePlan_gkebackupRestoreplanRollbackNamespaceExample|TestAccGKEBackupRestorePlanIamBindingGenerated|TestAccGKEBackupRestorePlan_gkebackupRestoreplanAllNamespacesExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanFullExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanRenameNamespaceExample|TestAccGKEBackupRestorePlanIamPolicyGenerated|TestAccGKEBackupBackupPlanIamPolicyGenerated|TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample|TestAccGKEHubMembership_gkehubMembershipIssuerExample|TestAccGKEHubMembershipIamMemberGenerated|TestAccGKEHubMembershipIamBindingGenerated|TestAccGKEHubMembership_gkehubMembershipBasicExample|TestAccGKEHubMembershipIamPolicyGenerated|TestAccGKEHub2MembershipRBACRoleBinding_gkehubMembershipRbacRoleBindingBasicExample|TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample|TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample_update

Get to know how VCR tests work

@c2thorn
Copy link
Member Author

c2thorn commented Sep 25, 2023

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 23 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 3 files changed, 23 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3082
Passed tests 2626
Skipped tests: 314
Affected tests: 142

Action taken

Found 142 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_updateMaintenanceExclusionOptions|TestAccContainerCluster_deleteMaintenanceExclusionOptions|TestAccContainerCluster_autoprovisioningDefaultsUpgradeSettings|TestAccContainerCluster_withLoggingConfig|TestAccContainerClusterDatasource_zonal|TestAccContainerCluster_withIdentityServiceConfig|TestAccContainerCluster_deleteExclusionWindow|TestAccContainerCluster_withMaintenanceExclusionOptions|TestAccContainerCluster_withMaintenanceExclusionWindow|TestAccContainerCluster_withMonitoringConfig|TestAccContainerCluster_withSoleTenantGroup|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerCluster_nodeAutoprovisioningNetworkTags|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_withBootDiskKmsKey|TestAccContainerNodePool_withHostMaintenancePolicy|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerNodePool_withConfidentialNodes|TestAccContainerCluster_backend|TestAccContainerNodePool_threadsPerCore|TestAccContainerNodePool_compactPlacement|TestAccContainerNodePool_gvnic|TestAccContainerNodePool_gcfsConfig|TestAccContainerNodePool_fastSocket|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerNodePool_customPlacementPolicy|TestAccContainerCluster_withNodePoolCIA|TestAccContainerNodePool_ephemeralStorageConfig|TestAccContainerNodePool_shieldedInstanceConfig|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerCluster_withSandboxConfig|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_concurrent|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_localNvmeSsdBlockConfig|TestAccContainerNodePool_resize|TestAccContainerNodePool_ephemeralStorageLocalSsdConfig|TestAccContainerNodePool_totalSize|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_withManagement|TestAccContainerNodePool_withSoleTenantConfig|TestAccContainerCluster_regional|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_withNodeConfig|TestAccContainerNodePool_withLoggingVariantUpdates|TestAccContainerNodePool_version|TestAccContainerCluster_withNodeConfigReservationAffinity|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_withNodePoolDefaults|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_withLoggingVariantUpdates|TestAccContainerCluster_withLoggingVariantInNodePool|TestAccContainerCluster_withLoggingVariantInNodeConfig|TestAccContainerCluster_withNodeConfig|TestAccContainerNodePool_withSandboxConfig|TestAccContainerCluster_withNodeConfigReservationAffinitySpecific|TestAccContainerNodePool_withReservationAffinity|TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withReservationAffinitySpecific|TestAccContainerCluster_withIntraNodeVisibility|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerCluster_withPrivateClusterConfigGlobalAccessEnabledOnly|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerCluster_withVersion|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerNodePool_basicWithClusterId|TestAccContainerCluster_updateVersion|TestAccContainerNodePool_basic|TestAccContainerCluster_withSecurityPostureConfig|TestAccContainerCluster_withProtectConfig|TestAccContainerCluster_customPlacementPolicy|TestAccContainerCluster_withDNSConfig|TestAccContainerCluster_withEnablePrivateEndpointToggle|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccContainerCluster_withGatewayApiConfig|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerCluster_withEnableKubernetesBetaAPIs|TestAccContainerCluster_withCostManagementConfig|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_withMeshCertificatesConfig|TestAccContainerCluster_withTelemetryEnabled|TestAccContainerCluster_withEnableKubernetesBetaAPIsOnExistingCluster|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_withExternalIpsConfig|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withMasterAuthConfig_NoCert|TestAccContainerCluster_withGcpPublicCidrsAccessEnabledToggle|TestAccContainerCluster_autoprovisioningDefaultsManagement|TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey|TestAccContainerCluster_misc|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_networkingModeRoutes|TestAccContainerCluster_withAddons|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withFilteredNotificationConfig|TestAccContainerCluster_basic|TestAccContainerCluster_nodeAutoprovisioningDefaultsShieldedInstance|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_withBinaryAuthorizationEnabledBool|TestAccContainerCluster_withAutoscalingProfile|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb|TestAccGKEBackupRestorePlan_gkebackupRestoreplanRollbackNamespaceExample|TestAccGKEBackupBackupPlanIamMemberGenerated|TestAccGKEBackupRestorePlan_gkebackupRestoreplanRenameNamespaceExample|TestAccGKEBackupRestorePlanIamBindingGenerated|TestAccGKEBackupRestorePlan_gkebackupRestoreplanProtectedApplicationExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanSecondTransformationExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanAllClusterResourcesExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanAllNamespacesExample|TestAccGKEBackupBackupPlanIamBindingGenerated|TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample|TestAccGKEBackupRestorePlanIamMemberGenerated|TestAccGKEBackupBackupPlan_gkebackupBackupplanFullExample|TestAccGKEBackupRestorePlanIamPolicyGenerated|TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample|TestAccGKEBackupBackupPlanIamPolicyGenerated|TestAccGKEHubMembership_gkehubMembershipIssuerExample|TestAccGKEHubMembership_gkehubMembershipBasicExample|TestAccGKEHubMembershipIamMemberGenerated|TestAccGKEHubMembershipIamBindingGenerated|TestAccGKEHubMembershipIamPolicyGenerated|TestAccGKEHub2MembershipRBACRoleBinding_gkehubMembershipRbacRoleBindingBasicExample|TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample_update|TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample|TestAccProjectIamPolicy_invalidMembers

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 23 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 3 files changed, 23 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3083
Passed tests 2626
Skipped tests: 314
Affected tests: 143

Action taken

Found 143 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerNodePool_compactPlacement|TestAccContainerNodePool_withHostMaintenancePolicy|TestAccContainerClusterDatasource_zonal|TestAccContainerNodePool_withConfidentialNodes|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_withManagement|TestAccContainerNodePool_fastSocket|TestAccContainerNodePool_gcfsConfig|TestAccContainerNodePool_threadsPerCore|TestAccContainerNodePool_gvnic|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_ephemeralStorageConfig|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_shieldedInstanceConfig|TestAccContainerNodePool_totalSize|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_resize|TestAccContainerNodePool_concurrent|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerCluster_withSoleTenantGroup|TestAccContainerNodePool_customPlacementPolicy|TestAccContainerCluster_withVersion|TestAccContainerCluster_withNodeConfigReservationAffinitySpecific|TestAccContainerNodePool_localNvmeSsdBlockConfig|TestAccContainerNodePool_ephemeralStorageLocalSsdConfig|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_withSoleTenantConfig|TestAccContainerCluster_withGcpPublicCidrsAccessEnabledToggle|TestAccContainerNodePool_version|TestAccContainerNodePool_withLoggingVariantUpdates|TestAccContainerNodePool_basicWithClusterId|TestAccContainerNodePool_withNodeConfig|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerNodePool_basic|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerCluster_customPlacementPolicy|TestAccContainerCluster_withSecurityPostureConfig|TestAccContainerCluster_withProtectConfig|TestAccContainerNodePool_withReservationAffinity|TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withSandboxConfig|TestAccContainerCluster_withDNSConfig|TestAccContainerNodePool_withReservationAffinitySpecific|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerCluster_withEnablePrivateEndpointToggle|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerCluster_withGatewayApiConfig|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerCluster_autoprovisioningDefaultsManagement|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerCluster_withEnableKubernetesBetaAPIs|TestAccContainerCluster_withEnableKubernetesBetaAPIsOnExistingCluster|TestAccContainerCluster_withCostManagementConfig|TestAccContainerCluster_withMeshCertificatesConfig|TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey|TestAccContainerCluster_withExternalIpsConfig|TestAccContainerCluster_nodeAutoprovisioningDefaultsShieldedInstance|TestAccContainerCluster_withBinaryAuthorizationEnabledBool|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_withAutoscalingProfile|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb|TestAccContainerCluster_withIntraNodeVisibility|TestAccContainerCluster_withPrivateClusterConfigGlobalAccessEnabledOnly|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType|TestAccContainerCluster_deleteExclusionWindow|TestAccContainerCluster_withLoggingConfig|TestAccContainerCluster_withIdentityServiceConfig|TestAccContainerCluster_withMonitoringConfig|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_autoprovisioningDefaultsUpgradeSettings|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_withTelemetryEnabled|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccContainerCluster_nodeAutoprovisioningNetworkTags|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_withMasterAuthConfig_NoCert|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withFilteredNotificationConfig|TestAccContainerCluster_updateMaintenanceExclusionOptions|TestAccContainerCluster_deleteMaintenanceExclusionOptions|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_withMaintenanceExclusionOptions|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withMaintenanceExclusionWindow|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withLoggingVariantUpdates|TestAccContainerCluster_withNodePoolCIA|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_withNodeConfigReservationAffinity|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_withNodePoolDefaults|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_misc|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withLoggingVariantInNodeConfig|TestAccContainerCluster_withLoggingVariantInNodePool|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_networkingModeRoutes|TestAccContainerCluster_regional|TestAccContainerCluster_basic|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_withNodeConfig|TestAccContainerCluster_withAddons|TestAccContainerCluster_withBootDiskKmsKey|TestAccContainerCluster_backend|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerCluster_updateVersion|TestAccContainerCluster_withSandboxConfig|TestAccDataprocJobIamPolicy|TestAccGKEBackupRestorePlan_gkebackupRestoreplanRollbackNamespaceExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanAllNamespacesExample|TestAccGKEBackupBackupPlanIamMemberGenerated|TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanFullExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanProtectedApplicationExample|TestAccGKEBackupBackupPlanIamBindingGenerated|TestAccGKEBackupRestorePlanIamMemberGenerated|TestAccGKEBackupRestorePlanIamBindingGenerated|TestAccGKEBackupRestorePlan_gkebackupRestoreplanAllClusterResourcesExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanRenameNamespaceExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanSecondTransformationExample|TestAccGKEBackupBackupPlanIamPolicyGenerated|TestAccGKEBackupRestorePlanIamPolicyGenerated|TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample|TestAccGKEHubMembership_gkehubMembershipIssuerExample|TestAccGKEHubMembershipIamMemberGenerated|TestAccGKEHubMembership_gkehubMembershipBasicExample|TestAccGKEHubMembershipIamBindingGenerated|TestAccGKEHubMembershipIamPolicyGenerated|TestAccGKEHub2MembershipRBACRoleBinding_gkehubMembershipRbacRoleBindingBasicExample|TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample|TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample_update|TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

@shuyama1
Copy link
Member

I just checked the VCR cassettes recorded for this PR. Looks like we got 135+ in during the last run. I think another rerun should be able to get all of them.

@c2thorn c2thorn mentioned this pull request Sep 26, 2023
Merged
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 23 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 3 files changed, 23 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3083
Passed tests 2759
Skipped tests: 314
Affected tests: 10

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerCluster_withAddons|TestAccContainerCluster_networkingModeRoutes|TestAccContainerCluster_regionalWithNodeLocations|TestAccGKEHubMembership_gkehubMembershipIssuerExample|TestAccGKEHubMembershipIamBindingGenerated|TestAccGKEHubMembershipIamMemberGenerated|TestAccGKEHubMembership_gkehubMembershipBasicExample|TestAccGKEHubMembershipIamPolicyGenerated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerCluster_regionalWithNodeLocations[Debug log]
TestAccGKEHubMembership_gkehubMembershipIssuerExample[Debug log]
TestAccGKEHubMembershipIamBindingGenerated[Debug log]
TestAccGKEHubMembershipIamMemberGenerated[Debug log]
TestAccGKEHubMembership_gkehubMembershipBasicExample[Debug log]
TestAccGKEHubMembershipIamPolicyGenerated[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerNodePool_withKubeletConfig[Error message] [Debug log]
TestAccContainerNodePool_withUpgradeSettings[Error message] [Debug log]
TestAccContainerCluster_withAddons[Error message] [Debug log]
TestAccContainerCluster_networkingModeRoutes[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@c2thorn
Copy link
Member Author

c2thorn commented Sep 26, 2023

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 23 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 3 files changed, 23 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3084
Passed tests 2762
Skipped tests: 314
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerNodePool_withSoleTenantConfig|TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerCluster_withAddons|TestAccContainerCluster_networkingModeRoutes|TestAccContainerCluster_withSoleTenantGroup|TestAccDataprocCluster_withNodeGroupAffinity|TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerNodePool_withSoleTenantConfig[Debug log]
TestAccContainerCluster_withSoleTenantGroup[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerNodePool_withKubeletConfig[Error message] [Debug log]
TestAccContainerNodePool_withUpgradeSettings[Error message] [Debug log]
TestAccContainerCluster_withAddons[Error message] [Debug log]
TestAccContainerCluster_networkingModeRoutes[Error message] [Debug log]
TestAccDataprocCluster_withNodeGroupAffinity[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

rileykarson
rileykarson reviewed Sep 27, 2023
View reviewed changes
mmv1/third_party/terraform/services/container/resource_container_cluster.go.erb Show resolved Hide resolved
mmv1/third_party/terraform/services/container/resource_container_cluster.go.erb Outdated Show resolved Hide resolved
mmv1/third_party/terraform/services/container/resource_container_cluster.go.erb Outdated Show resolved Hide resolved
mmv1/third_party/terraform/services/container/resource_container_cluster.go.erb Outdated Show resolved Hide resolved
mmv1/third_party/terraform/website/docs/r/container_cluster.html.markdown Outdated
VPC-native clusters. Adding this block enables [IP aliasing](https://cloud.google.com/kubernetes-engine/docs/how-to/ip-aliases),
making the cluster VPC-native instead of routes-based. Structure is [documented
VPC-native clusters. If this block is unset during creation, it will be set by the GKE backend.
Adding this block enables [IP aliasing](https://cloud.google.com/kubernetes-engine/docs/how-to/ip-aliases),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Adding this block enables IP aliasing, making the cluster VPC-native instead of routes-based" is outdated

Copy link
Member Author

@c2thorn c2thorn Sep 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swore I removed this line. I'll remove it.

@rileykarson
Copy link
Member

rileykarson commented Sep 27, 2023 •
edited
Loading

I definitely want to see TestAccContainerCluster_networkingModeRoutes pass before approving this! We're seeing a recreate planned with no field indicated, which is weird.

Some of the addons are concerning too. Could changing cluster modes have changed their defaults? It's also possible that it's time-based (specifically based on picking a new default version) and re-recording did it, although those would fail in nightlies as well.

@rileykarson
Copy link
Member

Of note- networking_mode is completely absent from the diff in TestAccContainerCluster_networkingModeRoutes

@c2thorn c2thorn force-pushed the 5.0.0-container-vpc-native branch 2 times, most recently from 6824b31 to 9ab00b6 Compare September 28, 2023 10:23
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 53 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 3 files changed, 53 insertions(+), 16 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3099
Passed tests 2777
Skipped tests: 313
Affected tests: 9

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample|TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerCluster_networkingModeRoutes|TestAccContainerCluster_withDeletionProtection|TestAccContainerCluster_withAddons|TestAccProjectIamPolicy_invalidMembers|TestAccSecurityCenterFolderCustomModule

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerNodePool_withLinuxNodeConfig[Debug log]
TestAccContainerCluster_withDeletionProtection[Debug log]
TestAccProjectIamPolicy_invalidMembers[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample[Error message] [Debug log]
TestAccContainerNodePool_withKubeletConfig[Error message] [Debug log]
TestAccContainerNodePool_withUpgradeSettings[Error message] [Debug log]
TestAccContainerCluster_networkingModeRoutes[Error message] [Debug log]
TestAccContainerCluster_withAddons[Error message] [Debug log]
TestAccSecurityCenterFolderCustomModule[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 53 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 3 files changed, 53 insertions(+), 16 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3099
Passed tests 2778
Skipped tests: 313
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample|TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerCluster_withAddons|TestAccContainerCluster_networkingModeRoutes|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccSecurityCenterFolderCustomModule

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerCluster_networkingModeRoutes[Debug log]
TestAccDataSourceGoogleServiceAccountAccessToken_basic[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccDataSourceGoogleServiceAccountAccessToken_basic[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample[Error message] [Debug log]
TestAccContainerNodePool_withKubeletConfig[Error message] [Debug log]
TestAccContainerNodePool_withUpgradeSettings[Error message] [Debug log]
TestAccContainerCluster_withAddons[Error message] [Debug log]
TestAccSecurityCenterFolderCustomModule[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

rileykarson
rileykarson reviewed Sep 28, 2023
View reviewed changes
mmv1/third_party/terraform/services/container/resource_container_cluster.go.erb Outdated
@@ -782,9 +782,10 @@ func ResourceContainerCluster() *schema.Resource {
Optional: true,
Computed: true,
ForceNew: true,
Deprecated: "Deprecated in favor of ip_allocation_policy.cluster_ipv4_cidr_block",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this deprecation is safe, as ip_allocation_policy.cluster_ipv4_cidr_block only works when use_ip_aliases is true (aka the cluster is VPC-native), while this works for routes-based clusters too. The nested version of the field is deprecated in the API, but I think we removed it already clientside.

mmv1/third_party/terraform/website/docs/r/container_cluster.html.markdown Outdated
@@ -133,10 +133,11 @@ the cluster. Unless this field is set to false in Terraform state, a
`false`. This field should only be enabled for Autopilot clusters (`enable_autopilot`
set to `true`).

* `cluster_ipv4_cidr` - (Optional) The IP address range of the Kubernetes pods
* `cluster_ipv4_cidr` - (Optional, DEPRECATED) The IP address range of the Kubernetes pods
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `cluster_ipv4_cidr` - (Optional, DEPRECATED) The IP address range of the Kubernetes pods
* `cluster_ipv4_cidr` - (Optional) The IP address range of the Kubernetes pods

@c2thorn c2thorn changed the base branch from FEATURE-BRANCH-major-release-5.0.0 to main September 28, 2023 20:29
This was referenced Sep 28, 2023
Merged
Merged
@c2thorn
Copy link
Member Author

c2thorn commented Sep 28, 2023

@rileykarson added suggested changes, rebased onto main, and added upgrade guide entry directly to this PR.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 76 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 4 files changed, 76 insertions(+), 15 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3101
Passed tests 2782
Skipped tests: 313
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withKubeletConfig|TestAccContainerCluster_withAddons

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerNodePool_withUpgradeSettings[Error message] [Debug log]
TestAccContainerNodePool_withKubeletConfig[Error message] [Debug log]
TestAccContainerCluster_withAddons[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@c2thorn
Copy link
Member Author

c2thorn commented Sep 28, 2023

TestAccContainerNodePool_withUpgradeSettings
TestAccContainerNodePool_withKubeletConfig
TestAccContainerCluster_withAddons

all fail with the same errors on nightly.

@c2thorn c2thorn merged commit 879bbb7 into GoogleCloudPlatform:main Sep 28, 2023
12 of 13 checks passed
@c2thorn c2thorn deleted the 5.0.0-container-vpc-native branch September 28, 2023 23:27
This was referenced Sep 28, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make VPC-native clusters the default in google_container_cluster
4 participants
@c2thorn @modular-magician @shuyama1 @rileykarson