-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ForceNew on labels field when the dataflow job has type JOB_TYPE_BATCH #9253
Conversation
71295b4
to
7307410
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 52 insertions(+), 51 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAlloydbInstance_clientConnectionConfig|TestAccCloudRunService_cloudRunServiceSqlExample|TestAccDataprocClusterIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
mmv1/third_party/terraform/services/dataflow/resource_dataflow_flex_template_job.go.erb
Show resolved
Hide resolved
mmv1/third_party/terraform/services/dataflow/resource_dataflow_job_test.go.erb
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 116 insertions(+), 95 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming tests pass after that, LGTM!
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAlloydbBackup_alloydbBackupFullExample|TestAccAlloydbCluster_secondaryClusterMandatoryFields|TestAccComputeBackendService_withCdnPolicy|TestAccDataprocJobIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
Those AlloyDB failures are ignorable. They can't succeed right now, and a later commit has turned them off temporarily: hashicorp/terraform-provider-google#16231 |
Test |
fixes hashicorp/terraform-provider-google#16159
Added
ForceNew
tolabels
field when the dataflow job has type JOB_TYPE_BATCH to match other resources, soeffective_labels
andlabels
fields both haveForceNew
Release Note Template for Downstream PRs (will be copied)