ForceNew on labels field when the dataflow job has type JOB_TYPE_BATCH

[zli82016]

fixes hashicorp/terraform-provider-google#16159

Added ForceNew to labels field when the dataflow job has type JOB_TYPE_BATCH to match other resources, so effective_labels and labels fields both have ForceNew

Release Note Template for Downstream PRs (will be copied)

dataflow: fixed the bug that the resource update returns error if  only `labels` field has changes for batch `google_dataflow_job`

dataflow: fixed the bug that the resource update returns error if only `labels` field has changes for batch `google_dataflow_flex_template_job`

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 52 insertions(+), 51 deletions(-))
Terraform Beta: Diff ( 3 files changed, 53 insertions(+), 52 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3145
Passed tests 2826
Skipped tests: 316
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbInstance_clientConnectionConfig|TestAccCloudRunService_cloudRunServiceSqlExample|TestAccDataprocClusterIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbInstance_clientConnectionConfig[Debug log]
TestAccCloudRunService_cloudRunServiceSqlExample[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[zli82016]

Test passed
https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleBeta_MmUpstreamTesting_GOOGLEBETA_PACKAGE_DATAFLOW/41383?buildTab=tests

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 116 insertions(+), 95 deletions(-))
Terraform Beta: Diff ( 3 files changed, 167 insertions(+), 145 deletions(-))

[rileykarson]

Assuming tests pass after that, LGTM!

[modular-magician]

Tests analytics

Total tests: 3146
Passed tests 2826
Skipped tests: 316
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbBackup_alloydbBackupFullExample|TestAccAlloydbCluster_secondaryClusterMandatoryFields|TestAccComputeBackendService_withCdnPolicy|TestAccDataprocJobIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeBackendService_withCdnPolicy[Debug log]
TestAccDataprocJobIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbBackup_alloydbBackupFullExample[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterMandatoryFields[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[rileykarson]

Those AlloyDB failures are ignorable. They can't succeed right now, and a later commit has turned them off temporarily: hashicorp/terraform-provider-google#16231

[zli82016]

Test TestAccDataflowJob_withProviderDefaultLabels passed
https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleBeta_MmUpstreamTesting_GOOGLEBETA_PACKAGE_DATAFLOW/41823?buildTab=tests&expandedTest=build%3A%28id%3A41823%29%2Cid%3A2000000002