Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForceNew on labels field when the dataflow job has type JOB_TYPE_BATCH #16248

Conversation

modular-magician
Copy link
Collaborator

fixes #16159

Added ForceNew to labels field when the dataflow job has type JOB_TYPE_BATCH to match other resources, so effective_labels and labels fields both have ForceNew

Release Note Template for Downstream PRs (will be copied)

dataflow: fixed the bug that the resource update returns error if  only `labels` field has changes for batch `google_dataflow_job`
dataflow: fixed the bug that the resource update returns error if only `labels` field has changes for batch `google_dataflow_flex_template_job`

Derived from GoogleCloudPlatform/magic-modules#9253

hashicorp#9253)

* ForceNew on labels field when the dataflow job has type JOB_TYPE_BATCH

* Handle the case that no update is needed
[upstream:fa3cab8281221fcf9ad5661b3f1c2d9b68a85b7e]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 9e48dd7 into hashicorp:main Oct 13, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccDataflowJob_withProviderDefaultLabels
1 participant