-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark location
field required in v2 Cloud Run resources
#9292
Mark location
field required in v2 Cloud Run resources
#9292
Conversation
Hello! I am a robot. It looks like you are a: @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Assigning @shuyama1 as they have the most context |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 20 insertions(+), 20 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccSpannerDatabaseIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
This is technically a breaking change but should be safe to release in a minor release since without specifying the |
Fixes hashicorp/terraform-provider-google#15967.
If location field is not set, the creation of a cloud run v2 resource by Terraform won't succeed. It will throw a permission denied error since the creation request hit an incorrect API endpoint. The PR is a bug fix.
Tested manually.
Release Note Template for Downstream PRs (will be copied)