Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark location field required in v2 Cloud Run resources #9292

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

yanweiguo
Copy link
Member

@yanweiguo yanweiguo commented Oct 17, 2023

Fixes hashicorp/terraform-provider-google#15967.

If location field is not set, the creation of a cloud run v2 resource by Terraform won't succeed. It will throw a permission denied error since the creation request hit an incorrect API endpoint. The PR is a bug fix.

Tested manually.

Release Note Template for Downstream PRs (will be copied)

cloudrunv2: marked `location` field as required in resource `google_cloud_run_v2_job`. Any configuration without `location` specified will cause resource creation fail
cloudrunv2: marked `location` field as required in resource `google_cloud_run_v2_service`. Any configuration without `location` specified will cause resource creation fail

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@rileykarson rileykarson requested review from shuyama1 and removed request for rileykarson October 17, 2023 18:48
@rileykarson
Copy link
Member

Assigning @shuyama1 as they have the most context

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field location changed from optional to required on google_cloud_run_v2_job - reference
  • Field location changed from optional to required on google_cloud_run_v2_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 20 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 4 files changed, 20 insertions(+), 20 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3150
Passed tests 2832
Skipped tests: 317
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccSpannerDatabaseIamPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSpannerDatabaseIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@shuyama1 shuyama1 added the override-breaking-change Allows a potential breaking change to be merged label Oct 19, 2023
@shuyama1
Copy link
Member

shuyama1 commented Oct 19, 2023

This is technically a breaking change but should be safe to release in a minor release since without specifying the location field, the resource creation would never succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
override-breaking-change Allows a potential breaking change to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_cloud_run_v2_job location field not being marked required
4 participants