Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark location field required in v2 Cloud Run resources #16311

Conversation

modular-magician
Copy link
Collaborator

Fixes #15967.

If location field is not set, the creation of a cloud run v2 resource by Terraform won't succeed. It will throw a permission denied error since the creation request hit an incorrect API endpoint. The PR is a bug fix.

Tested manually.

Release Note Template for Downstream PRs (will be copied)

cloudrunv2: marked `location` field as required in resource `google_cloud_run_v2_job`. Any configuration without `location` specified will cause resource creation fail
cloudrunv2: marked `location` field as required in resource `google_cloud_run_v2_service`. Any configuration without `location` specified will cause resource creation fail

Derived from GoogleCloudPlatform/magic-modules#9292

)

[upstream:485e6c2e7db6d64288fc505996a8cb0cdca1384c]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit c19ae5a into hashicorp:main Oct 19, 2023
2 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_cloud_run_v2_job location field not being marked required
1 participant