Add data source for google_compute_region_disk #9421

estebanbouza · 2023-11-07T13:26:00Z

This change adds support for a data source for google_compute_region_disk .

Fixes hashicorp/terraform-provider-google#16462

Release Note Template for Downstream PRs (will be copied)

`google_compute_region_disk`

modular-magician · 2023-11-07T13:27:38Z

Hello! I am a robot. It looks like you are a: Community Contributor ~~Googler~~ ~~Core Contributor~~. Tests will require approval to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

shuyama1 · 2023-11-07T19:22:43Z

@estebanbouza Thanks for working on this! Would you mind checking the internal contribution page to get your GH account registered so that the tests will automatically run for your changes in the future. Thanks!

shuyama1 · 2023-11-07T20:12:41Z

/gcbrun

modular-magician · 2023-11-07T20:25:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 205 insertions(+))
Terraform Beta: Diff ( 4 files changed, 205 insertions(+))

modular-magician · 2023-11-07T21:46:54Z

Tests analytics

Total tests: 3209
Passed tests 2883
Skipped tests: 325
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleComputeRegionDisk_basic

Get to know how VCR tests work

modular-magician · 2023-11-07T21:48:31Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataSourceGoogleComputeRegionDisk_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

shuyama1 · 2023-11-07T22:31:43Z

Haven't looked closely into the change, only checked the failed tests. It's due to a missing required field replica_zones in the config of google_compute_region_disk in the test

shuyama1

Overall looks good. Some comments regarding tests and docs

mmv1/third_party/terraform/provider/provider.go.erb

mmv1/third_party/terraform/services/compute/data_source_google_compute_region_disk_test.go

mmv1/third_party/terraform/website/docs/d/compute_region_disk.html.markdown

…html.markdown Include documentation suggestion Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

estebanbouza

The comments have been addressed and VCR tests passing locally.

mmv1/third_party/terraform/services/compute/data_source_google_compute_region_disk_test.go

estebanbouza · 2023-12-02T09:27:33Z

@shuyama1 thanks for the detailed review. All comments should be addressed now. All tests passing locally. There's a merge conflict but I believe that's part of the auto-generated code? Let me know if you require any further changes. Thanks!

shuyama1 · 2023-12-04T22:14:01Z

@shuyama1 thanks for the detailed review. All comments should be addressed now. All tests passing locally. There's a merge conflict but I believe that's part of the auto-generated code? Let me know if you require any further changes. Thanks!

@estebanbouza Thanks for the update! We've moved out the resource/datasource map from mmv1/third_party/terraform/provider/provider.go.erb file to a separate file mmv1/third_party/terraform/provider/provider_mmv1_resources.go.erb in a recent change #9433. Since this datasource is handwritten, you'll need to move the datasource entry from the provider.go.erb to the new file to resolve the merge conflict. Sorry for the extra work.

shuyama1

LGTM overall. Only one small nit-pick and test should be triggered after the merge conflict is resolved.

mmv1/third_party/terraform/services/compute/data_source_google_compute_region_disk_test.go

…_compute_region_disk_test.go Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

modular-magician · 2023-12-05T01:13:15Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 152 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 152 insertions(+), 2 deletions(-))

modular-magician · 2023-12-05T02:27:01Z

Tests analytics

Total tests: 3261
Passed tests 2928
Skipped tests: 332
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleComputeRegionDisk_basic

Get to know how VCR tests work

modular-magician · 2023-12-05T02:29:27Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleComputeRegionDisk_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

estebanbouza · 2023-12-05T03:31:15Z

@shuyama1 changes applied, merging done, tests passing. Thanks!

shuyama1

Only one nitpick. Should be good to go after. Thanks!

shuyama1 · 2023-12-05T08:07:12Z

mmv1/third_party/terraform/provider/provider_mmv1_resources.go.erb

 	"google_compute_region_instance_group":             compute.DataSourceGoogleComputeRegionInstanceGroup(),
 	"google_compute_region_instance_template":          compute.DataSourceGoogleComputeRegionInstanceTemplate(),
+	"google_compute_region_disk":                       compute.DataSourceGoogleComputeRegionDisk(),


only nit - let's move google_compute_region_disk before google_compute_region_instance_group and revert the change of google_compute_router to follow the alphabetical order. Sorry for the nit-picks

modular-magician · 2023-12-06T23:11:42Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 151 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 5 files changed, 156 insertions(+), 1 deletion(-))

modular-magician · 2023-12-07T00:24:05Z

Tests analytics

Total tests: 3267
Passed tests 2932
Skipped tests: 334
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGKEHub2Fleet_gkehubFleetBasicExample_update

Get to know how VCR tests work

modular-magician · 2023-12-07T00:43:04Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccGKEHub2Fleet_gkehubFleetBasicExample_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

shuyama1

Thank you!

)

estebanbouza added 5 commits November 7, 2023 12:34

Add support for regional disk datasource

3aaf47d

Fix alignment

8c70e2c

Add tests for compute region disk

b3256e0

Add documentation

ece37cd

Fix documentation

b92657e

modular-magician requested a review from shuyama1 November 7, 2023 13:27

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Nov 7, 2023

modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Nov 7, 2023

shuyama1 requested changes Nov 14, 2023

View reviewed changes

Add missing replica zones

68b1670

modular-magician requested a review from shuyama1 December 2, 2023 09:01

estebanbouza and others added 4 commits December 2, 2023 09:02

Sort resource alphabetically

3cd1520

Update mmv1/third_party/terraform/website/docs/d/compute_region_disk.…

be90f47

…html.markdown Include documentation suggestion Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

Merge branch 'main' of github.com:estebanbouza/magic-modules

1068e0f

Update examples for data source

52ea016

estebanbouza commented Dec 2, 2023

View reviewed changes

mmv1/third_party/terraform/services/compute/data_source_google_compute_region_disk_test.go Show resolved Hide resolved

shuyama1 requested changes Dec 4, 2023

View reviewed changes

mmv1/third_party/terraform/services/compute/data_source_google_compute_region_disk_test.go Outdated Show resolved Hide resolved

Update mmv1/third_party/terraform/services/compute/data_source_google…

712f74b

…_compute_region_disk_test.go Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

modular-magician requested a review from shuyama1 December 5, 2023 00:26

estebanbouza added 2 commits December 5, 2023 01:00

Merge remote-tracking branch 'origin/main'

36a1fa1

Add region disk data source reference

ae78bbc

shuyama1 requested changes Dec 6, 2023

View reviewed changes

Change order

6bc71f2

modular-magician requested a review from shuyama1 December 6, 2023 23:01

shuyama1 approved these changes Dec 7, 2023

View reviewed changes

shuyama1 merged commit 65322ce into GoogleCloudPlatform:main Dec 7, 2023
15 checks passed

trodge pushed a commit to trodge/magic-modules that referenced this pull request Dec 8, 2023

Add data source for google_compute_region_disk (GoogleCloudPlatform#9421

94bcc42

)

balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024

Add data source for google_compute_region_disk (GoogleCloudPlatform#9421

944a65c

)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add data source for google_compute_region_disk #9421

Add data source for google_compute_region_disk #9421

estebanbouza commented Nov 7, 2023 •

edited by shuyama1

Loading

modular-magician commented Nov 7, 2023

shuyama1 commented Nov 7, 2023

shuyama1 commented Nov 7, 2023

modular-magician commented Nov 7, 2023

modular-magician commented Nov 7, 2023

modular-magician commented Nov 7, 2023

shuyama1 commented Nov 7, 2023

shuyama1 left a comment

estebanbouza left a comment

estebanbouza commented Dec 2, 2023

shuyama1 commented Dec 4, 2023

shuyama1 left a comment

modular-magician commented Dec 5, 2023

modular-magician commented Dec 5, 2023

modular-magician commented Dec 5, 2023

estebanbouza commented Dec 5, 2023

shuyama1 left a comment

shuyama1 Dec 5, 2023

modular-magician commented Dec 6, 2023

modular-magician commented Dec 7, 2023

modular-magician commented Dec 7, 2023

shuyama1 left a comment

Add data source for google_compute_region_disk #9421

Add data source for google_compute_region_disk #9421

Conversation

estebanbouza commented Nov 7, 2023 • edited by shuyama1 Loading

modular-magician commented Nov 7, 2023

shuyama1 commented Nov 7, 2023

shuyama1 commented Nov 7, 2023

modular-magician commented Nov 7, 2023

Diff report

modular-magician commented Nov 7, 2023

Tests analytics

Action taken

modular-magician commented Nov 7, 2023

shuyama1 commented Nov 7, 2023

shuyama1 left a comment

Choose a reason for hiding this comment

estebanbouza left a comment

Choose a reason for hiding this comment

estebanbouza commented Dec 2, 2023

shuyama1 commented Dec 4, 2023

shuyama1 left a comment

Choose a reason for hiding this comment

modular-magician commented Dec 5, 2023

Diff report

modular-magician commented Dec 5, 2023

Tests analytics

Action taken

modular-magician commented Dec 5, 2023

Rerun these tests in REPLAYING mode to catch issues

estebanbouza commented Dec 5, 2023

shuyama1 left a comment

Choose a reason for hiding this comment

shuyama1 Dec 5, 2023

Choose a reason for hiding this comment

modular-magician commented Dec 6, 2023

Diff report

modular-magician commented Dec 7, 2023

Tests analytics

Action taken

modular-magician commented Dec 7, 2023

Rerun these tests in REPLAYING mode to catch issues

shuyama1 left a comment

Choose a reason for hiding this comment

estebanbouza commented Nov 7, 2023 •

edited by shuyama1

Loading