Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data source for google_compute_region_disk #9421

Merged
merged 14 commits into from
Dec 7, 2023
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mmv1/third_party/terraform/provider/provider.go.erb
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ func DatasourceMapWithErrors() (map[string]*schema.Resource, error) {
"google_compute_backend_service": compute.DataSourceGoogleComputeBackendService(),
"google_compute_backend_bucket": compute.DataSourceGoogleComputeBackendBucket(),
"google_compute_default_service_account": compute.DataSourceGoogleComputeDefaultServiceAccount(),
"google_compute_disk": compute.DataSourceGoogleComputeDisk(),
"google_compute_disk": compute.DataSourceGoogleComputeDisk(),
"google_compute_forwarding_rule": compute.DataSourceGoogleComputeForwardingRule(),
"google_compute_global_address": compute.DataSourceGoogleComputeGlobalAddress(),
"google_compute_global_forwarding_rule": compute.DataSourceGoogleComputeGlobalForwardingRule(),
Expand All @@ -274,6 +274,7 @@ func DatasourceMapWithErrors() (map[string]*schema.Resource, error) {
"google_compute_network_peering": compute.DataSourceComputeNetworkPeering(),
"google_compute_node_types": compute.DataSourceGoogleComputeNodeTypes(),
"google_compute_regions": compute.DataSourceGoogleComputeRegions(),
"google_compute_region_disk": compute.DataSourceGoogleComputeRegionDisk(),
"google_compute_region_network_endpoint_group": compute.DataSourceGoogleComputeRegionNetworkEndpointGroup(),
"google_compute_region_instance_group": compute.DataSourceGoogleComputeRegionInstanceGroup(),
"google_compute_region_instance_template": compute.DataSourceGoogleComputeRegionInstanceTemplate(),
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
package compute

import (
"fmt"

"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/hashicorp/terraform-provider-google/google/tpgresource"
transport_tpg "github.com/hashicorp/terraform-provider-google/google/transport"
)

func DataSourceGoogleComputeRegionDisk() *schema.Resource {

dsSchema := tpgresource.DatasourceSchemaFromResourceSchema(ResourceComputeRegionDisk().Schema)
tpgresource.AddRequiredFieldsToSchema(dsSchema, "name")
tpgresource.AddOptionalFieldsToSchema(dsSchema, "project")
tpgresource.AddOptionalFieldsToSchema(dsSchema, "region")

return &schema.Resource{
Read: dataSourceGoogleComputeRegionDiskRead,
Schema: dsSchema,
}
}

func dataSourceGoogleComputeRegionDiskRead(d *schema.ResourceData, meta interface{}) error {
config := meta.(*transport_tpg.Config)

id, err := tpgresource.ReplaceVars(d, config, "projects/{{project}}/regions/{{region}}/disks/{{name}}")
if err != nil {
return fmt.Errorf("Error constructing id: %s", err)
}
d.SetId(id)
err = resourceComputeRegionDiskRead(d, meta)
if err != nil {
return err
}

if err := tpgresource.SetDataSourceLabels(d); err != nil {
return err
}

if d.Id() == "" {
return fmt.Errorf("%s not found", id)
}

return nil
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
package compute_test

import (
"testing"

"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"github.com/hashicorp/terraform-provider-google/google/acctest"
)

func TestAccDataSourceGoogleComputeRegionDisk_basic(t *testing.T) {
t.Parallel()

context := map[string]interface{}{
"random_suffix": acctest.RandString(t, 10),
}

acctest.VcrTest(t, resource.TestCase{
PreCheck: func() { acctest.AccTestPreCheck(t) },
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
CheckDestroy: testAccCheckComputeDiskDestroyProducer(t),
Steps: []resource.TestStep{
{
Config: testAccDataSourceGoogleComputeRegionDisk_basic(context),
Check: resource.ComposeTestCheckFunc(
acctest.CheckDataSourceStateMatchesResourceState("data.google_compute_region_disk.foo", "google_compute_region_disk.foo"),
),
},
},
})
}

func testAccDataSourceGoogleComputeRegionDisk_basic(context map[string]interface{}) string {
return acctest.Nprintf(`
resource "google_compute_region_disk" "foo" {
estebanbouza marked this conversation as resolved.
Show resolved Hide resolved
name = "tf-test-compute-disk-%{random_suffix}"
type = "pd-standard"
replica_zones = ["us-central1-a", "us-central1-f"]
estebanbouza marked this conversation as resolved.
Show resolved Hide resolved

labels = {
my-label = "my-label-value"
}
}

data "google_compute_region_disk" "foo" {
name = google_compute_region_disk.foo.name
project = google_compute_region_disk.foo.project
}
`, context)
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
---
subcategory: "Compute Engine"
description: |-
Get information about a Google Compute Regional Persistent disks.
---

# google\_compute\_region\_disk

Get information about a Google Compute Regional Persistent disks.

[the official documentation](https://cloud.google.com/compute/docs/disks) and its [API](https://cloud.google.com/compute/docs/reference/rest/v1/regionDisks).

## Example Usage

```hcl
data "google_compute_region_disk" "disk" {
name = "persistent-regional-disk"
project = "example"
region = "us-central1"
}

resource "google_compute_instance" "default" {
# ...

attached_disk {
source = data.google_compute_disk.disk.self_link
}
}
```

## Argument Reference

The following arguments are supported:

* `name` - (Required) The name of a specific disk.

- - -

* `region` - (Optional) A reference to the region where the disk resides.

* `project` - (Optional) The ID of the project in which the resource belongs.
If it is not provided, the provider project is used.

## Attributes Reference

See [google_compute_region_disk](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_region_disk) resource for details of the available attributes.