-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not store the ssl_mode field locally if it has never been used. #9428
Conversation
This is to make sure the irrelevant workflows doesn't need to set this ssl_mode field. See [PR](GoogleCloudPlatform#9396) for details.
Hello! I am a robot. It looks like you are a: @SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 39 insertions(+), 17 deletions(-)) |
Tests analyticsTotal tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi there - there's currently a lint check failing on this PR, could you please fix it?
==> Checking that code complies with gofmt requirements...
gofmt needs running on the following files:
make: *** [GNUmakefile:26: fmtcheck] Error 1
./google-beta/services/sql/resource_sql_database_instance_test.go
You can use the command: `make fmt` to reformat code.
i.e. (mmv1/third_party/terraform/services/sql/resource_sql_database_instance_test.go
)
Meanwhile, I'm going to trigger a non-VCR version of the acceptance test mentioned in this issue to run against this PR.
Edit: results here
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 35 insertions(+), 13 deletions(-)) |
Thanks, I have fixed the lint error and the failed tests passed. |
Tests analyticsTotal tests:
|
Hi @SarahFrench, thanks for reviewing this PR. I see all presubmit tests passed. Unfortunately I cannot login to the team city and see the test result you mentioned before. I see Are the tests passing? Thanks. |
Sorry for the delay, and that link to tests that I posted was for me/other reviewers to look at one the build had completed, so no worries about being unable to access it. All of the sql acceptance tests except |
Thank you, SarahFrench! |
…d. (GoogleCloudPlatform#9428) * fix: do not store the ssl_mode field locally if it has never been used. This is to make sure the irrelevant workflows doesn't need to set this ssl_mode field. See [PR](GoogleCloudPlatform#9396) for details. * fix: fix a lint error in resource_sql_database_instance_test.go
…d. (GoogleCloudPlatform#9428) * fix: do not store the ssl_mode field locally if it has never been used. This is to make sure the irrelevant workflows doesn't need to set this ssl_mode field. See [PR](GoogleCloudPlatform#9396) for details. * fix: fix a lint error in resource_sql_database_instance_test.go
…d. (GoogleCloudPlatform#9428) * fix: do not store the ssl_mode field locally if it has never been used. This is to make sure the irrelevant workflows doesn't need to set this ssl_mode field. See [PR](GoogleCloudPlatform#9396) for details. * fix: fix a lint error in resource_sql_database_instance_test.go
…d. (GoogleCloudPlatform#9428) * fix: do not store the ssl_mode field locally if it has never been used. This is to make sure the irrelevant workflows doesn't need to set this ssl_mode field. See [PR](GoogleCloudPlatform#9396) for details. * fix: fix a lint error in resource_sql_database_instance_test.go
This is to make sure the irrelevant workflows doesn't need to set this ssl_mode field. See
PR for details.
Release Note Template for Downstream PRs (will be copied)