fix: do not store the ssl_mode field locally if it has never been used.

[feng-zhe]

This is to make sure the irrelevant workflows doesn't need to set this ssl_mode field. See
PR for details.

Release Note Template for Downstream PRs (will be copied)

Do not store the ssl_mode field locally if it has never been used.

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 39 insertions(+), 17 deletions(-))
Terraform Beta: Diff ( 3 files changed, 39 insertions(+), 17 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3225
Passed tests 2897
Skipped tests: 328
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[SarahFrench]

👋 Hi there - there's currently a lint check failing on this PR, could you please fix it?

==> Checking that code complies with gofmt requirements...
gofmt needs running on the following files:
make: *** [GNUmakefile:26: fmtcheck] Error 1
./google-beta/services/sql/resource_sql_database_instance_test.go
You can use the command: `make fmt` to reformat code.

i.e. (mmv1/third_party/terraform/services/sql/resource_sql_database_instance_test.go)

Meanwhile, I'm going to trigger a non-VCR version of the acceptance test mentioned in this issue to run against this PR.

Edit: results here

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 35 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 3 files changed, 35 insertions(+), 13 deletions(-))

[feng-zhe]

👋 Hi there - there's currently a lint check failing on this PR, could you please fix it?

==> Checking that code complies with gofmt requirements...
gofmt needs running on the following files:
make: *** [GNUmakefile:26: fmtcheck] Error 1
./google-beta/services/sql/resource_sql_database_instance_test.go
You can use the command: `make fmt` to reformat code.

i.e. (mmv1/third_party/terraform/services/sql/resource_sql_database_instance_test.go)

Meanwhile, I'm going to trigger a non-VCR version of the acceptance test mentioned in this issue to run against this PR.

Edit: results here

Thanks, I have fixed the lint error and the failed tests passed.

[modular-magician]

Tests analytics

Total tests: 3225
Passed tests 2897
Skipped tests: 328
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[feng-zhe]

Hi @SarahFrench, thanks for reviewing this PR. I see all presubmit tests passed. Unfortunately I cannot login to the team city and see the test result you mentioned before. I see Authenticated successfully, but failed to create a new user since creating new users by "github.com" login is not allowed.

Are the tests passing? Thanks.

[SarahFrench]

Sorry for the delay, and that link to tests that I posted was for me/other reviewers to look at one the build had completed, so no worries about being unable to access it.

All of the sql acceptance tests except TestAccSqlUser_postgresIAM passed for this PR, and that test's failure isn't related to this PR. I can see that the TestAccSqlDatabaseInstance_basicMSSQL test (mentioned here) fails with the latest release of the provider but passes with the changes in this PR, so LGTM

[feng-zhe]

Thank you, SarahFrench!