fix: do not store the ssl_mode field locally if it has never been used. #16486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d. (hashicorp#9428) * fix: do not store the ssl_mode field locally if it has never been used. This is to make sure the irrelevant workflows doesn't need to set this ssl_mode field. See [PR](GoogleCloudPlatform/magic-modules#9396) for details. * fix: fix a lint error in resource_sql_database_instance_test.go [upstream:f729df4775ff38c7560141faf4fcdd488216556f] Signed-off-by: Modular Magician <magic-modules@google.com>
ScottSuarez
pushed a commit
that referenced
this pull request
Nov 10, 2023
…d. (#9428) (#16486) * fix: do not store the ssl_mode field locally if it has never been used. This is to make sure the irrelevant workflows doesn't need to set this ssl_mode field. See [PR](GoogleCloudPlatform/magic-modules#9396) for details. * fix: fix a lint error in resource_sql_database_instance_test.go [upstream:f729df4775ff38c7560141faf4fcdd488216556f] Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make sure the irrelevant workflows doesn't need to set this ssl_mode field. See
PR for details.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9428