Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make acctest use bootstrapped KMS key, instead of making new key that resembles a shared key #9926

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

SarahFrench
Copy link
Collaborator

@SarahFrench SarahFrench commented Feb 6, 2024

This acceptance test used to create new crypto keys and key rings that had names very similar to the shared KMS resources used in the test projects. The input tftest-shared-key-1 would be changed in the test to include the tf-test- prefix and a random string suffix though, so no errors were encountered about a resource with that name already existing.

I've updated this test to actually use the bootstrapped resource and to avoid creating undeletable KMS resources in the test project.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 5 insertions(+), 24 deletions(-))
Terraform Beta: Diff ( 2 files changed, 5 insertions(+), 24 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 11
Passed tests 10
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkbenchInstance_workbenchInstanceFullExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@SarahFrench SarahFrench marked this pull request as ready for review February 6, 2024 12:16
@SarahFrench SarahFrench merged commit ad957b2 into main Feb 6, 2024
13 checks passed
bcreddy-gcp pushed a commit to bcreddy-gcp/magic-modules that referenced this pull request Feb 7, 2024
slevenick pushed a commit that referenced this pull request Feb 13, 2024
* add labels to runtime update test

* Add desired_state for workbench instances

* fix(tgc): Fixing the if block for existingConverterAsset and add test case (#9914)

* Add sweepers for vertex_dataset, vertex_tensorboard and vertex_metadataStore (#9911)

* Make acctest use bootstrapped KMS key, instead of making new key that resembles a shared key (#9926)

* Refactor the TeamCity config to define all projects, across GA, Beta, and VCR testing (#9837)

* Replace contents of .teamcity/ with new refactored config files

* Remove remaining automation for generating service lists automatically

* Remove copyright headers, as they're added during generation process

* Update header comments on .teamcity files

* Make VCR testing compatible with TeamCity agent

* Update GA + Beta service lists to match the currrent provider

* Fix whitespace

* Update default TEST ENV value for VCR builds

* Add chmod commands to handling of creds file

* Update pre- and post-VCR steps to echo out more information about their actions

* Rename `generated` folder to `inputs`

* Update header comments on .teamcity files

* Refactor how VCR recording buid configurations are made

* Fix comment on MM VCR build

* Update VCR post step to fail if no cassettes are produced by the tests before

* Whitespace changes

* Fix how teamcity files are copied to the downstreams

* Change how VCR build configs are named

* remove newlines

* Fix defect in post VCR build steps

* Refactor labelling that indicates automated vs ad hoc builds

* Make VCR builds be triggered to indicate VCR_MODE

* Add first version of TeamCity documentation!

* Add contents section to PERFORMING_TASKS_IN_TEAMCITY.md

* Move details about DSL into technical README, away from process doc

* Make the .teamcity folder only propogate to the TPG repo, and no longer be in the TPGB repo

* Ensure all TeamCity files are being copied to the downstream repo

* Move echo command to after `BRANCH_NAME` ENV declared

* Update VCR steps to look for fixtures files inside beta folder

* Update mmv1/third_party/terraform/.teamcity/components/builds/vcr_build_steps.kt

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* Update mmv1/third_party/terraform/.teamcity/CONTRIBUTION_GUIDE.md

Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>

---------

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>

* [#15779] Add google_network_security_firewall_endpoint resource (#9813)

* [#15779] Add google_network_security_firewall_endpoint resource

* Fix yaml linting

* Removing unused fields from yaml

* Fixing tests

* Fixes per comments

---------

Co-authored-by: Luca Prete <lucaprete@google.com>

* enhancement: Allow overriding the Billing Project for google_cloud_asset_resources_search_all (#9935)

* enhancement: Allow overriding the Billing Project for cloud_asset_resources_search_all

* chore: Fixed indentation

* Add firebaseappcheck to service package lists (#9937)

* Enable CRONs in TeamCity (#9938)

* Set CRONs for 4am UTC

* Enable CRONs

* Update enrolled_teams.yml (#9939)

* add NickElliot to vacation reviewers (#9942)

* Update membership.go

* Update membership.go

* fix lint issues

* fix conversion compilation

* Remove Runtime example

* Add back kms flatten

* change encryption to CMEK to test for KMS

* Try using a global KMS key

* kms key location to us-central1

* remove service account in full example

* Adding back service account into full test

---------

Co-authored-by: Iris Chen <10179943+iyabchen@users.noreply.github.com>
Co-authored-by: hao-nan-li <100219545+hao-nan-li@users.noreply.github.com>
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
Co-authored-by: Luca Prete <preteluca@gmail.com>
Co-authored-by: Luca Prete <lucaprete@google.com>
Co-authored-by: Koen van Zuijlen <8818390+kvanzuijlen@users.noreply.github.com>
Co-authored-by: Ryan Oaks <ryanoaks@google.com>
Co-authored-by: Nick Elliot <nickelliot@google.com>
tdbhacks pushed a commit to tdbhacks/magic-modules that referenced this pull request Feb 23, 2024
tdbhacks pushed a commit to tdbhacks/magic-modules that referenced this pull request Feb 23, 2024
* add labels to runtime update test

* Add desired_state for workbench instances

* fix(tgc): Fixing the if block for existingConverterAsset and add test case (GoogleCloudPlatform#9914)

* Add sweepers for vertex_dataset, vertex_tensorboard and vertex_metadataStore (GoogleCloudPlatform#9911)

* Make acctest use bootstrapped KMS key, instead of making new key that resembles a shared key (GoogleCloudPlatform#9926)

* Refactor the TeamCity config to define all projects, across GA, Beta, and VCR testing (GoogleCloudPlatform#9837)

* Replace contents of .teamcity/ with new refactored config files

* Remove remaining automation for generating service lists automatically

* Remove copyright headers, as they're added during generation process

* Update header comments on .teamcity files

* Make VCR testing compatible with TeamCity agent

* Update GA + Beta service lists to match the currrent provider

* Fix whitespace

* Update default TEST ENV value for VCR builds

* Add chmod commands to handling of creds file

* Update pre- and post-VCR steps to echo out more information about their actions

* Rename `generated` folder to `inputs`

* Update header comments on .teamcity files

* Refactor how VCR recording buid configurations are made

* Fix comment on MM VCR build

* Update VCR post step to fail if no cassettes are produced by the tests before

* Whitespace changes

* Fix how teamcity files are copied to the downstreams

* Change how VCR build configs are named

* remove newlines

* Fix defect in post VCR build steps

* Refactor labelling that indicates automated vs ad hoc builds

* Make VCR builds be triggered to indicate VCR_MODE

* Add first version of TeamCity documentation!

* Add contents section to PERFORMING_TASKS_IN_TEAMCITY.md

* Move details about DSL into technical README, away from process doc

* Make the .teamcity folder only propogate to the TPG repo, and no longer be in the TPGB repo

* Ensure all TeamCity files are being copied to the downstream repo

* Move echo command to after `BRANCH_NAME` ENV declared

* Update VCR steps to look for fixtures files inside beta folder

* Update mmv1/third_party/terraform/.teamcity/components/builds/vcr_build_steps.kt

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* Update mmv1/third_party/terraform/.teamcity/CONTRIBUTION_GUIDE.md

Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>

---------

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>

* [#15779] Add google_network_security_firewall_endpoint resource (GoogleCloudPlatform#9813)

* [#15779] Add google_network_security_firewall_endpoint resource

* Fix yaml linting

* Removing unused fields from yaml

* Fixing tests

* Fixes per comments

---------

Co-authored-by: Luca Prete <lucaprete@google.com>

* enhancement: Allow overriding the Billing Project for google_cloud_asset_resources_search_all (GoogleCloudPlatform#9935)

* enhancement: Allow overriding the Billing Project for cloud_asset_resources_search_all

* chore: Fixed indentation

* Add firebaseappcheck to service package lists (GoogleCloudPlatform#9937)

* Enable CRONs in TeamCity (GoogleCloudPlatform#9938)

* Set CRONs for 4am UTC

* Enable CRONs

* Update enrolled_teams.yml (GoogleCloudPlatform#9939)

* add NickElliot to vacation reviewers (GoogleCloudPlatform#9942)

* Update membership.go

* Update membership.go

* fix lint issues

* fix conversion compilation

* Remove Runtime example

* Add back kms flatten

* change encryption to CMEK to test for KMS

* Try using a global KMS key

* kms key location to us-central1

* remove service account in full example

* Adding back service account into full test

---------

Co-authored-by: Iris Chen <10179943+iyabchen@users.noreply.github.com>
Co-authored-by: hao-nan-li <100219545+hao-nan-li@users.noreply.github.com>
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
Co-authored-by: Luca Prete <preteluca@gmail.com>
Co-authored-by: Luca Prete <lucaprete@google.com>
Co-authored-by: Koen van Zuijlen <8818390+kvanzuijlen@users.noreply.github.com>
Co-authored-by: Ryan Oaks <ryanoaks@google.com>
Co-authored-by: Nick Elliot <nickelliot@google.com>
@SarahFrench SarahFrench deleted the workbench-kms-key-refactor branch March 19, 2024 22:00
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
* add labels to runtime update test

* Add desired_state for workbench instances

* fix(tgc): Fixing the if block for existingConverterAsset and add test case (GoogleCloudPlatform#9914)

* Add sweepers for vertex_dataset, vertex_tensorboard and vertex_metadataStore (GoogleCloudPlatform#9911)

* Make acctest use bootstrapped KMS key, instead of making new key that resembles a shared key (GoogleCloudPlatform#9926)

* Refactor the TeamCity config to define all projects, across GA, Beta, and VCR testing (GoogleCloudPlatform#9837)

* Replace contents of .teamcity/ with new refactored config files

* Remove remaining automation for generating service lists automatically

* Remove copyright headers, as they're added during generation process

* Update header comments on .teamcity files

* Make VCR testing compatible with TeamCity agent

* Update GA + Beta service lists to match the currrent provider

* Fix whitespace

* Update default TEST ENV value for VCR builds

* Add chmod commands to handling of creds file

* Update pre- and post-VCR steps to echo out more information about their actions

* Rename `generated` folder to `inputs`

* Update header comments on .teamcity files

* Refactor how VCR recording buid configurations are made

* Fix comment on MM VCR build

* Update VCR post step to fail if no cassettes are produced by the tests before

* Whitespace changes

* Fix how teamcity files are copied to the downstreams

* Change how VCR build configs are named

* remove newlines

* Fix defect in post VCR build steps

* Refactor labelling that indicates automated vs ad hoc builds

* Make VCR builds be triggered to indicate VCR_MODE

* Add first version of TeamCity documentation!

* Add contents section to PERFORMING_TASKS_IN_TEAMCITY.md

* Move details about DSL into technical README, away from process doc

* Make the .teamcity folder only propogate to the TPG repo, and no longer be in the TPGB repo

* Ensure all TeamCity files are being copied to the downstream repo

* Move echo command to after `BRANCH_NAME` ENV declared

* Update VCR steps to look for fixtures files inside beta folder

* Update mmv1/third_party/terraform/.teamcity/components/builds/vcr_build_steps.kt

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* Update mmv1/third_party/terraform/.teamcity/CONTRIBUTION_GUIDE.md

Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>

---------

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>

* [#15779] Add google_network_security_firewall_endpoint resource (GoogleCloudPlatform#9813)

* [#15779] Add google_network_security_firewall_endpoint resource

* Fix yaml linting

* Removing unused fields from yaml

* Fixing tests

* Fixes per comments

---------

Co-authored-by: Luca Prete <lucaprete@google.com>

* enhancement: Allow overriding the Billing Project for google_cloud_asset_resources_search_all (GoogleCloudPlatform#9935)

* enhancement: Allow overriding the Billing Project for cloud_asset_resources_search_all

* chore: Fixed indentation

* Add firebaseappcheck to service package lists (GoogleCloudPlatform#9937)

* Enable CRONs in TeamCity (GoogleCloudPlatform#9938)

* Set CRONs for 4am UTC

* Enable CRONs

* Update enrolled_teams.yml (GoogleCloudPlatform#9939)

* add NickElliot to vacation reviewers (GoogleCloudPlatform#9942)

* Update membership.go

* Update membership.go

* fix lint issues

* fix conversion compilation

* Remove Runtime example

* Add back kms flatten

* change encryption to CMEK to test for KMS

* Try using a global KMS key

* kms key location to us-central1

* remove service account in full example

* Adding back service account into full test

---------

Co-authored-by: Iris Chen <10179943+iyabchen@users.noreply.github.com>
Co-authored-by: hao-nan-li <100219545+hao-nan-li@users.noreply.github.com>
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
Co-authored-by: Luca Prete <preteluca@gmail.com>
Co-authored-by: Luca Prete <lucaprete@google.com>
Co-authored-by: Koen van Zuijlen <8818390+kvanzuijlen@users.noreply.github.com>
Co-authored-by: Ryan Oaks <ryanoaks@google.com>
Co-authored-by: Nick Elliot <nickelliot@google.com>
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
* add labels to runtime update test

* Add desired_state for workbench instances

* fix(tgc): Fixing the if block for existingConverterAsset and add test case (GoogleCloudPlatform#9914)

* Add sweepers for vertex_dataset, vertex_tensorboard and vertex_metadataStore (GoogleCloudPlatform#9911)

* Make acctest use bootstrapped KMS key, instead of making new key that resembles a shared key (GoogleCloudPlatform#9926)

* Refactor the TeamCity config to define all projects, across GA, Beta, and VCR testing (GoogleCloudPlatform#9837)

* Replace contents of .teamcity/ with new refactored config files

* Remove remaining automation for generating service lists automatically

* Remove copyright headers, as they're added during generation process

* Update header comments on .teamcity files

* Make VCR testing compatible with TeamCity agent

* Update GA + Beta service lists to match the currrent provider

* Fix whitespace

* Update default TEST ENV value for VCR builds

* Add chmod commands to handling of creds file

* Update pre- and post-VCR steps to echo out more information about their actions

* Rename `generated` folder to `inputs`

* Update header comments on .teamcity files

* Refactor how VCR recording buid configurations are made

* Fix comment on MM VCR build

* Update VCR post step to fail if no cassettes are produced by the tests before

* Whitespace changes

* Fix how teamcity files are copied to the downstreams

* Change how VCR build configs are named

* remove newlines

* Fix defect in post VCR build steps

* Refactor labelling that indicates automated vs ad hoc builds

* Make VCR builds be triggered to indicate VCR_MODE

* Add first version of TeamCity documentation!

* Add contents section to PERFORMING_TASKS_IN_TEAMCITY.md

* Move details about DSL into technical README, away from process doc

* Make the .teamcity folder only propogate to the TPG repo, and no longer be in the TPGB repo

* Ensure all TeamCity files are being copied to the downstream repo

* Move echo command to after `BRANCH_NAME` ENV declared

* Update VCR steps to look for fixtures files inside beta folder

* Update mmv1/third_party/terraform/.teamcity/components/builds/vcr_build_steps.kt

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* Update mmv1/third_party/terraform/.teamcity/CONTRIBUTION_GUIDE.md

Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>

---------

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>

* [#15779] Add google_network_security_firewall_endpoint resource (GoogleCloudPlatform#9813)

* [#15779] Add google_network_security_firewall_endpoint resource

* Fix yaml linting

* Removing unused fields from yaml

* Fixing tests

* Fixes per comments

---------

Co-authored-by: Luca Prete <lucaprete@google.com>

* enhancement: Allow overriding the Billing Project for google_cloud_asset_resources_search_all (GoogleCloudPlatform#9935)

* enhancement: Allow overriding the Billing Project for cloud_asset_resources_search_all

* chore: Fixed indentation

* Add firebaseappcheck to service package lists (GoogleCloudPlatform#9937)

* Enable CRONs in TeamCity (GoogleCloudPlatform#9938)

* Set CRONs for 4am UTC

* Enable CRONs

* Update enrolled_teams.yml (GoogleCloudPlatform#9939)

* add NickElliot to vacation reviewers (GoogleCloudPlatform#9942)

* Update membership.go

* Update membership.go

* fix lint issues

* fix conversion compilation

* Remove Runtime example

* Add back kms flatten

* change encryption to CMEK to test for KMS

* Try using a global KMS key

* kms key location to us-central1

* remove service account in full example

* Adding back service account into full test

---------

Co-authored-by: Iris Chen <10179943+iyabchen@users.noreply.github.com>
Co-authored-by: hao-nan-li <100219545+hao-nan-li@users.noreply.github.com>
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
Co-authored-by: Luca Prete <preteluca@gmail.com>
Co-authored-by: Luca Prete <lucaprete@google.com>
Co-authored-by: Koen van Zuijlen <8818390+kvanzuijlen@users.noreply.github.com>
Co-authored-by: Ryan Oaks <ryanoaks@google.com>
Co-authored-by: Nick Elliot <nickelliot@google.com>
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
* add labels to runtime update test

* Add desired_state for workbench instances

* fix(tgc): Fixing the if block for existingConverterAsset and add test case (GoogleCloudPlatform#9914)

* Add sweepers for vertex_dataset, vertex_tensorboard and vertex_metadataStore (GoogleCloudPlatform#9911)

* Make acctest use bootstrapped KMS key, instead of making new key that resembles a shared key (GoogleCloudPlatform#9926)

* Refactor the TeamCity config to define all projects, across GA, Beta, and VCR testing (GoogleCloudPlatform#9837)

* Replace contents of .teamcity/ with new refactored config files

* Remove remaining automation for generating service lists automatically

* Remove copyright headers, as they're added during generation process

* Update header comments on .teamcity files

* Make VCR testing compatible with TeamCity agent

* Update GA + Beta service lists to match the currrent provider

* Fix whitespace

* Update default TEST ENV value for VCR builds

* Add chmod commands to handling of creds file

* Update pre- and post-VCR steps to echo out more information about their actions

* Rename `generated` folder to `inputs`

* Update header comments on .teamcity files

* Refactor how VCR recording buid configurations are made

* Fix comment on MM VCR build

* Update VCR post step to fail if no cassettes are produced by the tests before

* Whitespace changes

* Fix how teamcity files are copied to the downstreams

* Change how VCR build configs are named

* remove newlines

* Fix defect in post VCR build steps

* Refactor labelling that indicates automated vs ad hoc builds

* Make VCR builds be triggered to indicate VCR_MODE

* Add first version of TeamCity documentation!

* Add contents section to PERFORMING_TASKS_IN_TEAMCITY.md

* Move details about DSL into technical README, away from process doc

* Make the .teamcity folder only propogate to the TPG repo, and no longer be in the TPGB repo

* Ensure all TeamCity files are being copied to the downstream repo

* Move echo command to after `BRANCH_NAME` ENV declared

* Update VCR steps to look for fixtures files inside beta folder

* Update mmv1/third_party/terraform/.teamcity/components/builds/vcr_build_steps.kt

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* Update mmv1/third_party/terraform/.teamcity/CONTRIBUTION_GUIDE.md

Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>

---------

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>

* [#15779] Add google_network_security_firewall_endpoint resource (GoogleCloudPlatform#9813)

* [#15779] Add google_network_security_firewall_endpoint resource

* Fix yaml linting

* Removing unused fields from yaml

* Fixing tests

* Fixes per comments

---------

Co-authored-by: Luca Prete <lucaprete@google.com>

* enhancement: Allow overriding the Billing Project for google_cloud_asset_resources_search_all (GoogleCloudPlatform#9935)

* enhancement: Allow overriding the Billing Project for cloud_asset_resources_search_all

* chore: Fixed indentation

* Add firebaseappcheck to service package lists (GoogleCloudPlatform#9937)

* Enable CRONs in TeamCity (GoogleCloudPlatform#9938)

* Set CRONs for 4am UTC

* Enable CRONs

* Update enrolled_teams.yml (GoogleCloudPlatform#9939)

* add NickElliot to vacation reviewers (GoogleCloudPlatform#9942)

* Update membership.go

* Update membership.go

* fix lint issues

* fix conversion compilation

* Remove Runtime example

* Add back kms flatten

* change encryption to CMEK to test for KMS

* Try using a global KMS key

* kms key location to us-central1

* remove service account in full example

* Adding back service account into full test

---------

Co-authored-by: Iris Chen <10179943+iyabchen@users.noreply.github.com>
Co-authored-by: hao-nan-li <100219545+hao-nan-li@users.noreply.github.com>
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
Co-authored-by: Luca Prete <preteluca@gmail.com>
Co-authored-by: Luca Prete <lucaprete@google.com>
Co-authored-by: Koen van Zuijlen <8818390+kvanzuijlen@users.noreply.github.com>
Co-authored-by: Ryan Oaks <ryanoaks@google.com>
Co-authored-by: Nick Elliot <nickelliot@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants