Add desired state to workbench instances. #9945

bcreddy-gcp · 2024-02-07T23:02:50Z

Release Note Template for Downstream PRs (will be copied)

workbench: added `desired_state` field to `google_workbench_instance` resource

… case (GoogleCloudPlatform#9914)

…taStore (GoogleCloudPlatform#9911)

… resembles a shared key (GoogleCloudPlatform#9926)

… and VCR testing (GoogleCloudPlatform#9837) * Replace contents of .teamcity/ with new refactored config files * Remove remaining automation for generating service lists automatically * Remove copyright headers, as they're added during generation process * Update header comments on .teamcity files * Make VCR testing compatible with TeamCity agent * Update GA + Beta service lists to match the currrent provider * Fix whitespace * Update default TEST ENV value for VCR builds * Add chmod commands to handling of creds file * Update pre- and post-VCR steps to echo out more information about their actions * Rename `generated` folder to `inputs` * Update header comments on .teamcity files * Refactor how VCR recording buid configurations are made * Fix comment on MM VCR build * Update VCR post step to fail if no cassettes are produced by the tests before * Whitespace changes * Fix how teamcity files are copied to the downstreams * Change how VCR build configs are named * remove newlines * Fix defect in post VCR build steps * Refactor labelling that indicates automated vs ad hoc builds * Make VCR builds be triggered to indicate VCR_MODE * Add first version of TeamCity documentation! * Add contents section to PERFORMING_TASKS_IN_TEAMCITY.md * Move details about DSL into technical README, away from process doc * Make the .teamcity folder only propogate to the TPG repo, and no longer be in the TPGB repo * Ensure all TeamCity files are being copied to the downstream repo * Move echo command to after `BRANCH_NAME` ENV declared * Update VCR steps to look for fixtures files inside beta folder * Update mmv1/third_party/terraform/.teamcity/components/builds/vcr_build_steps.kt Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> * Update mmv1/third_party/terraform/.teamcity/CONTRIBUTION_GUIDE.md Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com> --------- Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>

…leCloudPlatform#9813) * [#15779] Add google_network_security_firewall_endpoint resource * Fix yaml linting * Removing unused fields from yaml * Fixing tests * Fixes per comments --------- Co-authored-by: Luca Prete <lucaprete@google.com>

…set_resources_search_all (GoogleCloudPlatform#9935) * enhancement: Allow overriding the Billing Project for cloud_asset_resources_search_all * chore: Fixed indentation

* Set CRONs for 4am UTC * Enable CRONs

* Update membership.go * Update membership.go

modular-magician · 2024-02-07T23:04:21Z

Hello! I am a robot. It looks like you are a: ~~Community Contributor~~ Googler ~~Core Contributor~~. Tests will run automatically.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2024-02-07T23:19:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 166 insertions(+), 67 deletions(-))
Terraform Beta: Diff ( 5 files changed, 166 insertions(+), 67 deletions(-))
TF Conversion: Diff ( 1 file changed, 38 insertions(+))

modular-magician · 2024-02-07T23:28:53Z

Tests analytics

Total tests: 34
Passed tests 27
Skipped tests: 0
Affected tests: 7

Click here to see the affected service packages

workbench
notebooks

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkbenchInstance_workbenchInstanceLabelsStoppedExample|TestAccWorkbenchInstance_updateState|TestAccWorkbenchInstance_workbenchInstanceFullExample|TestAccWorkbenchInstance_removeGpu|TestAccWorkbenchInstance_updateGpu|TestAccWorkbenchInstance_update|TestAccNotebooksRuntime_update

Get to know how VCR tests work

modular-magician · 2024-02-07T23:44:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 166 insertions(+), 67 deletions(-))
Terraform Beta: Diff ( 5 files changed, 166 insertions(+), 67 deletions(-))
TF Conversion: Diff ( 1 file changed, 27 insertions(+))

modular-magician · 2024-02-07T23:53:45Z

Tests analytics

Total tests: 34
Passed tests 27
Skipped tests: 0
Affected tests: 7

Click here to see the affected service packages

workbench
notebooks

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkbenchInstance_updateState|TestAccWorkbenchInstance_workbenchInstanceLabelsStoppedExample|TestAccWorkbenchInstance_workbenchInstanceFullExample|TestAccWorkbenchInstance_removeGpu|TestAccWorkbenchInstance_updateGpu|TestAccWorkbenchInstance_update|TestAccNotebooksRuntime_update

Get to know how VCR tests work

modular-magician · 2024-02-08T00:09:27Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkbenchInstance_workbenchInstanceLabelsStoppedExample[Debug log]
TestAccWorkbenchInstance_removeGpu[Debug log]
TestAccWorkbenchInstance_updateGpu[Debug log]
TestAccWorkbenchInstance_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkbenchInstance_updateState[Error message] [Debug log]
TestAccWorkbenchInstance_workbenchInstanceFullExample[Error message] [Debug log]
TestAccNotebooksRuntime_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2024-02-08T00:24:42Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 163 insertions(+), 67 deletions(-))
Terraform Beta: Diff ( 4 files changed, 163 insertions(+), 67 deletions(-))
TF Conversion: Diff ( 1 file changed, 27 insertions(+))

modular-magician · 2024-02-08T00:28:56Z

Tests analytics

Total tests: 12
Passed tests 10
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

workbench

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkbenchInstance_updateState|TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

modular-magician · 2024-02-08T00:33:11Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkbenchInstance_updateState[Error message] [Debug log]
TestAccWorkbenchInstance_workbenchInstanceFullExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2024-02-08T01:53:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 160 insertions(+), 64 deletions(-))
Terraform Beta: Diff ( 4 files changed, 160 insertions(+), 64 deletions(-))
TF Conversion: Diff ( 1 file changed, 27 insertions(+))

modular-magician · 2024-02-08T01:58:33Z

Tests analytics

Total tests: 12
Passed tests 10
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

workbench

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkbenchInstance_updateState|TestAccWorkbenchInstance_workbenchInstanceLabelsStoppedExample

Get to know how VCR tests work

ScottSuarez · 2024-02-09T00:19:45Z

/gcbrun

modular-magician · 2024-02-09T00:30:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 176 insertions(+), 80 deletions(-))
Terraform Beta: Diff ( 4 files changed, 176 insertions(+), 80 deletions(-))
TF Conversion: Diff ( 1 file changed, 27 insertions(+))
TF OiCS: Diff ( 4 files changed, 113 deletions(-))

modular-magician · 2024-02-09T00:36:09Z

Tests analytics

Total tests: 12
Passed tests 11
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

modular-magician · 2024-02-09T00:38:03Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkbenchInstance_workbenchInstanceFullExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

ScottSuarez · 2024-02-09T04:52:05Z

/gcbrun

modular-magician · 2024-02-09T05:02:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 176 insertions(+), 80 deletions(-))
Terraform Beta: Diff ( 4 files changed, 176 insertions(+), 80 deletions(-))
TF Conversion: Diff ( 1 file changed, 27 insertions(+))
TF OiCS: Diff ( 4 files changed, 113 deletions(-))

modular-magician · 2024-02-09T05:07:38Z

Tests analytics

Total tests: 12
Passed tests 11
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

modular-magician · 2024-02-09T05:15:21Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkbenchInstance_workbenchInstanceFullExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

bcreddy-gcp · 2024-02-12T20:53:42Z

@ScottSuarez, Could you update the IAM roles on the service account specified in full test that were required for the test to pass?
Could you test/review the PR when you get a chance @slevenick. It'd be great to have this change in the immediate release if possible.

slevenick · 2024-02-12T21:16:34Z

/gcbrun

modular-magician · 2024-02-12T21:29:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 167 insertions(+), 71 deletions(-))
Terraform Beta: Diff ( 4 files changed, 167 insertions(+), 71 deletions(-))
TF Conversion: Diff ( 1 file changed, 27 insertions(+))

modular-magician · 2024-02-12T21:35:24Z

Tests analytics

Total tests: 12
Passed tests 11
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

modular-magician · 2024-02-12T21:43:31Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkbenchInstance_workbenchInstanceFullExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

mmv1/templates/terraform/post_update/workbench_instance.go.erb

mmv1/templates/terraform/post_create/workbench_instance.go.erb

slevenick · 2024-02-13T19:29:51Z

Can you add a release note for this in the original PR description?

bcreddy-gcp · 2024-02-13T20:33:22Z

Added the release note.

* add labels to runtime update test * Add desired_state for workbench instances * fix(tgc): Fixing the if block for existingConverterAsset and add test case (GoogleCloudPlatform#9914) * Add sweepers for vertex_dataset, vertex_tensorboard and vertex_metadataStore (GoogleCloudPlatform#9911) * Make acctest use bootstrapped KMS key, instead of making new key that resembles a shared key (GoogleCloudPlatform#9926) * Refactor the TeamCity config to define all projects, across GA, Beta, and VCR testing (GoogleCloudPlatform#9837) * Replace contents of .teamcity/ with new refactored config files * Remove remaining automation for generating service lists automatically * Remove copyright headers, as they're added during generation process * Update header comments on .teamcity files * Make VCR testing compatible with TeamCity agent * Update GA + Beta service lists to match the currrent provider * Fix whitespace * Update default TEST ENV value for VCR builds * Add chmod commands to handling of creds file * Update pre- and post-VCR steps to echo out more information about their actions * Rename `generated` folder to `inputs` * Update header comments on .teamcity files * Refactor how VCR recording buid configurations are made * Fix comment on MM VCR build * Update VCR post step to fail if no cassettes are produced by the tests before * Whitespace changes * Fix how teamcity files are copied to the downstreams * Change how VCR build configs are named * remove newlines * Fix defect in post VCR build steps * Refactor labelling that indicates automated vs ad hoc builds * Make VCR builds be triggered to indicate VCR_MODE * Add first version of TeamCity documentation! * Add contents section to PERFORMING_TASKS_IN_TEAMCITY.md * Move details about DSL into technical README, away from process doc * Make the .teamcity folder only propogate to the TPG repo, and no longer be in the TPGB repo * Ensure all TeamCity files are being copied to the downstream repo * Move echo command to after `BRANCH_NAME` ENV declared * Update VCR steps to look for fixtures files inside beta folder * Update mmv1/third_party/terraform/.teamcity/components/builds/vcr_build_steps.kt Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> * Update mmv1/third_party/terraform/.teamcity/CONTRIBUTION_GUIDE.md Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com> --------- Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com> * [#15779] Add google_network_security_firewall_endpoint resource (GoogleCloudPlatform#9813) * [#15779] Add google_network_security_firewall_endpoint resource * Fix yaml linting * Removing unused fields from yaml * Fixing tests * Fixes per comments --------- Co-authored-by: Luca Prete <lucaprete@google.com> * enhancement: Allow overriding the Billing Project for google_cloud_asset_resources_search_all (GoogleCloudPlatform#9935) * enhancement: Allow overriding the Billing Project for cloud_asset_resources_search_all * chore: Fixed indentation * Add firebaseappcheck to service package lists (GoogleCloudPlatform#9937) * Enable CRONs in TeamCity (GoogleCloudPlatform#9938) * Set CRONs for 4am UTC * Enable CRONs * Update enrolled_teams.yml (GoogleCloudPlatform#9939) * add NickElliot to vacation reviewers (GoogleCloudPlatform#9942) * Update membership.go * Update membership.go * fix lint issues * fix conversion compilation * Remove Runtime example * Add back kms flatten * change encryption to CMEK to test for KMS * Try using a global KMS key * kms key location to us-central1 * remove service account in full example * Adding back service account into full test --------- Co-authored-by: Iris Chen <10179943+iyabchen@users.noreply.github.com> Co-authored-by: hao-nan-li <100219545+hao-nan-li@users.noreply.github.com> Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com> Co-authored-by: Luca Prete <preteluca@gmail.com> Co-authored-by: Luca Prete <lucaprete@google.com> Co-authored-by: Koen van Zuijlen <8818390+kvanzuijlen@users.noreply.github.com> Co-authored-by: Ryan Oaks <ryanoaks@google.com> Co-authored-by: Nick Elliot <nickelliot@google.com>

bcreddy-gcp and others added 13 commits February 6, 2024 21:40

add labels to runtime update test

4316664

Add desired_state for workbench instances

42f7456

fix(tgc): Fixing the if block for existingConverterAsset and add test…

e70da44

… case (GoogleCloudPlatform#9914)

Add sweepers for vertex_dataset, vertex_tensorboard and vertex_metada…

c12420f

…taStore (GoogleCloudPlatform#9911)

Make acctest use bootstrapped KMS key, instead of making new key that…

d14c2c1

… resembles a shared key (GoogleCloudPlatform#9926)

enhancement: Allow overriding the Billing Project for google_cloud_as…

e649c74

…set_resources_search_all (GoogleCloudPlatform#9935) * enhancement: Allow overriding the Billing Project for cloud_asset_resources_search_all * chore: Fixed indentation

Add firebaseappcheck to service package lists (GoogleCloudPlatform#9937)

0fa9ba0

Enable CRONs in TeamCity (GoogleCloudPlatform#9938)

fd2c89c

* Set CRONs for 4am UTC * Enable CRONs

Update enrolled_teams.yml (GoogleCloudPlatform#9939)

46c3db2

add NickElliot to vacation reviewers (GoogleCloudPlatform#9942)

d86f07e

* Update membership.go * Update membership.go

Merge branch 'GoogleCloudPlatform:main' into wbi_state

496c3dc

modular-magician requested a review from SarahFrench February 7, 2024 23:04

fix lint issues

de6e551

modular-magician added the service/notebooks label Feb 7, 2024

fix conversion compilation

064a854

Remove Runtime example

bed1a7c

Add back kms flatten

6d2d4de

SarahFrench removed their request for review February 9, 2024 14:03

Adding back service account into full test

3dacd43

bcreddy-gcp mentioned this pull request Feb 12, 2024

Make notebooks wait for active state and enable stopping/starting ins… #9971

Merged

slevenick reviewed Feb 13, 2024

View reviewed changes

mmv1/templates/terraform/post_update/workbench_instance.go.erb Show resolved Hide resolved

bcreddy-gcp commented Feb 13, 2024

View reviewed changes

mmv1/templates/terraform/post_create/workbench_instance.go.erb Show resolved Hide resolved

slevenick approved these changes Feb 13, 2024

View reviewed changes

slevenick merged commit 1d3073d into GoogleCloudPlatform:main Feb 13, 2024
15 checks passed

bcreddy-gcp deleted the wbi_state branch February 13, 2024 21:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add desired state to workbench instances. #9945

Add desired state to workbench instances. #9945

bcreddy-gcp commented Feb 7, 2024 •

edited by slevenick

Loading

modular-magician commented Feb 7, 2024

modular-magician commented Feb 7, 2024

modular-magician commented Feb 7, 2024

modular-magician commented Feb 7, 2024

modular-magician commented Feb 7, 2024

modular-magician commented Feb 8, 2024

modular-magician commented Feb 8, 2024

modular-magician commented Feb 8, 2024

modular-magician commented Feb 8, 2024

modular-magician commented Feb 8, 2024

modular-magician commented Feb 8, 2024

ScottSuarez commented Feb 9, 2024

modular-magician commented Feb 9, 2024

modular-magician commented Feb 9, 2024

modular-magician commented Feb 9, 2024

ScottSuarez commented Feb 9, 2024

modular-magician commented Feb 9, 2024

modular-magician commented Feb 9, 2024

modular-magician commented Feb 9, 2024

bcreddy-gcp commented Feb 12, 2024

slevenick commented Feb 12, 2024

modular-magician commented Feb 12, 2024

modular-magician commented Feb 12, 2024

modular-magician commented Feb 12, 2024

slevenick commented Feb 13, 2024

bcreddy-gcp commented Feb 13, 2024

Add desired state to workbench instances. #9945

Add desired state to workbench instances. #9945

Conversation

bcreddy-gcp commented Feb 7, 2024 • edited by slevenick Loading

modular-magician commented Feb 7, 2024

modular-magician commented Feb 7, 2024

Diff report

modular-magician commented Feb 7, 2024

Tests analytics

Action taken

modular-magician commented Feb 7, 2024

Diff report

modular-magician commented Feb 7, 2024

Tests analytics

Action taken

modular-magician commented Feb 8, 2024

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Feb 8, 2024

Diff report

modular-magician commented Feb 8, 2024

Tests analytics

Action taken

modular-magician commented Feb 8, 2024

modular-magician commented Feb 8, 2024

Diff report

modular-magician commented Feb 8, 2024

Tests analytics

Action taken

ScottSuarez commented Feb 9, 2024

modular-magician commented Feb 9, 2024

Diff report

modular-magician commented Feb 9, 2024

Tests analytics

Action taken

modular-magician commented Feb 9, 2024

ScottSuarez commented Feb 9, 2024

modular-magician commented Feb 9, 2024

Diff report

modular-magician commented Feb 9, 2024

Tests analytics

Action taken

modular-magician commented Feb 9, 2024

Rerun these tests in REPLAYING mode to catch issues

bcreddy-gcp commented Feb 12, 2024

slevenick commented Feb 12, 2024

modular-magician commented Feb 12, 2024

Diff report

modular-magician commented Feb 12, 2024

Tests analytics

Action taken

modular-magician commented Feb 12, 2024

Rerun these tests in REPLAYING mode to catch issues

slevenick commented Feb 13, 2024

bcreddy-gcp commented Feb 13, 2024

bcreddy-gcp commented Feb 7, 2024 •

edited by slevenick

Loading