-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package.json of our samples are polluted by our maintenance tools #693
Comments
Because they contain more that what is actually needed and JSON does not support comments, the package.json cannot be embedded in our documentation without confusing users. |
I think we're getting rid of I don't think there's a good solution to making samples short - but also self contained and on the CI 😞 |
So yeah, As far as others are concerned - I disagree! Things like |
A lot of samples rely on this test setup:
If we remove the |
Closing this, I think our |
🤖 I have created a release *beep* *boop* --- ## [3.4.0](googleapis/nodejs-dlp@v3.3.0...v3.4.0) (2022-03-25) ### Features * new Bytes and File types: POWERPOINT and EXCEL ([#693](googleapis/nodejs-dlp#693)) ([ed3dc42](googleapis/nodejs-dlp@ed3dc42)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Take a look at this example: https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/master/appengine/hello-world/standard/package.json
cloud-repo-tools
,devDependencies
and most of thescripts
do not serve the purpose of giving example code to our users, instead, they are data used by our maintenance tools.Could they be in a different file that does not interfere with
package.json
?The text was updated successfully, but these errors were encountered: