Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

just adding ':' for log consistency #694

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

congr
Copy link
Contributor

@congr congr commented Jul 23, 2018

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 23, 2018
@congr congr changed the title just adding : for log consistency just adding ':' for log consistency Jul 23, 2018
@codecov
Copy link

codecov bot commented Jul 23, 2018

Codecov Report

Merging #694 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #694   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed0db75...31cae9c. Read the comment docs.

@congr
Copy link
Contributor Author

congr commented Jul 23, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 23, 2018
@JustinBeckwith JustinBeckwith merged commit 1845478 into GoogleCloudPlatform:master Jul 23, 2018
ace-n pushed a commit that referenced this pull request Jul 23, 2018
* Update index.js

* Clarify mocking comments (#682)

* fix: just adding : for log consistency (#694)

* Update index.js

* Update index.js

* Update index.js

* Fix test
ace-n pushed a commit that referenced this pull request Nov 14, 2022
ace-n pushed a commit that referenced this pull request Nov 17, 2022
* translate document sample and test

Change-Id: Id0f943163f063e114aaec5703f3160a5b9c71485

* remove comment

Change-Id: I13ee4f8692c76416564d05485271a50929ff42cf

* lint

Change-Id: I3eb785d6a164748484726ad359a8ae7f8156051d

* batch translate document

Change-Id: Id36d46f363cb061c38ddf099e23836020757b9f2

* batch translate document

Change-Id: Ifbf6c3faec2352237f44d714c31360349b950efb

* update year

Change-Id: Icb80b2a660ee38de5cbbd09e497eeaf4d3532371

* refactor error handling

Change-Id: Ic7493f025e1c98b3c4e0dbc6a48919e8a2df309e

* refactor error handling

Change-Id: Ibe57fa98dbb060039d8b60684238294f3f4746f1
ace-n pushed a commit that referenced this pull request Nov 17, 2022
* translate document sample and test

Change-Id: Id0f943163f063e114aaec5703f3160a5b9c71485

* remove comment

Change-Id: I13ee4f8692c76416564d05485271a50929ff42cf

* lint

Change-Id: I3eb785d6a164748484726ad359a8ae7f8156051d

* batch translate document

Change-Id: Id36d46f363cb061c38ddf099e23836020757b9f2

* batch translate document

Change-Id: Ifbf6c3faec2352237f44d714c31360349b950efb

* update year

Change-Id: Icb80b2a660ee38de5cbbd09e497eeaf4d3532371

* refactor error handling

Change-Id: Ic7493f025e1c98b3c4e0dbc6a48919e8a2df309e

* refactor error handling

Change-Id: Ibe57fa98dbb060039d8b60684238294f3f4746f1
ace-n pushed a commit that referenced this pull request Nov 17, 2022
* translate document sample and test

Change-Id: Id0f943163f063e114aaec5703f3160a5b9c71485

* remove comment

Change-Id: I13ee4f8692c76416564d05485271a50929ff42cf

* lint

Change-Id: I3eb785d6a164748484726ad359a8ae7f8156051d

* batch translate document

Change-Id: Id36d46f363cb061c38ddf099e23836020757b9f2

* batch translate document

Change-Id: Ifbf6c3faec2352237f44d714c31360349b950efb

* update year

Change-Id: Icb80b2a660ee38de5cbbd09e497eeaf4d3532371

* refactor error handling

Change-Id: Ic7493f025e1c98b3c4e0dbc6a48919e8a2df309e

* refactor error handling

Change-Id: Ibe57fa98dbb060039d8b60684238294f3f4746f1
ace-n pushed a commit that referenced this pull request Nov 17, 2022
* translate document sample and test

Change-Id: Id0f943163f063e114aaec5703f3160a5b9c71485

* remove comment

Change-Id: I13ee4f8692c76416564d05485271a50929ff42cf

* lint

Change-Id: I3eb785d6a164748484726ad359a8ae7f8156051d

* batch translate document

Change-Id: Id36d46f363cb061c38ddf099e23836020757b9f2

* batch translate document

Change-Id: Ifbf6c3faec2352237f44d714c31360349b950efb

* update year

Change-Id: Icb80b2a660ee38de5cbbd09e497eeaf4d3532371

* refactor error handling

Change-Id: Ic7493f025e1c98b3c4e0dbc6a48919e8a2df309e

* refactor error handling

Change-Id: Ibe57fa98dbb060039d8b60684238294f3f4746f1
ace-n pushed a commit that referenced this pull request Nov 17, 2022
* translate document sample and test

Change-Id: Id0f943163f063e114aaec5703f3160a5b9c71485

* remove comment

Change-Id: I13ee4f8692c76416564d05485271a50929ff42cf

* lint

Change-Id: I3eb785d6a164748484726ad359a8ae7f8156051d

* batch translate document

Change-Id: Id36d46f363cb061c38ddf099e23836020757b9f2

* batch translate document

Change-Id: Ifbf6c3faec2352237f44d714c31360349b950efb

* update year

Change-Id: Icb80b2a660ee38de5cbbd09e497eeaf4d3532371

* refactor error handling

Change-Id: Ic7493f025e1c98b3c4e0dbc6a48919e8a2df309e

* refactor error handling

Change-Id: Ibe57fa98dbb060039d8b60684238294f3f4746f1
ace-n pushed a commit that referenced this pull request Nov 21, 2022
ace-n pushed a commit that referenced this pull request Nov 21, 2022
Shabirmean pushed a commit that referenced this pull request Feb 16, 2023
🤖 I have created a release *beep* *boop*
---


## [3.4.0](googleapis/nodejs-dlp@v3.3.0...v3.4.0) (2022-03-25)


### Features

* new Bytes and File types: POWERPOINT and EXCEL ([#693](googleapis/nodejs-dlp#693)) ([ed3dc42](googleapis/nodejs-dlp@ed3dc42))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants