Added integration tests to check that samples run. Closes #20. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmdobry
force-pushed
the
tests
branch
10 times, most recently
from
af8b8fa
to
cb4144c
Compare
|
@jonparrott Can you review? |
|
Yes, in the future, just assign it to me. :) |
|
Small nit: I don't like commit messages that are just "Closes #20". Please describe what you did to fix the bug, etc. |
|
LGTM. |
jmdobry
changed the title
jmdobry
added a commit
that referenced
this pull request
Nov 3, 2015
Added integration tests to check that samples run. Closes #20.
grayside
pushed a commit
that referenced
this pull request
Oct 26, 2022
grayside
pushed a commit
that referenced
this pull request
Nov 3, 2022
pattishin
pushed a commit
that referenced
this pull request
Nov 9, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
pattishin
pushed a commit
that referenced
this pull request
Nov 9, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
pattishin
pushed a commit
that referenced
this pull request
Nov 9, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
NimJay
pushed a commit
that referenced
this pull request
Nov 10, 2022
NimJay
pushed a commit
that referenced
this pull request
Nov 10, 2022
NimJay
pushed a commit
that referenced
this pull request
Nov 11, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
pattishin
pushed a commit
that referenced
this pull request
Nov 18, 2022
* feat: adds enhancements to library * chore: changes to synth.py * fix: broken pack n' play test * fix: add enhanced types to ts compiler * fix: project enabled * fix: adds docstrings to toValue(), fromValue() functions * fix: removing any * fix: edits to synth.py per reviewer * fix: add more test coverage * chore: added comment about conversion interface Co-authored-by: Sofia Leon <sofialeon@google.com>
pattishin
pushed a commit
that referenced
this pull request
Nov 22, 2022
* feat: adds enhancements to library * chore: changes to synth.py * fix: broken pack n' play test * fix: add enhanced types to ts compiler * fix: project enabled * fix: adds docstrings to toValue(), fromValue() functions * fix: removing any * fix: edits to synth.py per reviewer * fix: add more test coverage * chore: added comment about conversion interface Co-authored-by: Sofia Leon <sofialeon@google.com>
jsimonweb
pushed a commit
to jsimonweb/nodejs-docs-samples
that referenced
this pull request
Dec 12, 2022
irataxy
pushed a commit
that referenced
this pull request
Jan 14, 2023
🤖 I have created a release \*beep\* \*boop\* --- ## [1.2.0](https://www.github.com/googleapis/nodejs-video-transcoder/compare/v1.1.0...v1.2.0) (2021-01-09) ### Features * adds style enumeration ([#22](https://www.github.com/googleapis/nodejs-video-transcoder/issues/22)) ([9b9ca5d](https://www.github.com/googleapis/nodejs-video-transcoder/commit/9b9ca5db8168d70b8afb7dc994659ed92d6a645a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
irataxy
pushed a commit
that referenced
this pull request
Jan 18, 2023
🤖 I have created a release \*beep\* \*boop\* --- ## [1.2.0](https://www.github.com/googleapis/nodejs-video-transcoder/compare/v1.1.0...v1.2.0) (2021-01-09) ### Features * adds style enumeration ([#22](https://www.github.com/googleapis/nodejs-video-transcoder/issues/22)) ([9b9ca5d](https://www.github.com/googleapis/nodejs-video-transcoder/commit/9b9ca5db8168d70b8afb7dc994659ed92d6a645a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.