Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate code from googleapis/nodejs-ai-platform #2876

Merged
merged 76 commits into from
Nov 22, 2022
Merged

migrate code from googleapis/nodejs-ai-platform #2876

merged 76 commits into from
Nov 22, 2022

Conversation

pattishin
Copy link
Contributor

bcoe and others added 30 commits November 10, 2020 11:30
@bcoe
feat!: initial generation of library (#4)
884368f
@release-please
chore: release 1.0.0 (#6)
b9770cc 
🤖 I have created a release \*beep\* \*boop\* 
---
## 1.0.0 (2020-11-10)


### ⚠ BREAKING CHANGES

* initial generation of library (#4)

### Features

* initial generation ([182128b](https://www.github.com/googleapis/nodejs-ai-platform/commit/182128bfa593c787e2f0970ba224a68595b45971))
* initial generation of library ([#4](https://www.github.com/googleapis/nodejs-ai-platform/issues/4)) ([1b8db30](https://www.github.com/googleapis/nodejs-ai-platform/commit/1b8db30e243aac5d9dab74b00431c81dbf412a66))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@telpirion @sofisl
feat: adds enhancements to library (#22)
bb76ec5 
* feat: adds enhancements to library

* chore: changes to synth.py

* fix: broken pack n' play test

* fix: add enhanced types to ts compiler

* fix: project enabled

* fix: adds docstrings to toValue(), fromValue() functions

* fix: removing any

* fix: edits to synth.py per reviewer

* fix: add more test coverage

* chore: added comment about conversion interface

Co-authored-by: Sofia Leon <sofialeon@google.com>
@release-please
chore: release 1.1.0 (#29)
c6916e6 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@telpirion @bcoe
feat: adds cleaner utility for orphaned resources (#34)
ecd8583 
* feat: adds cleaner utility function

Co-authored-by: Benjamin E. Coe <bencoe@google.com>
@release-please
chore: release 1.2.0 (#36)
9138e20 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.2.0](https://www.github.com/googleapis/nodejs-ai-platform/compare/v1.1.0...v1.2.0) (2021-01-09)


### Features

* adds cleaner utility for orphaned resources ([#34](https://www.github.com/googleapis/nodejs-ai-platform/issues/34)) ([7c09258](https://www.github.com/googleapis/nodejs-ai-platform/commit/7c09258eb99d9c40ba7bf28b6d84434d6bb8a5b9))
* adds style enumeration ([#37](https://www.github.com/googleapis/nodejs-ai-platform/issues/37)) ([81c1515](https://www.github.com/googleapis/nodejs-ai-platform/commit/81c15150f55c4ef20359c1e48530f2c9bcd0f64b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@telpirion
feat(samples): adds samples for enhanced version of library (#16)
ea5e774
@lucaswadedavis
Remove cleaning script from tests (#58)
6b734a1 
* Remove cleaning script from tests

* Remove unnecessary imports
@release-please
chore: release 1.3.0 (#39)
4daab03 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.3.0](https://www.github.com/googleapis/nodejs-ai-platform/compare/v1.2.0...v1.3.0) (2021-01-14)


### Features

* **samples:** adds samples for enhanced version of library ([#16](https://www.github.com/googleapis/nodejs-ai-platform/issues/16)) ([aef443c](https://www.github.com/googleapis/nodejs-ai-platform/commit/aef443c41b8a9a2199e0c5b100a5ab91444b0dfe))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@sofisl
build: increase retries and timeout for flaky tests (#60)
31d2992 
* build: increase retries and timeout for flaky tests
@sofisl
build: increase retries for #33 (#61)
a26c64d 
* build: increase retries and timeout for flaky tests
@telpirion @JustinBeckwith
samples: fix region tag (#65)
4d446d5 
* samples: fix region tag

* fix: per reviewer

Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
@telpirion
fix: reduces image object detection test file size (#69)
a35f497 
* fix: reduced image size due to new file size limit (1.5 MB)
* fix: more file sizing
@lucaswadedavis @telpirion @bcoe
feat(samples): add additional samples to library (#25)
66ff554 
* Add samples

* Fix linter errors

* Remove unnecessary samples and tests

* Fix minor linter error

* Remove unnecessary comments and other small updates

* Update project id

* Add samples

* Fix linter errors

* Remove unnecessary samples and tests

* Fix minor linter error

* Remove unnecessary comments and other small updates

* Update project id

* Remove terminal await calls

* Fix configuration issues

* Fix parsing error

* Update samples/package.json

* Update samples/predict-custom-trained-model.js

* Fix async file access for Node 10

* Ensmallify the example image

Co-authored-by: Eric Schmidt <erschmid@google.com>
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
@telpirion
feat: updates enhanced client library veneer and samples (#73)
4dc0382
@release-please @telpirion
chore: release 1.4.0 (#64)
19be240 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Eric Schmidt <erschmid@google.com>
@lucaswadedavis
test: extend timeout (#78)
0e1ed18
@release-please
chore: release 1.5.0 (#79)
85870eb 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@lucaswadedavis
Rename apiEndpoint for samples (#82)
26e3429
@release-please
chore: release 1.6.0 (#87)
3bc8a08 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@lucaswadedavis
Fix typo in path (#112)
e414fb5 
* Update create-custom-job.test.js

Fix typo in path

* Update create-custom-job.test.js

* Update create-custom-job.test.js
@telpirion @gcf-owl-bot
samples: adds batch prediction samples for text (#119)
feaac09 
* samples: adds batch prediction samples for text

* samples: added tests

* 🦉 Updates from OwlBot

* fix: lint

* fix: lint

* fix: docs test

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@gcf-owl-bot
chore: new owl bot post processor docker image (#121)
631d2ea 
gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:f93bb861d6f12574437bb9aee426b71eafd63b419669ff0ed029f4b7e7162e3f
@release-please @bcoe
chore: release 1.7.0 (#125)
d5d8366 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
@telpirion
samples: adds missing Node.js samples (#128)
f89ca59 
* samples: adds missing Node.js samples
@release-please
chore: release 1.7.1 (#144)
4c75bec 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@telpirion
test: deploy mode test failure (#145)
f85f8e2
@release-please
chore: release 1.7.2 (#153)
bde81ef 
🤖 I have created a release \*beep\* \*boop\*
---
### [1.7.2](https://www.github.com/googleapis/nodejs-ai-platform/compare/v1.7.1...v1.7.2) (2021-06-22)


### Bug Fixes

* make request optional in all cases ([#152](https://www.github.com/googleapis/nodejs-ai-platform/issues/152)) ([96b9fba](https://www.github.com/googleapis/nodejs-ai-platform/commit/96b9fba9b66807ac5ea2c5826d5fd3f4e895dc9e))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please
chore: release 1.7.3 (#159)
0efbbea 
🤖 I have created a release \*beep\* \*boop\*
---
### [1.7.3](https://www.github.com/googleapis/nodejs-ai-platform/compare/v1.7.2...v1.7.3) (2021-06-29)


### Bug Fixes

* add C#, PHP and Ruby options for all AI Platform protos ([#158](https://www.github.com/googleapis/nodejs-ai-platform/issues/158)) ([da0babf](https://www.github.com/googleapis/nodejs-ai-platform/commit/da0babf54c6b074b8dc3d0354f8a57b9bc0cefc1))
* **deps:** google-gax v2.17.0 with mTLS ([#161](https://www.github.com/googleapis/nodejs-ai-platform/issues/161)) ([8e7d46f](https://www.github.com/googleapis/nodejs-ai-platform/commit/8e7d46f1252c4e89a663dd28b70b49bf269f091a))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please
chore: release 1.7.4 (#165)
1092d8f 
🤖 I have created a release \*beep\* \*boop\*
---
### [1.7.4](https://www.github.com/googleapis/nodejs-ai-platform/compare/v1.7.3...v1.7.4) (2021-07-12)


### Bug Fixes

* **deps:** google-gax v2.17.1 ([#164](https://www.github.com/googleapis/nodejs-ai-platform/issues/164)) ([1ec11fc](https://www.github.com/googleapis/nodejs-ai-platform/commit/1ec11fc4fac373ee1a28ac10676fbfe9fc5535d1))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@pattishin pattishin requested a review from a team as a code owner November 18, 2022 22:34
@snippet-bot
Copy link

snippet-bot bot commented Nov 18, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 110 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@pattishin pattishin requested a review from a team as a code owner November 21, 2022 21:54
@NimJay
Copy link
Contributor

NimJay commented Nov 21, 2022 •
edited
Loading

I created a test pull-request at googleapis/nodejs-ai-platform#469 (in the original repo).
I wanted to double check whether these tests were already failing in the original repo (googleapis/nodejs-ai-platform).
More specifically, I'm running the create-featurestore-fixed-nodes-sample.test.js tests.
create-featurestore-fixed-nodes-sample.test.js is passing in the original repo.

This confirms that we're just missing some CI environment setup in GoogleCloudPlatform/nodejs-docs-samples that we already have inside googleapis/nodejs-ai-platform.

@pattishin
Copy link
Contributor Author

I created a test pull-request at googleapis/nodejs-ai-platform#469 (in the original repo). I wanted to double check whether these tests were already failing in the original repo (googleapis/nodejs-ai-platform). More specifically, I'm running the create-featurestore-fixed-nodes-sample.test.js tests. create-featurestore-fixed-nodes-sample.test.js is passing in the original repo.

This confirms that we're just missing some CI environment setup in GoogleCloudPlatform/nodejs-docs-samples that we already have inside googleapis/nodejs-ai-platform.

Thanks Nim! Currently updating this as we speak 👍🏼 I'll put a WIP in the PR title

@pattishin pattishin changed the title migrate code from googleapis/nodejs-ai-platform migrate code from googleapis/nodejs-ai-platform (⚠️ WIP) Nov 21, 2022
@pattishin pattishin changed the title migrate code from googleapis/nodejs-ai-platform (⚠️ WIP) migrate code from googleapis/nodejs-ai-platform Nov 22, 2022
@pattishin
Copy link
Contributor Author

pattishin commented Nov 22, 2022 •
edited
Loading

Added a couple of new secrets to the project, so tests are passing now. All ready for another look! 👓

ace-n
ace-n approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@ace-n ace-n left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about the quickstart, otherwise LGTM. 👍

@pattishin pattishin merged commit 7374449 into main Nov 22, 2022
@pattishin pattishin deleted the nodejs-ai-platform-migration branch November 22, 2022 19:47
@pattishin pattishin mentioned this pull request Nov 23, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kweinmeister kweinmeister kweinmeister approved these changes

@telpirion telpirion telpirion approved these changes

@ace-n ace-n ace-n approved these changes

@NimJay NimJay Awaiting requested review from NimJay

Assignees
No one assigned
Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.