update the sentiment threshold; fix a typo in some commented-out code. #341

amygdala · 2017-04-06T04:14:40Z

It looks like the sentiment score range changed since this example was written; updating the SENTIMENT_THRESHOLD to reflect that. Also changed some of the comment wording to avoid the word 'magnitude' in ref to score, which was probably confusing.
Fixed a typo in some commented-out logging code.

amygdala · 2017-04-06T04:15:39Z

@ace-n Ace, hope you don't mind that I assigned you to this PR.

amygdala · 2017-04-06T15:02:10Z

(AFAICT the test failure was not related to my changes..)

amygdala · 2017-04-12T18:17:44Z

Adding Jason as a reviewer since he's back and looked at the orig version of this example.
I think the test is failing on some 'yarn install' step, which AFAICT is unrelated.

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

🤖 I have created a release \*beep\* \*boop\* --- ### [3.2.4](https://www.github.com/googleapis/nodejs-talent/compare/v3.2.3...v3.2.4) (2021-06-30) ### Bug Fixes * **deps:** google-gax v2.17.0 with mTLS ([#341](https://www.github.com/googleapis/nodejs-talent/issues/341)) ([2c240e8](https://www.github.com/googleapis/nodejs-talent/commit/2c240e8cf02566285836b506addbfdfcc76cfa98)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

#341)

* docs: move and update beta import samples * Update import-dataset.js Co-authored-by: Benjamin E. Coe <bencoe@google.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [mocha](https://mochajs.org/) ([source](https://github.com/mochajs/mocha)) | devDependencies | major | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/mocha/7.2.0/8.0.1) | --- ### Release Notes <details> <summary>mochajs/mocha</summary> ### [`v8.0.1`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#801--2020-06-10) [Compare Source](https://github.com/mochajs/mocha/compare/v8.0.0...v8.0.1) The obligatory patch after a major. #### 🐛 Fixes - [#4328](https://github.com/mochajs/mocha/issues/4328): Fix `--parallel` when combined with `--watch` ([**@boneskull**](https://github.com/boneskull)) ### [`v8.0.0`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#800--2020-06-10) [Compare Source](https://github.com/mochajs/mocha/compare/v7.2.0...v8.0.0) In this major release, Mocha adds the ability to _run tests in parallel_. Better late than never! Please note the **breaking changes** detailed below. Let's welcome [**@giltayar**](https://github.com/giltayar) and [**@nicojs**](https://github.com/nicojs) to the maintenance team! #### 💥 Breaking Changes - [#4164](https://github.com/mochajs/mocha/issues/4164): **Mocha v8.0.0 now requires Node.js v10.0.0 or newer.** Mocha no longer supports the Node.js v8.x line ("Carbon"), which entered End-of-Life at the end of 2019 ([**@UlisesGascon**](https://github.com/UlisesGascon)) - [#4175](https://github.com/mochajs/mocha/issues/4175): Having been deprecated with a warning since v7.0.0, **`mocha.opts` is no longer supported** ([**@juergba**](https://github.com/juergba)) ✨ **WORKAROUND:** Replace `mocha.opts` with a [configuration file](https://mochajs.org/#configuring-mocha-nodejs). - [#4260](https://github.com/mochajs/mocha/issues/4260): Remove `enableTimeout()` (`this.enableTimeout()`) from the context object ([**@craigtaub**](https://github.com/craigtaub)) ✨ **WORKAROUND:** Replace usage of `this.enableTimeout(false)` in your tests with `this.timeout(0)`. - [#4315](https://github.com/mochajs/mocha/issues/4315): The `spec` option no longer supports a comma-delimited list of files ([**@juergba**](https://github.com/juergba)) ✨ **WORKAROUND**: Use an array instead (e.g., `"spec": "foo.js,bar.js"` becomes `"spec": ["foo.js", "bar.js"]`). - [#4309](https://github.com/mochajs/mocha/issues/4309): Drop support for Node.js v13.x line, which is now End-of-Life ([**@juergba**](https://github.com/juergba)) - [#4282](https://github.com/mochajs/mocha/issues/4282): `--forbid-only` will throw an error even if exclusive tests are avoided via `--grep` or other means ([**@arvidOtt**](https://github.com/arvidOtt)) - [#4223](https://github.com/mochajs/mocha/issues/4223): The context object's `skip()` (`this.skip()`) in a "before all" (`before()`) hook will no longer execute subsequent sibling hooks, in addition to hooks in child suites ([**@juergba**](https://github.com/juergba)) - [#4178](https://github.com/mochajs/mocha/issues/4178): Remove previously soft-deprecated APIs ([**@wnghdcjfe**](https://github.com/wnghdcjfe)): - `Mocha.prototype.ignoreLeaks()` - `Mocha.prototype.useColors()` - `Mocha.prototype.useInlineDiffs()` - `Mocha.prototype.hideDiff()` #### 🎉 Enhancements - [#4245](https://github.com/mochajs/mocha/issues/4245): Add ability to run tests in parallel for Node.js (see [docs](https://mochajs.org/#parallel-tests)) ([**@boneskull**](https://github.com/boneskull)) ❗ See also [#4244](https://github.com/mochajs/mocha/issues/4244); [Root Hook Plugins (docs)](https://mochajs.org/#root-hook-plugins) -- _root hooks must be defined via Root Hook Plugins to work in parallel mode_ - [#4304](https://github.com/mochajs/mocha/issues/4304): `--require` now works with ES modules ([**@JacobLey**](https://github.com/JacobLey)) - [#4299](https://github.com/mochajs/mocha/issues/4299): In some circumstances, Mocha can run ES modules under Node.js v10 -- _use at your own risk!_ ([**@giltayar**](https://github.com/giltayar)) #### 📖 Documentation - [#4246](https://github.com/mochajs/mocha/issues/4246): Add documentation for parallel mode and Root Hook plugins ([**@boneskull**](https://github.com/boneskull)) #### 🐛 Fixes (All bug fixes in Mocha v8.0.0 are also breaking changes, and are listed above) </details> --- ### Renovate configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻️ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-asset).

* docs: move and update beta import samples * Update import-dataset.js Co-authored-by: Benjamin E. Coe <bencoe@google.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [mocha](https://mochajs.org/) ([source](https://github.com/mochajs/mocha)) | devDependencies | major | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/mocha/7.2.0/8.0.1) | --- ### Release Notes <details> <summary>mochajs/mocha</summary> ### [`v8.0.1`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#801--2020-06-10) [Compare Source](https://github.com/mochajs/mocha/compare/v8.0.0...v8.0.1) The obligatory patch after a major. #### 🐛 Fixes - [#4328](https://github.com/mochajs/mocha/issues/4328): Fix `--parallel` when combined with `--watch` ([**@boneskull**](https://github.com/boneskull)) ### [`v8.0.0`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#800--2020-06-10) [Compare Source](https://github.com/mochajs/mocha/compare/v7.2.0...v8.0.0) In this major release, Mocha adds the ability to _run tests in parallel_. Better late than never! Please note the **breaking changes** detailed below. Let's welcome [**@giltayar**](https://github.com/giltayar) and [**@nicojs**](https://github.com/nicojs) to the maintenance team! #### 💥 Breaking Changes - [#4164](https://github.com/mochajs/mocha/issues/4164): **Mocha v8.0.0 now requires Node.js v10.0.0 or newer.** Mocha no longer supports the Node.js v8.x line ("Carbon"), which entered End-of-Life at the end of 2019 ([**@UlisesGascon**](https://github.com/UlisesGascon)) - [#4175](https://github.com/mochajs/mocha/issues/4175): Having been deprecated with a warning since v7.0.0, **`mocha.opts` is no longer supported** ([**@juergba**](https://github.com/juergba)) ✨ **WORKAROUND:** Replace `mocha.opts` with a [configuration file](https://mochajs.org/#configuring-mocha-nodejs). - [#4260](https://github.com/mochajs/mocha/issues/4260): Remove `enableTimeout()` (`this.enableTimeout()`) from the context object ([**@craigtaub**](https://github.com/craigtaub)) ✨ **WORKAROUND:** Replace usage of `this.enableTimeout(false)` in your tests with `this.timeout(0)`. - [#4315](https://github.com/mochajs/mocha/issues/4315): The `spec` option no longer supports a comma-delimited list of files ([**@juergba**](https://github.com/juergba)) ✨ **WORKAROUND**: Use an array instead (e.g., `"spec": "foo.js,bar.js"` becomes `"spec": ["foo.js", "bar.js"]`). - [#4309](https://github.com/mochajs/mocha/issues/4309): Drop support for Node.js v13.x line, which is now End-of-Life ([**@juergba**](https://github.com/juergba)) - [#4282](https://github.com/mochajs/mocha/issues/4282): `--forbid-only` will throw an error even if exclusive tests are avoided via `--grep` or other means ([**@arvidOtt**](https://github.com/arvidOtt)) - [#4223](https://github.com/mochajs/mocha/issues/4223): The context object's `skip()` (`this.skip()`) in a "before all" (`before()`) hook will no longer execute subsequent sibling hooks, in addition to hooks in child suites ([**@juergba**](https://github.com/juergba)) - [#4178](https://github.com/mochajs/mocha/issues/4178): Remove previously soft-deprecated APIs ([**@wnghdcjfe**](https://github.com/wnghdcjfe)): - `Mocha.prototype.ignoreLeaks()` - `Mocha.prototype.useColors()` - `Mocha.prototype.useInlineDiffs()` - `Mocha.prototype.hideDiff()` #### 🎉 Enhancements - [#4245](https://github.com/mochajs/mocha/issues/4245): Add ability to run tests in parallel for Node.js (see [docs](https://mochajs.org/#parallel-tests)) ([**@boneskull**](https://github.com/boneskull)) ❗ See also [#4244](https://github.com/mochajs/mocha/issues/4244); [Root Hook Plugins (docs)](https://mochajs.org/#root-hook-plugins) -- _root hooks must be defined via Root Hook Plugins to work in parallel mode_ - [#4304](https://github.com/mochajs/mocha/issues/4304): `--require` now works with ES modules ([**@JacobLey**](https://github.com/JacobLey)) - [#4299](https://github.com/mochajs/mocha/issues/4299): In some circumstances, Mocha can run ES modules under Node.js v10 -- _use at your own risk!_ ([**@giltayar**](https://github.com/giltayar)) #### 📖 Documentation - [#4246](https://github.com/mochajs/mocha/issues/4246): Add documentation for parallel mode and Root Hook plugins ([**@boneskull**](https://github.com/boneskull)) #### 🐛 Fixes (All bug fixes in Mocha v8.0.0 are also breaking changes, and are listed above) </details> --- ### Renovate configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻️ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-asset).

* docs: move and update beta import samples * Update import-dataset.js Co-authored-by: Benjamin E. Coe <bencoe@google.com>

* added create-featurestore-sample.js and create-featurestore-sample.test.js * feat(samples): added createFeaturestore sample (#313) * feat(samples): added remaining featurestore samples (#313) * removed the extraneous files * feat(samples): add feature-values apis samples (#313) * feat(samples): add feature values apis samples (#313) * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat(samples): update dependency featurevalues apis (#313) * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>

update the sentiment threshold; fix a typo in some commented-out code.

4e3a2ad

amygdala assigned ace-n Apr 6, 2017

Ace Nassri added 2 commits April 11, 2017 11:09

Fix lint error

97a79dc

Merge branch 'master' into sfix

9c0ee2d

amygdala requested a review from jmdobry April 12, 2017 18:17

jmdobry approved these changes Apr 12, 2017

View reviewed changes

jmdobry merged commit e008c70 into master Apr 12, 2017

jmdobry deleted the sfix branch April 12, 2017 20:16

snyk-bot mentioned this pull request Mar 11, 2022

[Snyk] Upgrade request-promise from 4.2.2 to 4.2.6 theWindSweptDev/nodejs-docs-samples#46

Open

grayside pushed a commit that referenced this pull request Oct 26, 2022

chore: release 1.7.2 (#341)

d779cf3

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

grayside mentioned this pull request Oct 26, 2022

migrate code from googleapis/nodejs-tasks #2792

Merged

grayside pushed a commit that referenced this pull request Nov 3, 2022

chore: release 1.7.2 (#341)

642bf66

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

NimJay pushed a commit that referenced this pull request Nov 10, 2022

update the sentiment threshold; fix a typo in some commented-out code. (

96af50f

#341)

NimJay mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-language #2827

Merged

NimJay pushed a commit that referenced this pull request Nov 10, 2022

update the sentiment threshold; fix a typo in some commented-out code. (

e67a091

#341)

ace-n pushed a commit that referenced this pull request Nov 11, 2022

docs: move and update beta import samples (#341)

8a2c52f

* docs: move and update beta import samples * Update import-dataset.js Co-authored-by: Benjamin E. Coe <bencoe@google.com>

ace-n mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-automl #2841

Merged

ace-n pushed a commit that referenced this pull request Nov 11, 2022

docs: move and update beta import samples (#341)

5a3d057

* docs: move and update beta import samples * Update import-dataset.js Co-authored-by: Benjamin E. Coe <bencoe@google.com>

ace-n pushed a commit that referenced this pull request Nov 14, 2022

docs: move and update beta import samples (#341)

ff6c914

* docs: move and update beta import samples * Update import-dataset.js Co-authored-by: Benjamin E. Coe <bencoe@google.com>

ace-n pushed a commit that referenced this pull request Nov 15, 2022

docs: move and update beta import samples (#341)

7218424

* docs: move and update beta import samples * Update import-dataset.js Co-authored-by: Benjamin E. Coe <bencoe@google.com>

ace-n pushed a commit that referenced this pull request Nov 15, 2022

docs: move and update beta import samples (#341)

33dac18

* docs: move and update beta import samples * Update import-dataset.js Co-authored-by: Benjamin E. Coe <bencoe@google.com>

ace-n pushed a commit that referenced this pull request Nov 16, 2022

refactor: use explicit mocha imports (#341)

517fe7f

ace-n mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-video-intelligence #2855

Merged

ahrarmonsur mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-asset #2856

Merged

ace-n pushed a commit that referenced this pull request Nov 17, 2022

refactor: use explicit mocha imports (#341)

bdadf05

ace-n pushed a commit that referenced this pull request Nov 17, 2022

docs: move and update beta import samples (#341)

912768b

* docs: move and update beta import samples * Update import-dataset.js Co-authored-by: Benjamin E. Coe <bencoe@google.com>

ace-n pushed a commit that referenced this pull request Nov 17, 2022

docs: move and update beta import samples (#341)

2cc13a5

* docs: move and update beta import samples * Update import-dataset.js Co-authored-by: Benjamin E. Coe <bencoe@google.com>

ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022

refactor: use explicit mocha imports (#341)

f9252da

ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022

docs: move and update beta import samples (#341)

f6a4f0c

* docs: move and update beta import samples * Update import-dataset.js Co-authored-by: Benjamin E. Coe <bencoe@google.com>

pattishin mentioned this pull request Nov 18, 2022

migrate code from googleapis/nodejs-ai-platform #2876

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update the sentiment threshold; fix a typo in some commented-out code. #341

update the sentiment threshold; fix a typo in some commented-out code. #341

amygdala commented Apr 6, 2017

amygdala commented Apr 6, 2017

amygdala commented Apr 6, 2017

amygdala commented Apr 12, 2017

update the sentiment threshold; fix a typo in some commented-out code. #341

update the sentiment threshold; fix a typo in some commented-out code. #341

Conversation

amygdala commented Apr 6, 2017

amygdala commented Apr 6, 2017

amygdala commented Apr 6, 2017

amygdala commented Apr 12, 2017