Cleaned up memcached example and added tests. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,6 +13,7 @@ and applications on [Google App Engine](http://cloud.google.com/nodejs). | |||
| ### Frameworks | |||
|
|
|||
| - Express.js - [Source code][express_1] | [App Engine Tutorial][express_2] | [Live demo][express_3] | [Documentation][express_4] | |||
| - Express.js + Memcached Sessions - [Source code][express_5] | [Documentation][express_6] | |||
There was a problem hiding this comment.
nit that you don't have to fix now: it would be better to have more described anchors here. express_6 is kinda of funny.
|
LGTM. |
jmdobry
force-pushed
the
fix-memcached
branch
from
c63cad4
to
656d99a
Compare
|
I simplified the test and the readme. Should be good to go. |
| key: 'view:count', | ||
| proxy: 'true', | ||
| store: new MemcachedStore({ | ||
| hosts: [process.env.MEMCACHE_URL || '127.0.0.1:11211'] |
There was a problem hiding this comment.
Now that you slimmed down the readme, a little comment here about how MEMCACHE_URL is set by GAE would be helpful. :)
There was a problem hiding this comment.
It's set by GAE? So it doesn't need to be set in the app.yaml file?
There was a problem hiding this comment.
Nvm, just saw the full thing. A comment in the readme about the memcache host then. :P
There was a problem hiding this comment.
I think there is one at the bottom.
|
LGTM w/ final nit. |
jmdobry
force-pushed
the
fix-memcached
branch
from
656d99a
to
5784567
Compare
jmdobry
force-pushed
the
fix-memcached
branch
from
5784567
to
4b16030
Compare
jmdobry
added a commit
that referenced
this pull request
Nov 13, 2015
Cleaned up memcached example and added tests.
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 8, 2022
telpirion
pushed a commit
that referenced
this pull request
Nov 9, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [1.2.0](https://www.github.com/googleapis/nodejs-contact-center-insights/compare/v1.1.0...v1.2.0) (2021-08-11) ### Features * add new issue model API methods ([b73f2e9](https://www.github.com/googleapis/nodejs-contact-center-insights/commit/b73f2e93ddb572519685190643c1f02174813658)) * support Dialogflow and user-specified participant IDs ([b73f2e9](https://www.github.com/googleapis/nodejs-contact-center-insights/commit/b73f2e93ddb572519685190643c1f02174813658)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Nov 9, 2022
…nter-insights (#2817) - feat: initial generation of templated files - feat: add initial samples (#2) - chore(deps): update dependency mocha to v9 (#3) - chore: release 1.0.0 (#1) - chore: release 1.0.1 (#12) - chore: release 1.0.2 (#18) - chore: release 1.1.0 (#21) - chore: release 1.2.0 (#26) - chore: release 1.2.1 (#29) - chore: release 1.3.0 (#36) - chore: release 1.4.0 (#40) - samples: get operation (#52) - samples: create conversation, create analysis, export data to BigQuery (#34) - samples: enable pubsub notifications (#48) - samples: modify TTL in create conversation with TTL sample (#57) - samples: create topic model (#49) - chore: release 1.5.0 (#58) - samples: set project-level TTL (#51) - samples: create custom highlights (#53) - chore: release 1.6.0 (#65) - chore: release 1.7.0 (#69) - chore: release 1.8.0 (#75) - chore: release 1.9.0 (#81) - chore(main): release 1.11.0 (#107) - build: add retries for flaky test (#109) - build!: update library to use Node 12 (#122) - chore(main): release 2.0.0 (#124) - fix(deps): update dependency @google-cloud/bigquery to v6 (#127) - fix(deps): update dependency @google-cloud/pubsub to v3 (#126) - chore(main): release 2.0.1 (#129) - chore(main): release 2.1.0 (#134) - chore(main): release 2.1.1 (#139) - chore(deps): update dependency uuid to v9 (#142)
ace-n
pushed a commit
that referenced
this pull request
Nov 10, 2022
grayside
pushed a commit
that referenced
this pull request
Nov 16, 2022
* chore: lock files maintenance * chore: lock files maintenance
This was referenced Nov 16, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
* chore: lock files maintenance * chore: lock files maintenance
grayside
pushed a commit
that referenced
this pull request
Nov 17, 2022
* chore: lock files maintenance * chore: lock files maintenance
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 17, 2022
* chore: lock files maintenance * chore: lock files maintenance
Shabirmean
pushed a commit
that referenced
this pull request
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.