-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Logging API example. #53
Conversation
// [START list] | ||
var google = require('googleapis'); | ||
var projectId = process.env.TEST_PROJECT_ID || '<your-project-id>'; | ||
var logging = google.logging('v2beta1').entries; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have veneer support for this now - can we use that instead?
https://github.com/GoogleCloudPlatform/gcloud-node#google-cloud-logging-beta
45ae851
to
a0ec2c0
Compare
@jonparrott ready for review |
|
||
// create a new sink | ||
// | ||
// This method only works if you are authenticated as yourself, e.g. using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, that's what the cloud-node logging docs say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling @stephenplusplus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with small nits. |
a386b52
to
c5963c9
Compare
…nter-insights (#2817) - feat: initial generation of templated files - feat: add initial samples (#2) - chore(deps): update dependency mocha to v9 (#3) - chore: release 1.0.0 (#1) - chore: release 1.0.1 (#12) - chore: release 1.0.2 (#18) - chore: release 1.1.0 (#21) - chore: release 1.2.0 (#26) - chore: release 1.2.1 (#29) - chore: release 1.3.0 (#36) - chore: release 1.4.0 (#40) - samples: get operation (#52) - samples: create conversation, create analysis, export data to BigQuery (#34) - samples: enable pubsub notifications (#48) - samples: modify TTL in create conversation with TTL sample (#57) - samples: create topic model (#49) - chore: release 1.5.0 (#58) - samples: set project-level TTL (#51) - samples: create custom highlights (#53) - chore: release 1.6.0 (#65) - chore: release 1.7.0 (#69) - chore: release 1.8.0 (#75) - chore: release 1.9.0 (#81) - chore(main): release 1.11.0 (#107) - build: add retries for flaky test (#109) - build!: update library to use Node 12 (#122) - chore(main): release 2.0.0 (#124) - fix(deps): update dependency @google-cloud/bigquery to v6 (#127) - fix(deps): update dependency @google-cloud/pubsub to v3 (#126) - chore(main): release 2.0.1 (#129) - chore(main): release 2.1.0 (#134) - chore(main): release 2.1.1 (#139) - chore(deps): update dependency uuid to v9 (#142)
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* chore: lock files maintenance * chore: lock files maintenance
* chore: lock files maintenance * chore: lock files maintenance
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
No description provided.