add task list example application #28
Conversation
|
LGTM |
| @@ -4,6 +4,9 @@ | |||
| "version": "0.0.1", | |||
| "private": true, | |||
| "license": "Apache Version 2.0", | |||
| "bin": { | |||
There was a problem hiding this comment.
Nobody is going to be installing this sample via npm, and thus no node_modules/.bin symlink will be created. Perhaps you meant this to be "scripts", as done here.
There was a problem hiding this comment.
npm link instead of npm install will make it available. The instructions section above suggests that, since it will install the deps and link at the same time.
There was a problem hiding this comment.
All of the samples in the repo should be consistent on how they instruct the user to run the sample. Do you think npm link and "bin" is better than how the storage/ samples does it? I'm leaning towards how the storage/ sample does it because it keeps everything local to the sample without affecting something elsewhere on the user's comp. What are your thoughts?
There was a problem hiding this comment.
Yeah, probably not worth dealing with issues about the symlink failing due to permissions and such. It does allow a nicer interface, though:
$ datastore-tasks listvs.
$ npm run datastore-tasks listI'll switch this over to the second style.
Regarding the consistency note, do you prefer datastoreTasks to match authSample? Better yet, maybe just tasks?:
$ npm run tasks listThere was a problem hiding this comment.
authSample follows the convention where the command for executing the sample has the same name as the sample file itself, e.g. npm run authSample because the file is named authSample.js. So here, the names should be consistent. If you want the command to be tasks, then you should rename the file to tasks.js
stephenplusplus
force-pushed
the
master
branch
from
fa76ff1
to
5d79aa9
Compare
add task list example application
🤖 I have created a release \*beep\* \*boop\* --- ### [1.2.1](https://www.github.com/googleapis/nodejs-contact-center-insights/compare/v1.2.0...v1.2.1) (2021-08-17) ### Bug Fixes * **build:** migrate to using main branch ([#28](https://www.github.com/googleapis/nodejs-contact-center-insights/issues/28)) ([137533f](https://www.github.com/googleapis/nodejs-contact-center-insights/commit/137533f0f3ce60dc0cb9edc4c690063c853ade0b)) * **deps:** google-gax v2.24.1 ([#30](https://www.github.com/googleapis/nodejs-contact-center-insights/issues/30)) ([e3ac1ff](https://www.github.com/googleapis/nodejs-contact-center-insights/commit/e3ac1ff60bf3c4921ef9a9f103e236c7d513cdab)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
* feat: adds cleanup function for tests
* feat: adds cleanup function for tests
* feat: adds cleanup function for tests
* feat: adds cleanup function for tests
* Release v0.1.1 * Update CHANGELOG.md
* chore: remove vendored dependencies * chore: remove replace * chore(ci): fix lint workflow * chore: update alloydbconn version
* docs: add Live Stream samples and tests * Add project number needed for samples test in kokoro configs. * Remove project number requirements. Use project ID for function parameters * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* docs: add Live Stream samples and tests * Add project number needed for samples test in kokoro configs. * Remove project number requirements. Use project ID for function parameters * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
No description provided.