Getting datastore tests running on CI. #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmdobry
force-pushed
the
datastore-tests
branch
from
5d4a5ec
to
eb7f40a
Compare
|
@stephenplusplus This commit is to get the datastore tests running on Travis. The proper APIs are enabled in the nodejs-docs-samples cloud project, and the datastore samples now initialize gcloud.datastore with the keyfile, but the tests still get a forbidden error. When I switched the datastore samples (locally) to use the latest release of gcloud, it worked. Can you shed any light on this? Also, these tests need to remove any data they write (and only the data they write) to the datastore at the end of the tests. |
|
The Travis project is whitelisted for v1beta3? |
I'm not sure. I guess that is my other question. These datastore samples, we put them on the master branch, but they're not actually usable by everybody yet? If that's the case, I'm thinking these datastore samples should be pulled back out of master onto a different branch. I think master should only contain samples and docs that pertain to the latest public releases of gcloud. |
That's fine, whatever you think. All of these Datastore samples are for v1beta3. |
jmdobry
added a commit
that referenced
this pull request
Nov 19, 2015
Getting datastore tests running on CI.
grayside
pushed a commit
that referenced
this pull request
Oct 26, 2022
grayside
pushed a commit
that referenced
this pull request
Nov 3, 2022
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 8, 2022
telpirion
pushed a commit
that referenced
this pull request
Nov 9, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [1.2.1](https://www.github.com/googleapis/nodejs-contact-center-insights/compare/v1.2.0...v1.2.1) (2021-08-17) ### Bug Fixes * **build:** migrate to using main branch ([#28](https://www.github.com/googleapis/nodejs-contact-center-insights/issues/28)) ([137533f](https://www.github.com/googleapis/nodejs-contact-center-insights/commit/137533f0f3ce60dc0cb9edc4c690063c853ade0b)) * **deps:** google-gax v2.24.1 ([#30](https://www.github.com/googleapis/nodejs-contact-center-insights/issues/30)) ([e3ac1ff](https://www.github.com/googleapis/nodejs-contact-center-insights/commit/e3ac1ff60bf3c4921ef9a9f103e236c7d513cdab)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 10, 2022
rogerthatdev
pushed a commit
that referenced
this pull request
Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [1.1.0](https://www.github.com/googleapis/nodejs-workflows/compare/v1.0.2...v1.1.0) (2021-01-09) ### Features * adds style enumeration ([#30](https://www.github.com/googleapis/nodejs-workflows/issues/30)) ([de3c259](https://www.github.com/googleapis/nodejs-workflows/commit/de3c259d08dae7edd775310c0db35fa089f58db3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [1.1.0](https://www.github.com/googleapis/nodejs-workflows/compare/v1.0.2...v1.1.0) (2021-01-09) ### Features * adds style enumeration ([#30](https://www.github.com/googleapis/nodejs-workflows/issues/30)) ([de3c259](https://www.github.com/googleapis/nodejs-workflows/commit/de3c259d08dae7edd775310c0db35fa089f58db3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
rogerthatdev
pushed a commit
that referenced
this pull request
Nov 11, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [1.1.0](https://www.github.com/googleapis/nodejs-workflows/compare/v1.0.2...v1.1.0) (2021-01-09) ### Features * adds style enumeration ([#30](https://www.github.com/googleapis/nodejs-workflows/issues/30)) ([de3c259](https://www.github.com/googleapis/nodejs-workflows/commit/de3c259d08dae7edd775310c0db35fa089f58db3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.
ace-n
pushed a commit
that referenced
this pull request
Nov 12, 2022
BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.
ace-n
pushed a commit
that referenced
this pull request
Nov 14, 2022
BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.
ace-n
pushed a commit
that referenced
this pull request
Nov 16, 2022
* Added Video Transcription sample code. * Code cleanup after running prettier. * Removed the ^
telpirion
pushed a commit
that referenced
this pull request
Nov 16, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
* Added Video Transcription sample code. * Code cleanup after running prettier. * Removed the ^
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 17, 2022
* Added Video Transcription sample code. * Code cleanup after running prettier. * Removed the ^
NimJay
pushed a commit
that referenced
this pull request
Nov 18, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
NimJay
pushed a commit
that referenced
this pull request
Nov 18, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
jsimonweb
pushed a commit
to jsimonweb/nodejs-docs-samples
that referenced
this pull request
Dec 12, 2022
…dPlatform#30) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [golang.org/x/oauth2](https://github.com/golang/oauth2) | require | digest | `6242fa9` -> `9780585` | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/GoogleCloudPlatform/alloydb-auth-proxy).
telpirion
pushed a commit
that referenced
this pull request
Jan 11, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.0](https://github.com/googleapis/nodejs-video-stitcher/compare/v0.2.2...v0.3.0) (2022-12-20) ### Features * Add support for Media CDN ([83f1257](https://github.com/googleapis/nodejs-video-stitcher/commit/83f1257b790abc8ef7acedb8e009ef5e94a0c710)) ### Bug Fixes * **deps:** Use google-gax v3.5.2 ([#40](https://github.com/googleapis/nodejs-video-stitcher/issues/40)) ([effa481](https://github.com/googleapis/nodejs-video-stitcher/commit/effa4814da8b7d81b6c5be6b6e580a683f02c50e)) * Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-video-stitcher/issues/1553)) ([#27](https://github.com/googleapis/nodejs-video-stitcher/issues/27)) ([b7fe723](https://github.com/googleapis/nodejs-video-stitcher/commit/b7fe723d1a2dfb229b69640ca749398805573e56)) * Preserve default values in x-goog-request-params header ([#32](https://github.com/googleapis/nodejs-video-stitcher/issues/32)) ([28c3214](https://github.com/googleapis/nodejs-video-stitcher/commit/28c32148f4707550c6c6a143c7556560d6b21230)) * Regenerated protos JS and TS definitions ([#43](https://github.com/googleapis/nodejs-video-stitcher/issues/43)) ([8f7481e](https://github.com/googleapis/nodejs-video-stitcher/commit/8f7481ed1f5fc054abe6430e43570851c39740d0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
irataxy
pushed a commit
that referenced
this pull request
Jan 13, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.0](https://github.com/googleapis/nodejs-video-stitcher/compare/v0.2.2...v0.3.0) (2022-12-20) ### Features * Add support for Media CDN ([83f1257](https://github.com/googleapis/nodejs-video-stitcher/commit/83f1257b790abc8ef7acedb8e009ef5e94a0c710)) ### Bug Fixes * **deps:** Use google-gax v3.5.2 ([#40](https://github.com/googleapis/nodejs-video-stitcher/issues/40)) ([effa481](https://github.com/googleapis/nodejs-video-stitcher/commit/effa4814da8b7d81b6c5be6b6e580a683f02c50e)) * Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-video-stitcher/issues/1553)) ([#27](https://github.com/googleapis/nodejs-video-stitcher/issues/27)) ([b7fe723](https://github.com/googleapis/nodejs-video-stitcher/commit/b7fe723d1a2dfb229b69640ca749398805573e56)) * Preserve default values in x-goog-request-params header ([#32](https://github.com/googleapis/nodejs-video-stitcher/issues/32)) ([28c3214](https://github.com/googleapis/nodejs-video-stitcher/commit/28c32148f4707550c6c6a143c7556560d6b21230)) * Regenerated protos JS and TS definitions ([#43](https://github.com/googleapis/nodejs-video-stitcher/issues/43)) ([8f7481e](https://github.com/googleapis/nodejs-video-stitcher/commit/8f7481ed1f5fc054abe6430e43570851c39740d0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
irataxy
added a commit
that referenced
this pull request
Jan 18, 2023
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/nodejs-video-live-stream/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [X] Ensure the tests and linter pass - [X] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes b:219762506
grayside
pushed a commit
that referenced
this pull request
Jan 18, 2023
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/nodejs-video-live-stream/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [X] Ensure the tests and linter pass - [X] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes b:219762506
Shabirmean
pushed a commit
that referenced
this pull request
Feb 16, 2023
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.