Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(speech): adds V2 samples #2888

Merged
merged 16 commits into from
Dec 9, 2022
Merged

feat(speech): adds V2 samples #2888

merged 16 commits into from
Dec 9, 2022

Conversation

telpirion
Copy link
Contributor

@telpirion telpirion commented Nov 28, 2022 •
edited
Loading

Python canonical samples are here.

@product-auto-label product-auto-label bot added api: speech Issues related to the Speech-to-Text API. samples Issues that are directly related to samples. labels Nov 28, 2022
@telpirion telpirion added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2022
@telpirion telpirion marked this pull request as ready for review December 5, 2022 19:53
@telpirion telpirion requested review from a team as code owners December 5, 2022 19:53
@snippet-bot
Copy link

snippet-bot bot commented Dec 5, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

ace-n
ace-n suggested changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than moving away from CLI arguments.

speech/quickstart.v2.js Outdated
console.error(err.message);
process.exitCode = 1;
});
main(...process.argv.slice(2));
Copy link
Contributor

@ace-n ace-n Dec 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Samples Style Guide recommends avoiding CLIs.

For testing: can we replace this with exporting main call and console.log stubbing?

_Apply this comment throughout your PR - thanks! 🙂 _

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review! I've removed the CLI stuff and used stubbing instead.

@telpirion telpirion requested a review from ace-n December 6, 2022 22:58
@telpirion
Copy link
Contributor Author

The linter shows an error in the "healthcare" folder, but the error seems to be a false positive.

@telpirion telpirion added the automerge Merge the pull request once unit tests and other checks pass. label Dec 9, 2022
@telpirion telpirion merged commit 78f43d2 into main Dec 9, 2022
@telpirion telpirion deleted the speech-v2 branch December 9, 2022 17:50
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 9, 2022
@telpirion telpirion mentioned this pull request Jun 5, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ace-n ace-n ace-n approved these changes

Assignees
No one assigned
Labels
api: speech Issues related to the Speech-to-Text API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@telpirion @ace-n @kokoro-team