-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: chat prompt sample for Vertex LLMs #3246
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
|
||
const prompt = { | ||
context: | ||
'My name is Ned. You are my personal assistant. My favorite movies are Lord of the Rings and Hobbit.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: As much as I LOVE LotR and all things Tolkien (ecce my GitHub alias), we should avoid using copyrighted or trademarked strings in our samples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Changed.
// [END aiplatform_sdk_chat] | ||
} | ||
|
||
process.on('unhandledRejection', err => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: remove CLI per https://googlecloudplatform.github.io/samples-style-guide/#no-cli
Example of how to do it: #2888
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. As discussed, we can handle this later with task "Remove the CLI structure from the Node.js samples for LLMs to track the changes." (b/285884334)
Description
Fixes b281562687
Added a chat prompt sample for Vertex LLMs.
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)