-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DLP: Added sample for de-identify table with FPE #3234
DLP: Added sample for de-identify table with FPE #3234
Conversation
This sample requires resources like valid |
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
e706cca
to
ef9ff6d
Compare
f77bede
to
fae5874
Compare
dlp/system-test/deid.test.js
Outdated
@@ -333,4 +335,29 @@ describe('deid', () => { | |||
} | |||
assert.include(output, 'INVALID_ARGUMENT'); | |||
}); | |||
|
|||
// dlp_deidentify_table_fpe | |||
it.skip('should de-identify table using Format Preserving Encryption (FPE)', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we skipping the tests in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They were skipped because we didn't have resources like wrappedKey
and keyName
. Anyway, now we are using mock API calls, so removed the it.skip
now and updated the tests. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skipped tests
@dinesh-crest please reference comment I made here to resolve the dlp workflow failure #3240 (comment) |
2085eb3
to
f8898fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address minor comments.
/gcb |
@dinesh-crest Please have a look at the test failures. |
e693a17
to
5237061
Compare
@kweinmeister resolved |
5237061
to
7110450
Compare
DLP: Added sample for de-identify table with FPE
Added unit test cases for same
PS:- I have marked the test cases to skip as the required resources are not available. I have verified locally and the test cases seem to be working fine if resources are provided.
Description
Reference:- https://cloud.google.com/dlp/docs/samples/dlp-deidentify-table-fpe
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)