Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLP: Added sample for de-identify using time extract #3240

Merged

Conversation

dinesh-crest
Copy link
Contributor

DLP: Added sample for de-identify using time extract
Added unit test cases for the same

Description

Reference:- https://cloud.google.com/dlp/docs/transformations-reference#time-extract

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@dinesh-crest dinesh-crest requested review from a team as code owners May 30, 2023 12:53
@snippet-bot
Copy link

snippet-bot bot commented May 30, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: dlp Issues related to the Sensitive Data Protection API. samples Issues that are directly related to samples. labels May 30, 2023
@kweinmeister kweinmeister added kokoro:force-run Add this label to force Kokoro to re-run the tests. actions:force-run labels May 30, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2023
@pattishin
Copy link
Contributor

pattishin commented Jun 8, 2023

Hi @dinesh-crest! I was diving into the failed workflow for your PRs, due to the way we've set the authentication up - you may need to directly clone this repo and create a PR off of it rather than your forked version to avoid the current failure.

@dinesh-crest
Copy link
Contributor Author

Hi @dinesh-crest! I was diving into the failed workflow for your PRs, due to the way we've set the authentication up - you may need to directly clone this repo and create a PR off of it rather than your forked version to avoid the current failure.

hi @pattishin This was discussed earlier with @annadata and we decided to go with this approach as I don't have enough permissions like creating a branch using the direct clone approach. Maybe @annadata can throw some light on this

@annadata annadata assigned annadata and unassigned imadethis Jun 13, 2023
@annadata annadata added kokoro:force-run Add this label to force Kokoro to re-run the tests. actions:force-run labels Jun 13, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 13, 2023
Copy link

@annadata annadata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

// The string to de-identify
// const string = 'My BirthDay is on 9/21/1976';

async function deidentifyWithTimeExtraction() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annadata annadata added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2023
@annadata annadata added kokoro:force-run Add this label to force Kokoro to re-run the tests. actions:force-run labels Jun 16, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2023
@annadata annadata added kokoro:force-run Add this label to force Kokoro to re-run the tests. actions:force-run and removed actions:force-run labels Jun 16, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2023
@pattishin pattishin merged commit f1ffc73 into GoogleCloudPlatform:main Jun 16, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions:force-run api: dlp Issues related to the Sensitive Data Protection API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants