-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DLP: Added sample for de-identify using time extract #3240
DLP: Added sample for de-identify using time extract #3240
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Hi @dinesh-crest! I was diving into the failed workflow for your PRs, due to the way we've set the authentication up - you may need to directly clone this repo and create a PR off of it rather than your forked version to avoid the current failure. |
98238a7
to
72e943d
Compare
hi @pattishin This was discussed earlier with @annadata and we decided to go with this approach as I don't have enough permissions like creating a branch using the direct clone approach. Maybe @annadata can throw some light on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise.
dlp/deidentifyWithTimeExtraction.js
Outdated
// The string to de-identify | ||
// const string = 'My BirthDay is on 9/21/1976'; | ||
|
||
async function deidentifyWithTimeExtraction() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please align the example with https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/dlp/snippets/src/main/java/dlp/snippets/DeIdentifyWithTimeExtraction.java
It uses a table.
72e943d
to
c43f12a
Compare
e02c8f3
to
8481efa
Compare
8481efa
to
5b078bd
Compare
DLP: Added sample for de-identify using time extract
Added unit test cases for the same
Description
Reference:- https://cloud.google.com/dlp/docs/transformations-reference#time-extract
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)