Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLP: Added sample for create stored infotype #3233

Merged

Conversation

dinesh-crest
Copy link
Contributor

DLP: Added sample for create stored infotype
Added unit test cases for the same

PS:- I have marked the test cases to skip as the required resources are not available. I have verified locally and the test cases seem to be working fine if resources are provided.

Description

Reference:- https://cloud.google.com/dlp/docs/creating-stored-infotypes#create-storedinfotye

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@dinesh-crest dinesh-crest requested review from a team as code owners May 26, 2023 11:56
@snippet-bot
Copy link

snippet-bot bot commented May 26, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: dlp Issues related to the Sensitive Data Protection API. samples Issues that are directly related to samples. labels May 26, 2023
@dinesh-crest
Copy link
Contributor Author

This sample requires resources like valid datasetProject, datasetId, tableId, and outputPath to run the sample. I don't see any reference to their availability in the existing test cases from Environment variables. I also observed they are marked to skip test cases in such cases and hence I have followed the same pattern. I have tested locally and if those resources are provided, the test cases run fine.

@annadata annadata assigned annadata and unassigned soumya92 May 30, 2023
@annadata annadata added kokoro:force-run Add this label to force Kokoro to re-run the tests. actions:force-run labels May 30, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2023
dlp/system-test/metadata.test.js Outdated Show resolved Hide resolved
dlp/createStoredInfoType.js Show resolved Hide resolved
@annadata
Copy link

This sample requires resources like valid datasetProject, datasetId, tableId, and outputPath to run the sample. I don't see any reference to their availability in the existing test cases from Environment variables. I also observed they are marked to skip test cases in such cases and hence I have followed the same pattern. I have tested locally and if those resources are provided, the test cases run fine.

We should move to using public dataset given in protocol example. That leaves us with a dependency on output path.

@annadata annadata added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2023
@kweinmeister kweinmeister added kokoro:force-run Add this label to force Kokoro to re-run the tests. actions:force-run labels Jun 7, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2023
@pattishin
Copy link
Contributor

@dinesh-crest please reference comment I made here to resolve the dlp workflow failure #3240 (comment)

@annadata annadata added kokoro:force-run Add this label to force Kokoro to re-run the tests. actions:force-run labels Jun 13, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 13, 2023
@annadata annadata added kokoro:force-run Add this label to force Kokoro to re-run the tests. actions:force-run labels Jun 14, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2023
@pattishin
Copy link
Contributor

@dinesh-crest Relevant to the github actions error, this PR should be unblocked when this is merged in #3279.

@kweinmeister kweinmeister added kokoro:force-run Add this label to force Kokoro to re-run the tests. actions:force-run labels Jun 15, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 15, 2023
@annadata annadata added kokoro:force-run Add this label to force Kokoro to re-run the tests. actions:force-run and removed actions:force-run labels Jun 16, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2023
@annadata annadata added kokoro:force-run Add this label to force Kokoro to re-run the tests. actions:force-run and removed actions:force-run labels Jun 16, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2023
@pattishin pattishin merged commit 24a8a83 into GoogleCloudPlatform:main Jun 16, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions:force-run api: dlp Issues related to the Sensitive Data Protection API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants