Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolving google-github-actions/auth@v1.1.1 failures #3279

Merged
merged 4 commits into from
Jun 15, 2023

Conversation

pattishin
Copy link
Contributor

@pattishin pattishin commented Jun 15, 2023

Description

Issue: Prevalent error that's been blocking many PRs around google-github-actions/auth@v1.1.1.

Screenshot 2023-06-14 at 6 30 46 PM

Our default in the workflow template does not specify permissions for id_token (ref: https://github.com/google-github-actions/auth#usage). This should resolve future new workflows created in PRs and current ones.

To see issue:

Test PR: #3275

Examples of PRs showing this failure atm:

To verify:

Focus on .github/workflows/utils/ci.yaml.njk and package.json for the main changes. The rest are only to add the missing permissions to affected workflows. This fix should unblock the above PRs.

Checklist

  • [ x ] I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • [ x ] Please merge this PR for me once it is approved

@pattishin pattishin requested review from a team as code owners June 15, 2023 02:07
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Jun 15, 2023
@pattishin pattishin added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Jun 15, 2023
@pattishin pattishin changed the title Fix: Resolving google-github-actions/auth@v1.1.1 failures fix: Resolving google-github-actions/auth@v1.1.1 failures Jun 15, 2023
@pattishin pattishin added the release blocking Required feature/issue must be fixed prior to next release. label Jun 15, 2023
@kweinmeister kweinmeister merged commit 57c4d51 into main Jun 15, 2023
20 checks passed
@kweinmeister kweinmeister deleted the fix/github-actions-token-failure branch June 15, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: workflows Issues related to the Workflows API. release blocking Required feature/issue must be fixed prior to next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants