Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding in permissions to workflows #3283

Merged
merged 12 commits into from
Jun 28, 2023

Conversation

pattishin
Copy link
Contributor

@pattishin pattishin commented Jun 16, 2023

Description

Additional testing stemming from #3279

Currently blocking #3265.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@pattishin pattishin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 16, 2023
@pattishin pattishin requested review from a team as code owners June 16, 2023 23:26
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 16, 2023
@product-auto-label product-auto-label bot added the api: workflows Issues related to the Workflows API. label Jun 16, 2023
@pattishin pattishin changed the title fix: adding in permissions to workflows [do not merge] 🚧 fix: adding in permissions to workflows Jun 16, 2023
@pattishin pattishin removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 16, 2023
@kweinmeister
Copy link
Collaborator

@pattishin LGTM, could we also include these changes in the 2 remaining templates (workflows using secrets, workflows using matrix strategy)? That will ensure new generated workflows using these templates will also work.

@pattishin
Copy link
Contributor Author

@pattishin LGTM, could we also include these changes in the 2 remaining templates (workflows using secrets, workflows using matrix strategy)? That will ensure new generated workflows using these templates will also work.

Can do!

@pattishin
Copy link
Contributor Author

@kweinmeister Ready for review again! Ty so much btw 🎊

@pattishin pattishin merged commit 1ff99bd into main Jun 28, 2023
31 of 32 checks passed
@pattishin pattishin deleted the fix/github-actions-token-failure-part-2 branch June 28, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants