Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect audience when creating cloud task #3268

Merged
merged 7 commits into from
Jun 16, 2023

Conversation

jeanregisser
Copy link
Contributor

Description

Fixes #3267

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@jeanregisser jeanregisser requested review from a team as code owners June 13, 2023 07:40
@google-cla
Copy link

google-cla bot commented Jun 13, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: tasks Issues related to the Tasks API API. labels Jun 13, 2023
@pattishin
Copy link
Contributor

Hi @jeanregisser, looks like cloud-tasks-tutorial-gcf-app / test / test are currently failing. Rather than fork the repo - if you could create this PR directly off of the nodejs-docs-samples repo, that should resolve the current issue auth actions issue.

@kweinmeister kweinmeister added kokoro:force-run Add this label to force Kokoro to re-run the tests. actions:force-run labels Jun 15, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 15, 2023
@pattishin
Copy link
Contributor

PR should resolve the github actions issue you're seeing in cloud-tasks-tutorial-gcf-app workflow. This should be unblocked when this fix is merged in #3279.

@pattishin pattishin merged commit 8f93d8c into GoogleCloudPlatform:main Jun 16, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: tasks Issues related to the Tasks API API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloud-tasks: tutorial-gcf UNAUTHENTICATED error when executing cloud task
5 participants