-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement: Refactor for compute samples and their tests #3868
Conversation
f7da78e
to
51e9f6b
Compare
00389eb
to
7794ee1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gryczj - Please take a look at this pending PR (#3892) and see if the updated guidance here helps you. We're asking folks to consider helping to reduce third party package dependencies and use vanilla Node.js standard libraries when possible. It may not be practical for every sample, but, for example, if it's necessary to switch from Node.js assert to Chai, please help us to understand why. Thanks!
1637234
to
d9ac113
Compare
d9ac113
to
dd00264
Compare
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.