Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Refactor for compute samples and their tests #3868

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

gryczj
Copy link
Contributor

@gryczj gryczj commented Sep 20, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gryczj gryczj self-assigned this Sep 20, 2024
@gryczj gryczj requested review from a team as code owners September 20, 2024 10:23
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Sep 20, 2024
@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 20, 2024
@gryczj gryczj force-pushed the improvements-for-tests-and-samples branch from f7da78e to 51e9f6b Compare September 20, 2024 10:24
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 20, 2024
@gryczj gryczj removed their assignment Sep 24, 2024
@subfuzion subfuzion self-assigned this Sep 25, 2024
@gryczj gryczj force-pushed the improvements-for-tests-and-samples branch 2 times, most recently from 00389eb to 7794ee1 Compare September 27, 2024 11:11
Copy link
Member

@subfuzion subfuzion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gryczj - Please take a look at this pending PR (#3892) and see if the updated guidance here helps you. We're asking folks to consider helping to reduce third party package dependencies and use vanilla Node.js standard libraries when possible. It may not be practical for every sample, but, for example, if it's necessary to switch from Node.js assert to Chai, please help us to understand why. Thanks!

@gryczj gryczj force-pushed the improvements-for-tests-and-samples branch 2 times, most recently from 1637234 to d9ac113 Compare October 3, 2024 16:48
@gryczj gryczj force-pushed the improvements-for-tests-and-samples branch from d9ac113 to dd00264 Compare October 3, 2024 17:44
@gryczj gryczj requested a review from subfuzion October 3, 2024 17:45
@gryczj gryczj mentioned this pull request Oct 3, 2024
10 tasks
@subfuzion subfuzion merged commit 6e61e3d into main Oct 3, 2024
32 checks passed
@subfuzion subfuzion deleted the improvements-for-tests-and-samples branch October 3, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants