Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: Refactor for compute samples and their tests #3868

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

improvement: Refactor for compute samples and their tests #3868

wants to merge 1 commit into from

Conversation

gryczj
Copy link
Contributor

@gryczj gryczj commented Sep 20, 2024 •
edited
Loading

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gryczj gryczj self-assigned this Sep 20, 2024
@gryczj gryczj requested review from a team as code owners September 20, 2024 10:23
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Sep 20, 2024
@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 20, 2024
@gryczj gryczj force-pushed the improvements-for-tests-and-samples branch from f7da78e to 51e9f6b Compare September 20, 2024 10:24
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 20, 2024
This was referenced Sep 20, 2024
Open
Open
Open
@gryczj gryczj removed their assignment Sep 24, 2024
@subfuzion subfuzion self-assigned this Sep 25, 2024
@gryczj gryczj force-pushed the improvements-for-tests-and-samples branch from 0df2760 to 00389eb Compare September 26, 2024 13:11
@gryczj gryczj force-pushed the improvements-for-tests-and-samples branch from 00389eb to 7794ee1 Compare September 27, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subfuzion subfuzion Awaiting requested review from subfuzion

At least 1 approving review is required to merge this pull request.

Assignees

@subfuzion subfuzion

Labels
api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gryczj @subfuzion @kokoro-team