Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consume reservations samples #3877

Merged
merged 2 commits into from
Oct 7, 2024
Merged

feat: consume reservations samples #3877

merged 2 commits into from
Oct 7, 2024

Conversation

gryczj
Copy link
Contributor

@gryczj gryczj commented Sep 23, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Sep 23, 2024
@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 23, 2024
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 23, 2024
@gryczj
Copy link
Contributor Author

gryczj commented Oct 3, 2024

Pipeline should be fixed after merging #3868

@gryczj gryczj marked this pull request as ready for review October 3, 2024 19:02
@gryczj gryczj requested review from a team as code owners October 3, 2024 19:02
Copy link

snippet-bot bot commented Oct 3, 2024

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gryczj gryczj marked this pull request as draft October 7, 2024 14:26
@gryczj gryczj force-pushed the consume_reservations branch 2 times, most recently from 8bf0574 to 4776e6c Compare October 7, 2024 17:07
@gryczj gryczj marked this pull request as ready for review October 7, 2024 17:37
@subfuzion subfuzion merged commit cb91d9c into main Oct 7, 2024
32 checks passed
@subfuzion subfuzion deleted the consume_reservations branch October 7, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants