Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: use "App Engine" instead of flexible environment #635

Merged
merged 4 commits into from
Jun 5, 2018
Merged

README: use "App Engine" instead of flexible environment #635

merged 4 commits into from
Jun 5, 2018

Conversation

steren
Copy link
Contributor

@steren steren commented Jun 5, 2018

No description provided.

fhinkel
fhinkel approved these changes Jun 5, 2018
View reviewed changes
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Jun 5, 2018 •
edited
Loading

Codecov Report

Merging #635 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #635   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 348916f...5f9be25. Read the comment docs.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@broady broady added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jun 5, 2018
@fhinkel fhinkel added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 5, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@fhinkel fhinkel merged commit 93657a5 into GoogleCloudPlatform:master Jun 5, 2018
@snyk-bot snyk-bot mentioned this pull request Dec 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Sep 6, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Feb 10, 2022
Open
grayside pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore: release 4.0.1 (#635)
43810ff 
🤖 I have created a release \*beep\* \*boop\* 
---
### [4.0.1](https://www.github.com/googleapis/cloud-profiler-nodejs/compare/v4.0.0...v4.0.1) (2020-07-09)


### Bug Fixes

* **deps:** update dependency pretty-ms to v7 ([#642](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/642)) ([f69c7a7](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/f69c7a73b17c150c2b523412e430b5d1ac03e12a))
* **deps:** update dependency protobufjs to ~6.9.0 ([#634](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/634)) ([a90149c](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/a90149c4f91630d75bb41fab145713637736d21c))
* malformed tsconfig causing broken tests [#640](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/640) ([#647](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/647)) ([09c19c8](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/09c19c88a0ca137b7970c386730b145b66b77ec3))
* **deps:** update dependency teeny-request to v7 ([#652](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/652)) ([b46eb4f](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/b46eb4f2552871f405579100e4e916dbde5c60d8))
* typeo in nodejs .gitattribute ([#661](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/661)) ([92f46ac](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/92f46ac22a510c7bab05549b83779dd4f60096b7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@grayside grayside mentioned this pull request Nov 11, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore(main): release 3.1.2 (#635)
f3931af 
🤖 I have created a release *beep* *boop*
---


## [3.1.2](https://github.com/googleapis/nodejs-automl/compare/v3.1.1...v3.1.2) (2022-09-22)


### Bug Fixes

* Preserve default values in x-goog-request-params header ([#634](https://github.com/googleapis/nodejs-automl/issues/634)) ([1949bf9](https://github.com/googleapis/nodejs-automl/commit/1949bf9a26b63b4eefd13f5c6164691db46a0df2))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@ace-n ace-n mentioned this pull request Nov 11, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore(main): release 3.1.2 (#635)
9000c63 
🤖 I have created a release *beep* *boop*
---


## [3.1.2](https://github.com/googleapis/nodejs-automl/compare/v3.1.1...v3.1.2) (2022-09-22)


### Bug Fixes

* Preserve default values in x-goog-request-params header ([#634](https://github.com/googleapis/nodejs-automl/issues/634)) ([1949bf9](https://github.com/googleapis/nodejs-automl/commit/1949bf9a26b63b4eefd13f5c6164691db46a0df2))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 12, 2022
@release-please
chore: release 4.0.1 (#635)
e418a66 
🤖 I have created a release \*beep\* \*boop\* 
---
### [4.0.1](https://www.github.com/googleapis/cloud-profiler-nodejs/compare/v4.0.0...v4.0.1) (2020-07-09)


### Bug Fixes

* **deps:** update dependency pretty-ms to v7 ([#642](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/642)) ([f69c7a7](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/f69c7a73b17c150c2b523412e430b5d1ac03e12a))
* **deps:** update dependency protobufjs to ~6.9.0 ([#634](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/634)) ([a90149c](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/a90149c4f91630d75bb41fab145713637736d21c))
* malformed tsconfig causing broken tests [#640](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/640) ([#647](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/647)) ([09c19c8](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/09c19c88a0ca137b7970c386730b145b66b77ec3))
* **deps:** update dependency teeny-request to v7 ([#652](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/652)) ([b46eb4f](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/b46eb4f2552871f405579100e4e916dbde5c60d8))
* typeo in nodejs .gitattribute ([#661](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/661)) ([92f46ac](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/92f46ac22a510c7bab05549b83779dd4f60096b7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ace-n pushed a commit that referenced this pull request Nov 14, 2022
@release-please
chore(main): release 3.1.2 (#635)
73c1817 
🤖 I have created a release *beep* *boop*
---


## [3.1.2](https://github.com/googleapis/nodejs-automl/compare/v3.1.1...v3.1.2) (2022-09-22)


### Bug Fixes

* Preserve default values in x-goog-request-params header ([#634](https://github.com/googleapis/nodejs-automl/issues/634)) ([1949bf9](https://github.com/googleapis/nodejs-automl/commit/1949bf9a26b63b4eefd13f5c6164691db46a0df2))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 15, 2022
@release-please
chore(main): release 3.1.2 (#635)
83f5942 
🤖 I have created a release *beep* *boop*
---


## [3.1.2](https://github.com/googleapis/nodejs-automl/compare/v3.1.1...v3.1.2) (2022-09-22)


### Bug Fixes

* Preserve default values in x-goog-request-params header ([#634](https://github.com/googleapis/nodejs-automl/issues/634)) ([1949bf9](https://github.com/googleapis/nodejs-automl/commit/1949bf9a26b63b4eefd13f5c6164691db46a0df2))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 15, 2022
@release-please
chore(main): release 3.1.2 (#635)
2665b58 
🤖 I have created a release *beep* *boop*
---


## [3.1.2](https://github.com/googleapis/nodejs-automl/compare/v3.1.1...v3.1.2) (2022-09-22)


### Bug Fixes

* Preserve default values in x-goog-request-params header ([#634](https://github.com/googleapis/nodejs-automl/issues/634)) ([1949bf9](https://github.com/googleapis/nodejs-automl/commit/1949bf9a26b63b4eefd13f5c6164691db46a0df2))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore(main): release 4.1.0 (#636)
fc5132b 
🤖 I have created a release *beep* *boop*
---


## [4.1.0](googleapis/nodejs-asset@v4.0.0...v4.1.0) (2022-06-29)


### Features

* support regapic LRO ([#635](googleapis/nodejs-asset#635)) ([140ce9d](googleapis/nodejs-asset@140ce9d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore(main): release 4.1.0 (#636)
ba80c0e 
🤖 I have created a release *beep* *boop*
---


## [4.1.0](googleapis/nodejs-asset@v4.0.0...v4.1.0) (2022-06-29)


### Features

* support regapic LRO ([#635](googleapis/nodejs-asset#635)) ([140ce9d](googleapis/nodejs-asset@140ce9d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore(main): release 4.1.0 (#636)
2f8fa61 
🤖 I have created a release *beep* *boop*
---


## [4.1.0](googleapis/nodejs-asset@v4.0.0...v4.1.0) (2022-06-29)


### Features

* support regapic LRO ([#635](googleapis/nodejs-asset#635)) ([140ce9d](googleapis/nodejs-asset@140ce9d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore(main): release 4.1.0 (#636)
727d444 
🤖 I have created a release *beep* *boop*
---


## [4.1.0](googleapis/nodejs-asset@v4.0.0...v4.1.0) (2022-06-29)


### Features

* support regapic LRO ([#635](googleapis/nodejs-asset#635)) ([140ce9d](googleapis/nodejs-asset@140ce9d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore(main): release 4.1.0 (#636)
31ca8a4 
🤖 I have created a release *beep* *boop*
---


## [4.1.0](googleapis/nodejs-asset@v4.0.0...v4.1.0) (2022-06-29)


### Features

* support regapic LRO ([#635](googleapis/nodejs-asset#635)) ([140ce9d](googleapis/nodejs-asset@140ce9d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please
chore(main): release 3.1.2 (#635)
1b02a4b 
🤖 I have created a release *beep* *boop*
---


## [3.1.2](https://github.com/googleapis/nodejs-automl/compare/v3.1.1...v3.1.2) (2022-09-22)


### Bug Fixes

* Preserve default values in x-goog-request-params header ([#634](https://github.com/googleapis/nodejs-automl/issues/634)) ([1949bf9](https://github.com/googleapis/nodejs-automl/commit/1949bf9a26b63b4eefd13f5c6164691db46a0df2))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please
chore(main): release 3.1.2 (#635)
252c522 
🤖 I have created a release *beep* *boop*
---


## [3.1.2](https://github.com/googleapis/nodejs-automl/compare/v3.1.1...v3.1.2) (2022-09-22)


### Bug Fixes

* Preserve default values in x-goog-request-params header ([#634](https://github.com/googleapis/nodejs-automl/issues/634)) ([1949bf9](https://github.com/googleapis/nodejs-automl/commit/1949bf9a26b63b4eefd13f5c6164691db46a0df2))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please
chore(main): release 4.1.0 (#636)
a861295 
🤖 I have created a release *beep* *boop*
---


## [4.1.0](googleapis/nodejs-asset@v4.0.0...v4.1.0) (2022-06-29)


### Features

* support regapic LRO ([#635](googleapis/nodejs-asset#635)) ([140ce9d](googleapis/nodejs-asset@140ce9d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
@release-please @ahrarmonsur
chore(main): release 3.1.2 (#635)
1dffabb 
🤖 I have created a release *beep* *boop*
---


## [3.1.2](https://github.com/googleapis/nodejs-automl/compare/v3.1.1...v3.1.2) (2022-09-22)


### Bug Fixes

* Preserve default values in x-goog-request-params header ([#634](https://github.com/googleapis/nodejs-automl/issues/634)) ([1949bf9](https://github.com/googleapis/nodejs-automl/commit/1949bf9a26b63b4eefd13f5c6164691db46a0df2))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Shabirmean pushed a commit that referenced this pull request Feb 16, 2023
@release-please
chore: release 3.1.6 (#635)
d38937b 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@Shabirmean Shabirmean mentioned this pull request Feb 16, 2023
Merged
@leejh3224 leejh3224 mentioned this pull request Oct 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steren @googlebot @fhinkel @broady