Add missing lint dependency #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
=======================================
Coverage 48.52% 48.52%
=======================================
Files 1 1
Lines 68 68
=======================================
Hits 33 33
Misses 35 35Continue to review full report at Codecov.
|
|
Can you also run |
appengine/analytics/package.json
Outdated
| @@ -21,7 +21,8 @@ | |||
| }, | |||
| "dependencies": { | |||
| "express": "4.16.2", | |||
| "got": "8.2.0" | |||
| "got": "8.2.0", | |||
| "semistandard": "^12.0.1" | |||
There was a problem hiding this comment.
Shouldn't this be a dev dependency? Here and below!
There was a problem hiding this comment.
Oh, yes, you're right. Fixed.
|
|
JustinBeckwith
approved these changes
Jun 5, 2018
kweinmeister
pushed a commit
that referenced
this pull request
Nov 10, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
🤖 I have created a release *beep* *boop* --- ## [4.1.0](googleapis/nodejs-asset@v4.0.0...v4.1.0) (2022-06-29) ### Features * support regapic LRO ([#635](googleapis/nodejs-asset#635)) ([140ce9d](googleapis/nodejs-asset@140ce9d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
🤖 I have created a release *beep* *boop* --- ## [4.1.0](googleapis/nodejs-asset@v4.0.0...v4.1.0) (2022-06-29) ### Features * support regapic LRO ([#635](googleapis/nodejs-asset#635)) ([140ce9d](googleapis/nodejs-asset@140ce9d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
🤖 I have created a release *beep* *boop* --- ## [4.1.0](googleapis/nodejs-asset@v4.0.0...v4.1.0) (2022-06-29) ### Features * support regapic LRO ([#635](googleapis/nodejs-asset#635)) ([140ce9d](googleapis/nodejs-asset@140ce9d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
🤖 I have created a release *beep* *boop* --- ## [4.1.0](googleapis/nodejs-asset@v4.0.0...v4.1.0) (2022-06-29) ### Features * support regapic LRO ([#635](googleapis/nodejs-asset#635)) ([140ce9d](googleapis/nodejs-asset@140ce9d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
🤖 I have created a release *beep* *boop* --- ## [4.1.0](googleapis/nodejs-asset@v4.0.0...v4.1.0) (2022-06-29) ### Features * support regapic LRO ([#635](googleapis/nodejs-asset#635)) ([140ce9d](googleapis/nodejs-asset@140ce9d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release *beep* *boop* --- ## [4.1.0](googleapis/nodejs-asset@v4.0.0...v4.1.0) (2022-06-29) ### Features * support regapic LRO ([#635](googleapis/nodejs-asset#635)) ([140ce9d](googleapis/nodejs-asset@140ce9d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm test, which runs the linter, needs this dependency explicitly.We install
semistandardmanually on CircleCi. But since it's required in a sample'srun test, it should be in thepackage.json.