Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests with functions-emulator #643

Closed
wants to merge 5 commits into from
Closed

Add tests with functions-emulator #643

wants to merge 5 commits into from

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Jun 6, 2018

Working from a fork, because CircleCi is configured differently from fork and I need to see if this works for PRs from forks.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 6, 2018
@fhinkel fhinkel force-pushed the addFunctionEmulatorBackIn branch from 9c86d58 to 3a35070 Compare June 6, 2018 11:59
@codecov
Copy link

codecov bot commented Jun 6, 2018 •
edited
Loading

Codecov Report

Merging #643 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #643   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd0bf0e...f935547. Read the comment docs.

@fhinkel
Copy link
Contributor Author

fhinkel commented Jun 6, 2018

functions-emulator tests for Hello World need multiple environment variables:

  • GOOGLE_APPLICATION_CREDENTIALS
  • GCLOUD_PROJECT
  • FUNCTIONS_TOPIC
  • FUNCTIONS_BUCKET

@fhinkel
Do not run this test on forks.
8ea9426 
See https://circleci.com/docs/1.0/environment-variables/#building-pull-requests-that-come-from-forks

The test need a lot of environment variables. CircleCi does not
expose them on PRs from forks. So we need to skip this test.
@fhinkel
Copy link
Contributor Author

fhinkel commented Jun 6, 2018

See https://discuss.circleci.com/t/running-specific-tests-only-on-a-pull-request/500

@fhinkel fhinkel force-pushed the addFunctionEmulatorBackIn branch from 41b2375 to 71c81c8 Compare June 6, 2018 14:01
@fhinkel
Copy link
Contributor Author

fhinkel commented Jun 6, 2018

Closed via #644

@fhinkel fhinkel closed this Jun 6, 2018
ace-n pushed a commit that referenced this pull request Nov 14, 2022
@bcoe
test: retry flaky firewall tests (#646)
7196384 
Modifies samples so they actually exit with 1 on failure. Add cleanup step and
retry logic to flaky firewall tests.

Fixes #643, #642
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@gcf-owl-bot
chore: remove unused proto imports (#643)
2f87ab6 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 468735472

Source-Link: googleapis/googleapis@cfa1b37

Source-Link: https://github.com/googleapis/googleapis-gen/commit/09b7666656510f5b00b893f003a0ba5766f9e250
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDliNzY2NjY1NjUxMGY1YjAwYjg5M2YwMDNhMGJhNTc2NmY5ZTI1MCJ9

feat: Add client library support for AssetService v1 BatchGetEffectiveIamPolicies API
Committer: haochunzhang@

PiperOrigin-RevId: 468010360

Source-Link: googleapis/googleapis@4bda299

Source-Link: https://github.com/googleapis/googleapis-gen/commit/8ed040614d04743f16cf4e4844b716fed998f94c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGVkMDQwNjE0ZDA0NzQzZjE2Y2Y0ZTQ4NDRiNzE2ZmVkOTk4Zjk0YyJ9

feat: Release of query system
Committer: lvv@

PiperOrigin-RevId: 466748663

Source-Link: googleapis/googleapis@80d630f

Source-Link: https://github.com/googleapis/googleapis-gen/commit/252f5ade18a31a72f12810bbfd1d83d56a8e72e1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjUyZjVhZGUxOGEzMWE3MmYxMjgxMGJiZmQxZDgzZDU2YThlNzJlMSJ9

feat: Add client library support for AssetService v1 BatchGetEffectiveIamPolicies API
Committer: haochunzhang@

PiperOrigin-RevId: 466134014

Source-Link: googleapis/googleapis@63c73fb

Source-Link: https://github.com/googleapis/googleapis-gen/commit/2350945f7a70ecaaecf9a1fdd7d6e70ac50e862d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjM1MDk0NWY3YTcwZWNhYWVjZjlhMWZkZDdkNmU3MGFjNTBlODYyZCJ9
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@gcf-owl-bot
chore: remove unused proto imports (#643)
c9880ae 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 468735472

Source-Link: googleapis/googleapis@cfa1b37

Source-Link: https://github.com/googleapis/googleapis-gen/commit/09b7666656510f5b00b893f003a0ba5766f9e250
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDliNzY2NjY1NjUxMGY1YjAwYjg5M2YwMDNhMGJhNTc2NmY5ZTI1MCJ9

feat: Add client library support for AssetService v1 BatchGetEffectiveIamPolicies API
Committer: haochunzhang@

PiperOrigin-RevId: 468010360

Source-Link: googleapis/googleapis@4bda299

Source-Link: https://github.com/googleapis/googleapis-gen/commit/8ed040614d04743f16cf4e4844b716fed998f94c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGVkMDQwNjE0ZDA0NzQzZjE2Y2Y0ZTQ4NDRiNzE2ZmVkOTk4Zjk0YyJ9

feat: Release of query system
Committer: lvv@

PiperOrigin-RevId: 466748663

Source-Link: googleapis/googleapis@80d630f

Source-Link: https://github.com/googleapis/googleapis-gen/commit/252f5ade18a31a72f12810bbfd1d83d56a8e72e1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjUyZjVhZGUxOGEzMWE3MmYxMjgxMGJiZmQxZDgzZDU2YThlNzJlMSJ9

feat: Add client library support for AssetService v1 BatchGetEffectiveIamPolicies API
Committer: haochunzhang@

PiperOrigin-RevId: 466134014

Source-Link: googleapis/googleapis@63c73fb

Source-Link: https://github.com/googleapis/googleapis-gen/commit/2350945f7a70ecaaecf9a1fdd7d6e70ac50e862d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjM1MDk0NWY3YTcwZWNhYWVjZjlhMWZkZDdkNmU3MGFjNTBlODYyZCJ9
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@gcf-owl-bot
chore: remove unused proto imports (#643)
d09b39a 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 468735472

Source-Link: googleapis/googleapis@cfa1b37

Source-Link: https://github.com/googleapis/googleapis-gen/commit/09b7666656510f5b00b893f003a0ba5766f9e250
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDliNzY2NjY1NjUxMGY1YjAwYjg5M2YwMDNhMGJhNTc2NmY5ZTI1MCJ9

feat: Add client library support for AssetService v1 BatchGetEffectiveIamPolicies API
Committer: haochunzhang@

PiperOrigin-RevId: 468010360

Source-Link: googleapis/googleapis@4bda299

Source-Link: https://github.com/googleapis/googleapis-gen/commit/8ed040614d04743f16cf4e4844b716fed998f94c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGVkMDQwNjE0ZDA0NzQzZjE2Y2Y0ZTQ4NDRiNzE2ZmVkOTk4Zjk0YyJ9

feat: Release of query system
Committer: lvv@

PiperOrigin-RevId: 466748663

Source-Link: googleapis/googleapis@80d630f

Source-Link: https://github.com/googleapis/googleapis-gen/commit/252f5ade18a31a72f12810bbfd1d83d56a8e72e1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjUyZjVhZGUxOGEzMWE3MmYxMjgxMGJiZmQxZDgzZDU2YThlNzJlMSJ9

feat: Add client library support for AssetService v1 BatchGetEffectiveIamPolicies API
Committer: haochunzhang@

PiperOrigin-RevId: 466134014

Source-Link: googleapis/googleapis@63c73fb

Source-Link: https://github.com/googleapis/googleapis-gen/commit/2350945f7a70ecaaecf9a1fdd7d6e70ac50e862d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjM1MDk0NWY3YTcwZWNhYWVjZjlhMWZkZDdkNmU3MGFjNTBlODYyZCJ9
@kweinmeister kweinmeister mentioned this pull request Nov 18, 2022
Merged
kweinmeister pushed a commit that referenced this pull request Nov 18, 2022
@release-please @gcf-owl-bot @sofisl
chore(main): release 4.0.4 (#643)
6653980 
* chore(main): release 4.0.4

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 21, 2022
@bcoe
test: retry flaky firewall tests (#646)
2809f17 
Modifies samples so they actually exit with 1 on failure. Add cleanup step and
retry logic to flaky firewall tests.

Fixes #643, #642
ace-n pushed a commit that referenced this pull request Nov 21, 2022
@bcoe
test: retry flaky firewall tests (#646)
f8f05e5 
Modifies samples so they actually exit with 1 on failure. Add cleanup step and
retry logic to flaky firewall tests.

Fixes #643, #642
@snyk-bot snyk-bot mentioned this pull request Dec 23, 2022
Open
@pedroarapua pedroarapua mentioned this pull request Dec 23, 2022
Open
Shabirmean pushed a commit that referenced this pull request Feb 16, 2023
@release-please
chore: release 3.1.7 (#643)
b1ed064 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@Shabirmean Shabirmean mentioned this pull request Feb 16, 2023
Merged
@pedroarapua pedroarapua mentioned this pull request Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhinkel @googlebot