Add function emulator back in #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://circleci.com/docs/1.0/environment-variables/#building-pull-requests-that-come-from-forks The test need a lot of environment variables. CircleCi does not expose them on PRs from forks. So we need to skip this test.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
=======================================
Coverage 48.52% 48.52%
=======================================
Files 1 1
Lines 68 68
=======================================
Hits 33 33
Misses 35 35Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Jun 6, 2018
kweinmeister
pushed a commit
that referenced
this pull request
Nov 10, 2022
* build!: Update library to use Node 12 Co-authored-by: Summer Ji <summerji@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
* build!: Update library to use Node 12 Co-authored-by: Summer Ji <summerji@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
* build!: Update library to use Node 12 Co-authored-by: Summer Ji <summerji@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
Shabirmean
pushed a commit
that referenced
this pull request
Feb 16, 2023
🤖 I have created a release \*beep\* \*boop\* --- ### [3.1.8](https://www.github.com/googleapis/nodejs-dlp/compare/v3.1.7...v3.1.8) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#644](https://www.github.com/googleapis/nodejs-dlp/issues/644)) ([85847fa](https://www.github.com/googleapis/nodejs-dlp/commit/85847fa2df84bbe11ae7adaffe32c56a881e7546)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the second function emulator test only on PRs from this repo, not from forks. It needs access to multiple environment variables. They are not available on CircleCi for forks. Instead of having the test fail, don't run it.