Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host.id as a fallback for instance #852

Merged
merged 2 commits into from
May 22, 2024

Conversation

dashpole
Copy link
Contributor

This will prevent users from getting a blank instance label for GMP when running on GCE.

FYI @quentinmit @ridwanmsharif @jefferbrecht

@dashpole dashpole requested a review from damemi May 22, 2024 01:31
@dashpole dashpole requested a review from a team as a code owner May 22, 2024 01:31
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.61%. Comparing base (4caace7) to head (9db9356).
Report is 17 commits behind head on main.

Current head 9db9356 differs from pull request most recent head b55a370

Please upload reports for the commit b55a370 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
+ Coverage   61.03%   62.61%   +1.58%     
==========================================
  Files          56       57       +1     
  Lines        5903     4917     -986     
==========================================
- Hits         3603     3079     -524     
+ Misses       2143     1679     -464     
- Partials      157      159       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dashpole dashpole merged commit 4c2cadc into GoogleCloudPlatform:main May 22, 2024
25 of 26 checks passed
@dashpole dashpole deleted the host_id_fallback branch May 22, 2024 15:37
codeboten added a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Jun 19, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go)
| `v1.23.0` -> `v1.24.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fdetectors%2fgcp/v1.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fdetectors%2fgcp/v1.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fdetectors%2fgcp/v1.23.0/v1.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fdetectors%2fgcp/v1.23.0/v1.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go)
| `v0.47.0` -> `v0.48.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector/v0.47.0/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector/v0.47.0/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector/googlemanagedprometheus](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go)
| `v0.47.0` -> `v0.48.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector%2fgooglemanagedprometheus/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector%2fgooglemanagedprometheus/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector%2fgooglemanagedprometheus/v0.47.0/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector%2fgooglemanagedprometheus/v0.47.0/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>GoogleCloudPlatform/opentelemetry-operations-go
(github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector)</summary>

###
[`v0.48.0`](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/releases/tag/v0.48.0):
v1.24.0 and v0.48.0

[Compare
Source](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/compare/v0.47.0...v0.48.0)

##### What's Changed

- Updating packages by
[@&#8203;avilevy18](https://github.com/avilevy18) in
[GoogleCloudPlatform/opentelemetry-operations-go#846
- Bump go to v1.22.3 in ci by
[@&#8203;dashpole](https://github.com/dashpole) in
[GoogleCloudPlatform/opentelemetry-operations-go#849
- Run e2e tests on GAE standard by
[@&#8203;aabmass](https://github.com/aabmass) in
[GoogleCloudPlatform/opentelemetry-operations-go#848
- Add host.id as a fallback for instance by
[@&#8203;dashpole](https://github.com/dashpole) in
[GoogleCloudPlatform/opentelemetry-operations-go#852
- feat(extension/googleclientauth): support id-token by
[@&#8203;rinx](https://github.com/rinx) in
[GoogleCloudPlatform/opentelemetry-operations-go#851
- Add support for exponential histograms in the GMP exporter by
[@&#8203;dashpole](https://github.com/dashpole) in
[GoogleCloudPlatform/opentelemetry-operations-go#853
- Add support for custom MR mapping by
[@&#8203;psx95](https://github.com/psx95) in
[GoogleCloudPlatform/opentelemetry-operations-go#854
- Update CI go version to 1.22.4 by
[@&#8203;psx95](https://github.com/psx95) in
[GoogleCloudPlatform/opentelemetry-operations-go#859
- prepare for v1.24.0/v0.48.0
([#&#8203;858](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/issues/858))
by [@&#8203;psx95](https://github.com/psx95) in
[GoogleCloudPlatform/opentelemetry-operations-go#860

##### New Contributors

- [@&#8203;rinx](https://github.com/rinx) made their first
contribution in
[GoogleCloudPlatform/opentelemetry-operations-go#851

**Full Changelog**:
GoogleCloudPlatform/opentelemetry-operations-go@v0.47.0...v0.48.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jul 11, 2024
)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go)
| `v1.23.0` -> `v1.24.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fdetectors%2fgcp/v1.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fdetectors%2fgcp/v1.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fdetectors%2fgcp/v1.23.0/v1.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fdetectors%2fgcp/v1.23.0/v1.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go)
| `v0.47.0` -> `v0.48.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector/v0.47.0/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector/v0.47.0/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector/googlemanagedprometheus](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go)
| `v0.47.0` -> `v0.48.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector%2fgooglemanagedprometheus/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector%2fgooglemanagedprometheus/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector%2fgooglemanagedprometheus/v0.47.0/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fexporter%2fcollector%2fgooglemanagedprometheus/v0.47.0/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>GoogleCloudPlatform/opentelemetry-operations-go
(github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector)</summary>

###
[`v0.48.0`](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/releases/tag/v0.48.0):
v1.24.0 and v0.48.0

[Compare
Source](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/compare/v0.47.0...v0.48.0)

##### What's Changed

- Updating packages by
[@&open-telemetry#8203;avilevy18](https://github.com/avilevy18) in
[GoogleCloudPlatform/opentelemetry-operations-go#846
- Bump go to v1.22.3 in ci by
[@&open-telemetry#8203;dashpole](https://github.com/dashpole) in
[GoogleCloudPlatform/opentelemetry-operations-go#849
- Run e2e tests on GAE standard by
[@&open-telemetry#8203;aabmass](https://github.com/aabmass) in
[GoogleCloudPlatform/opentelemetry-operations-go#848
- Add host.id as a fallback for instance by
[@&open-telemetry#8203;dashpole](https://github.com/dashpole) in
[GoogleCloudPlatform/opentelemetry-operations-go#852
- feat(extension/googleclientauth): support id-token by
[@&open-telemetry#8203;rinx](https://github.com/rinx) in
[GoogleCloudPlatform/opentelemetry-operations-go#851
- Add support for exponential histograms in the GMP exporter by
[@&open-telemetry#8203;dashpole](https://github.com/dashpole) in
[GoogleCloudPlatform/opentelemetry-operations-go#853
- Add support for custom MR mapping by
[@&open-telemetry#8203;psx95](https://github.com/psx95) in
[GoogleCloudPlatform/opentelemetry-operations-go#854
- Update CI go version to 1.22.4 by
[@&open-telemetry#8203;psx95](https://github.com/psx95) in
[GoogleCloudPlatform/opentelemetry-operations-go#859
- prepare for v1.24.0/v0.48.0
([#&open-telemetry#8203;858](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/issues/858))
by [@&open-telemetry#8203;psx95](https://github.com/psx95) in
[GoogleCloudPlatform/opentelemetry-operations-go#860

##### New Contributors

- [@&open-telemetry#8203;rinx](https://github.com/rinx) made their first
contribution in
[GoogleCloudPlatform/opentelemetry-operations-go#851

**Full Changelog**:
GoogleCloudPlatform/opentelemetry-operations-go@v0.47.0...v0.48.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants