Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate API no longer requires an API key. #248

Merged
merged 1 commit into from
Nov 16, 2016
Merged

Conversation

Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmdobry thanks! This looks great.

# Your Translate API key
$apiKey = 'YOUR_API_KEY';
# Your Google Cloud Platform project ID
$projectId = 'YOUR_PROJECT_ID';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the project ID required in lieu of an API key?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, typical of other cloud samples.

@bshaffer
Copy link
Contributor

Will merge once tests pass

@jmdobry
Copy link
Member Author

jmdobry commented Nov 16, 2016

Can you help me fix the test? I don't understand why it's failing.

@tmatsuo
Copy link
Contributor

tmatsuo commented Nov 16, 2016

The linter complains about unused use statements

@bshaffer bshaffer merged commit 56899a2 into master Nov 16, 2016
@bshaffer bshaffer deleted the update-translate branch November 16, 2016 21:39
@bshaffer
Copy link
Contributor

@jmdobry thanks Jason!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants