Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate API no longer requires an API key. #113

Merged
merged 3 commits into from
Nov 16, 2016

Conversation

@jmdobry
Copy link
Member Author

jmdobry commented Nov 16, 2016

I don't know why the tests are failing. Help? 😕

Also, please verify Gemfile.lock, the important thing was to upgrade google-cloud-translate.

@puneith
Copy link

puneith commented Nov 16, 2016

Lots of stuff removed from Gemfile.lock? And I see some of the test errors like faraday missing due to that?

@jmdobry
Copy link
Member Author

jmdobry commented Nov 16, 2016

I have no idea what I'm doing. 🐶

@frankyn
Copy link
Member

frankyn commented Nov 16, 2016

I attempted to reproduce and I was able to get passed it by including "google-cloud" gem in the Gemfile. Many gems are not installed when only using "google-cloud-translate". I'm not sure why.

Forwarded to "google-cloud" gem issue

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot
Copy link

CLAs look good, thanks!

@frankyn
Copy link
Member

frankyn commented Nov 16, 2016

It was a bug, and it has been fixed. I just committed an updated Gemfile.lock.

@puneith
Copy link

puneith commented Nov 16, 2016

@frankyn Build still red.

@beccasaurus beccasaurus merged commit 18eb00c into master Nov 16, 2016
@beccasaurus beccasaurus deleted the translate-api-updates branch November 16, 2016 19:00
@frankyn
Copy link
Member

frankyn commented Nov 16, 2016

@puneith, the red is for flaky tests. Translate tests passed :)

@jmdobry
Copy link
Member Author

jmdobry commented Nov 16, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants