Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate code from googleapis/python-bigquery-datatransfer #10259

Merged
merged 117 commits into from
Jul 11, 2023

Conversation

dizcology
Copy link
Member

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 16, 2023
@google-cla
Copy link

google-cla bot commented Jun 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dizcology dizcology marked this pull request as ready for review June 16, 2023 21:15
@dizcology dizcology requested review from a team as code owners June 16, 2023 21:15
@snippet-bot
Copy link

snippet-bot bot commented Jun 16, 2023

Here is the summary of changes.

You are about to add 20 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Member

@rsamborski rsamborski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after addressing CODEOWNERs comment. The PR will require an admin merge due to CLA exceptions.

.github/CODEOWNERS Outdated Show resolved Hide resolved
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner June 21, 2023 15:28
tswast and others added 21 commits July 10, 2023 14:16
* BigQuery: Add Data Transfer Service quickstart.

Client library docs:
https://googlecloudplatform.github.io/google-cloud-python/latest/bigquery_datatransfer/index.html

* Enable BigQuery Data Transfer API in test project.
* Remove project from quickstart test assertion. Don't depend on specific data sources being available.

I believe the reason the tests are failing is that the data sources
weren't allowed for the test project because the API was enabled, but
the project wasn't enrolled as described in
https://cloud.google.com/bigquery/docs/enable-transfer-service
* Auto-update dependencies.

* Update requirements.txt
Update region tags because we are treating BigQuery Data Transfer Service as its own product in the samples tracker.
* Auto-update dependencies.

* Update requirements.txt

* Update requirements.txt
* Adds updates including compute

* Python 2 compat pytest

* Fixing weird \r\n issue from GH merge

* Put asset tests back in

* Re-add pod operator test

* Hack parameter for k8s pod operator
…v1 [(#3208)](#3208)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [google-cloud-bigquery-datatransfer](https://github.com/googleapis/python-bigquery-datatransfer) | major | `==0.4.1` -> `==1.0.0` |

---

### Release Notes

<details>
<summary>googleapis/python-bigquery-datatransfer</summary>

### [`v1.0.0`](https://github.com/googleapis/python-bigquery-datatransfer/blob/master/CHANGELOG.md#&#8203;100-httpswwwgithubcomgoogleapispython-bigquery-datatransfercomparev041v100-2020-03-04)

[Compare Source](https://github.com/googleapis/python-bigquery-datatransfer/compare/v0.4.1...v1.0.0)

##### Features

-   **bigquerydatatransfer:** add `service_account_name` option to transfer configs ([#&#8203;10013](https://www.github.com/googleapis/python-bigquery-datatransfer/issues/10013)) ([9ca090a](https://www.github.com/googleapis/python-bigquery-datatransfer/commit/9ca090af431092bc4286fa4443dd0dc0141f6de6))
-   **bigquerydatatransfer:** undeprecate resource name helper methods; add py2 deprecation warning; bump copyright year to 2020 (via synth) ([#&#8203;10226](https://www.github.com/googleapis/python-bigquery-datatransfer/issues/10226)) ([c0f9cc3](https://www.github.com/googleapis/python-bigquery-datatransfer/commit/c0f9cc398e5558002c79a875809bb6cd1a98a8a4))
-   set release_status to production/stable ([#&#8203;15](https://www.github.com/googleapis/python-bigquery-datatransfer/issues/15)) ([a9c1160](https://www.github.com/googleapis/python-bigquery-datatransfer/commit/a9c1160475dbc327e8cc5da3b5aee3ceaa618bd3))

##### Bug Fixes

-   **bigquery_datatransfer:** deprecate resource name helper methods (via synth) ([#&#8203;9829](https://www.github.com/googleapis/python-bigquery-datatransfer/issues/9829)) ([fc06995](https://www.github.com/googleapis/python-bigquery-datatransfer/commit/fc0699549479cc3e34e217f9e588f5128107ba89))

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples).
* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
* chore(deps): update dependency pytest to v5.4.3

* specify pytest for python 2 in appengine

Co-authored-by: Leah Cole <coleleah@google.com>
* chore(deps): update dependency mock to v4

* specify mock version for appengine python 2

Co-authored-by: Leah Cole <coleleah@google.com>
* chore: remove old GAPIC code

* Regenerate the library with microgenerator

* Fix docs toctree includes

* Update Python version compatibility in README

* Adjust samples

* Fix datatransfer shim unit test

* Reduce required coverage threshold

The generated code tests do not cover all code paths after all...

* Simplify TransferConfig instantiation in sample

* Add UPGRADING guide

* Update UPGRADING.md (method name)

Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>

Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
)

* chore: use google.cloud.bigquery_datatransfer namespace

Using google.cloud.bigquery.datatransfer turned out to be too
problematic to use with the google.cloud.bigquery library
(namespace clashes).

* Adjust code to renamed namespace

* Update UPGRADING guide with new (old) namespace
* docs: add sample for dataset copy

* add google-cloud-bigquery to test requirements

* use relative imports to hopefully fix lint
…v3 (#81)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [google-cloud-bigquery-datatransfer](https://github.com/googleapis/python-bigquery-datatransfer) | major | `==2.1.0` -> `==3.0.0` |

---

### Release Notes

<details>
<summary>googleapis/python-bigquery-datatransfer</summary>

### [`v3.0.0`](https://github.com/googleapis/python-bigquery-datatransfer/blob/master/CHANGELOG.md#&#8203;300-httpswwwgithubcomgoogleapispython-bigquery-datatransfercomparev210v300-2020-12-09)

[Compare Source](https://github.com/googleapis/python-bigquery-datatransfer/compare/v2.1.0...v3.0.0)

##### ⚠ BREAKING CHANGES

-   type is renamed to type\_ to avoid conflict with built-in functions (introduced in [googleapis/gapic-generator-python#&#8203;595](https://github.com/googleapis/gapic-generator-python/issues/595))

##### Features

-   add common resource path helpers ([#&#8203;69](https://www.github.com/googleapis/python-bigquery-datatransfer/issues/69)) ([e0bcedb](https://www.github.com/googleapis/python-bigquery-datatransfer/commit/e0bcedb58109e38a58584d5b3087f03e1fa10835))

##### Bug Fixes

-   avoid collision with built-in functions by renaming type property to type\_ ([#&#8203;53](https://www.github.com/googleapis/python-bigquery-datatransfer/issues/53)) ([b954411](https://www.github.com/googleapis/python-bigquery-datatransfer/commit/b95441140f7c86dd3e833aef0532badd6280ef48)), closes [/github.com/googleapis/python-talent/blob/ef045e8eb348db36d7a2a611e6f26b11530d273b/samples/snippets/noxfile_config.py#L27-L32](https://www.github.com/googleapis//github.com/googleapis/python-talent/blob/ef045e8eb348db36d7a2a611e6f26b11530d273b/samples/snippets/noxfile_config.py/issues/L27-L32)

##### Documentation

-   update intersphinx links ([#&#8203;78](https://www.github.com/googleapis/python-bigquery-datatransfer/issues/78)) ([a78ba39](https://www.github.com/googleapis/python-bigquery-datatransfer/commit/a78ba39bf1507cbc9e2a51fe4553d602da7f7601))

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-bigquery-datatransfer).
See samples/ directory for maintained and tested samples
* docs: add scheduled query samples

* test: opt-out of type annotations for now

* test: use environment variable for project ID

* set quota project

* consolidate config creation to conserve quota
renovate-bot and others added 23 commits July 10, 2023 14:16
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
* fix: replaces deprecated snippet

* adds a test

* revises test assert statement

* fix linting

* examining return values

* examining more return values

* examining return values more betterly

* evaluating timestamps in use

* evaluating timestamps in use 2

* clean up test

* clean up linting
* docs: removes deprecated sample

* modifies tags to matched deprecated function call
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@dizcology dizcology force-pushed the python-bigquery-datatransfer-migration branch from 85c62be to ae4686a Compare July 10, 2023 21:21
@dizcology
Copy link
Member Author

Updated the CODEOWNERS change to address the comment.

Next steps:
From @leahecole: "reminder for whoever merges to do "Rebase and merge" from the dropdown to preserve history!"
From @rsamborski: "The PR will require an admin merge due to CLA exceptions."

@leahecole
Copy link
Collaborator

CLA failure is from a xoogler and is ok

@leahecole leahecole merged commit 372cf0d into main Jul 11, 2023
@leahecole leahecole deleted the python-bigquery-datatransfer-migration branch July 11, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants