Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New code samples for Python quickstart for Endpoints Frameworks v2 #463

Merged
merged 1 commit into from
Aug 19, 2016

Conversation

bradfriedman
Copy link
Contributor

These are for the quickstarts for the Endpoints Frameworks v2 for Python beta.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 18, 2016
@theacodes
Copy link
Contributor

theacodes commented Aug 18, 2016

@bradfriedman help me understand how this differs from/relates to @saicheems' sample here?

@bradfriedman
Copy link
Contributor Author

The reason we're migrating the old samples to v2 is so that we don't have to write a whole new tutorial for the Echo sample that @saicheems already wrote. We just wanted to bring the old sample up to v2 for this purpose.

@theacodes
Copy link
Contributor

Gotcha - so this is a separate sample. We'll have two - an echo sample and this sample?

If that's the case, can you make sure both of these are in the endpoints-framework-v2 folder? I guess @saicheems should be under echo and yours can be quickstart.

@theacodes
Copy link
Contributor

(be sure to rebase your branch on master before you do the rename, @saicheems has a README change in before this PR)

@bradfriedman
Copy link
Contributor Author

Sure, PTAL

@theacodes
Copy link
Contributor

Can we drop the backend part from the path too?

(sorry! other than that this sample looks good)

@bradfriedman
Copy link
Contributor Author

PTAL :)

@theacodes
Copy link
Contributor

@dpebot merge when travis passes

@dpebot
Copy link
Collaborator

dpebot commented Aug 18, 2016

Okay! I'll merge when all statuses are green.

@dpebot dpebot added the automerge Merge the pull request once unit tests and other checks pass. label Aug 18, 2016
@dpebot dpebot merged commit 1d14fe3 into GoogleCloudPlatform:master Aug 19, 2016
arbrown pushed a commit that referenced this pull request Nov 14, 2022
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
dandhlee pushed a commit that referenced this pull request Nov 15, 2022
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sita04 pushed a commit that referenced this pull request Feb 7, 2023
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
dizcology pushed a commit that referenced this pull request Jun 16, 2023
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
dizcology pushed a commit that referenced this pull request Jul 10, 2023
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
leahecole pushed a commit that referenced this pull request Jul 11, 2023
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants