Add NetworkSecurity AddressGroup IAM support #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add: NetworkSecurity AddressGroup IAM support * Remove IAM condition support, since API does not seem to support it yet. * Fix copyright * Fix tests * Add legacy_name * Update legacy_name Co-authored-by: Nick Elliot <nickelliot@google.com> --------- Co-authored-by: Nick Elliot <nickelliot@google.com> [upstream:3bde0c1e944bcbf98e145c483e0538b49eb9e782] Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
requested review from
ScottSuarez
and removed request for
a team
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add NetworkSecurity AddressGroup IAM support,
Note, only project level AddressGroups have support for IAM Policies, while the upstream resource
google_network_security_address_groupis implemented to support both org and project parents. Hence the implementation is deviating from the normal flow.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9760