Add NetworkSecurity AddressGroup IAM support

[averbuks]

Add NetworkSecurity AddressGroup IAM support,
Note, only project level AddressGroups have support for IAM Policies, while the upstream resource google_network_security_address_group is implemented to support both org and project parents. Hence the implementation is deviating from the normal flow.

Release Note Template for Downstream PRs (will be copied)

`google_network_security_address_group_iam_*`

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 778 insertions(+), 69 deletions(-))
Terraform Beta: Diff ( 5 files changed, 795 insertions(+), 86 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_security_project_address_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_project_address_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_network_security_project_address_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_project_address_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• networksecurity

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 747 insertions(+), 69 deletions(-))
Terraform Beta: Diff ( 5 files changed, 764 insertions(+), 86 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_security_project_address_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_project_address_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_network_security_project_address_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_project_address_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 29
Passed tests 26
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

• networksecurity

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkSecurityProjectAddressGroupIamBindingGenerated|TestAccNetworkSecurityProjectAddressGroupIamPolicyGenerated|TestAccNetworkSecurityProjectAddressGroupIamMemberGenerated

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetworkSecurityProjectAddressGroupIamBindingGenerated[Error message] [Debug log]
TestAccNetworkSecurityProjectAddressGroupIamPolicyGenerated[Error message] [Debug log]
TestAccNetworkSecurityProjectAddressGroupIamMemberGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 747 insertions(+), 69 deletions(-))
Terraform Beta: Diff ( 5 files changed, 764 insertions(+), 86 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_security_project_address_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_project_address_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_network_security_project_address_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_project_address_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 29
Passed tests 26
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

• networksecurity

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkSecurityProjectAddressGroupIamMemberGenerated|TestAccNetworkSecurityProjectAddressGroupIamBindingGenerated|TestAccNetworkSecurityProjectAddressGroupIamPolicyGenerated

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetworkSecurityProjectAddressGroupIamMemberGenerated[Debug log]
TestAccNetworkSecurityProjectAddressGroupIamBindingGenerated[Debug log]
TestAccNetworkSecurityProjectAddressGroupIamPolicyGenerated[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[averbuks]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 747 insertions(+), 69 deletions(-)) Terraform Beta: Diff ( 5 files changed, 764 insertions(+), 86 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_security_project_address_group_iam_binding (2 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_project_address_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_network_security_project_address_group_iam_member (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_project_address_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Address Group IAM Policy does not seem to support IAM conditions

[NickElliot]

a couple things I think should be changed otherwise LGTM!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 678 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 678 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: AddressGroup_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "AddressGroup_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: AddressGroup_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "AddressGroup_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 29
Passed tests 26
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

• networksecurity

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkSecurityProjectAddressGroupIamBindingGenerated|TestAccNetworkSecurityProjectAddressGroupIamMemberGenerated|TestAccNetworkSecurityProjectAddressGroupIamPolicyGenerated

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetworkSecurityProjectAddressGroupIamBindingGenerated[Error message] [Debug log]
TestAccNetworkSecurityProjectAddressGroupIamMemberGenerated[Error message] [Debug log]
TestAccNetworkSecurityProjectAddressGroupIamPolicyGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[NickElliot]

Should be better after this

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 678 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 678 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_security_address_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_address_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_network_security_address_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_address_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 29
Passed tests 29
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• networksecurity

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[NickElliot]

LGTM! missing test detector does not apply for the conditions here.