Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NetworkSecurity AddressGroup IAM support #17013

Conversation

modular-magician
Copy link
Collaborator

Add NetworkSecurity AddressGroup IAM support,
Note, only project level AddressGroups have support for IAM Policies, while the upstream resource google_network_security_address_group is implemented to support both org and project parents. Hence the implementation is deviating from the normal flow.

Release Note Template for Downstream PRs (will be copied)

`google_network_security_address_group_iam_*`

Derived from GoogleCloudPlatform/magic-modules#9760

* add: NetworkSecurity AddressGroup IAM support

* Remove IAM condition support, since API does not seem to support it yet.

* Fix copyright

* Fix tests

* Add legacy_name

* Update legacy_name

Co-authored-by: Nick Elliot <nickelliot@google.com>

---------

Co-authored-by: Nick Elliot <nickelliot@google.com>
[upstream:3bde0c1e944bcbf98e145c483e0538b49eb9e782]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit a3e5a56 into hashicorp:main Jan 16, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant