This repository has been archived by the owner on May 15, 2023. It is now read-only.
Revert "Fix cloud_identity_group_membership to properly handle 403 responses" #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sponses when membership does not exist (#6999)" (#7032) This reverts commit 927d9e93ddc2fe8a28c4fcc6eb50c009dea86174. Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
requested review from
ScottSuarez
and removed request for
a team
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts GoogleCloudPlatform/magic-modules#6999 - unfortunately the current implementation seems to cause crashes after first run. I'm not quite sure but I think maybe it needs to do some additional cleanup after? Figure it's easier to revert for now & take our time to roll it out again after the holidays.
Derived from GoogleCloudPlatform/magic-modules#7032