-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Fix cloud_identity_group_membership to properly handle 403 responses" #7032
Revert "Fix cloud_identity_group_membership to properly handle 403 responses" #7032
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Yikes, yep looks like some cleanup went wrong |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 1 insertion(+), 110 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample |
…sponses when membership does not exist (GoogleCloudPlatform#6999)" (GoogleCloudPlatform#7032) This reverts commit 927d9e9.
…sponses when membership does not exist (GoogleCloudPlatform#6999)" (GoogleCloudPlatform#7032) This reverts commit 927d9e9.
…sponses when membership does not exist (GoogleCloudPlatform#6999)" (GoogleCloudPlatform#7032) This reverts commit 927d9e9.
Reverts #6999 - unfortunately the current implementation seems to cause crashes after first run. I'm not quite sure but I think maybe it needs to do some additional cleanup after? Figure it's easier to revert for now & take our time to roll it out again after the holidays.