Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix cloud_identity_group_membership to properly handle 403 responses" #7032

Merged

Conversation

melinath
Copy link
Member

@melinath melinath commented Dec 22, 2022

Reverts #6999 - unfortunately the current implementation seems to cause crashes after first run. I'm not quite sure but I think maybe it needs to do some additional cleanup after? Figure it's easier to revert for now & take our time to roll it out again after the holidays.

…sponses when membership does not exist (#6999)"

This reverts commit 927d9e9.
@melinath melinath requested a review from roaks3 December 22, 2022 21:42
@modular-magician

This comment was marked as resolved.

@melinath melinath mentioned this pull request Dec 22, 2022
5 tasks
@melinath melinath requested review from slevenick and removed request for roaks3 December 22, 2022 21:44
@modular-magician

This comment was marked as resolved.

@roaks3
Copy link
Contributor

roaks3 commented Dec 22, 2022

Yikes, yep looks like some cleanup went wrong

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 1 insertion(+), 110 deletions(-))
Terraform Beta: Diff ( 3 files changed, 1 insertion(+), 110 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2377
Passed tests 2126
Skipped tests: 248
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]

All tests passed
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants