Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloud_identity_group_membership to properly handle 403 responses #5103

Conversation

modular-magician
Copy link
Collaborator

Re-applying fix from GoogleCloudPlatform/magic-modules#6999

The previous fix was deemed to be correct, but the tests caused our build to panic on subsequent PRs. As a mitigation, the original PR was reverted: GoogleCloudPlatform/magic-modules#7032. It appears that this was happening because the test creates a service account out-of-band that is not recorded or replayed in VCR mode. This led to the service account getting created on each replay, but not deleted, and ultimately produced an error that the service account already existed.

The resolution here is simply to skip this test for VCR mode. I was unable to come up with a way to perform this test without the out-of-band service account, and trying to manage that service account during VCR runs became brittle.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#7089

…ashicorp#7089)

* Fix cloud_identity_group_membership to properly handle 403 responses when membership does not exist

* Fix service account creation errors to cause entire test to fail immediately

* Skip VCR for this test to avoid managing service accounts out-of-band

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 6a0d5e5 into hashicorp:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant